Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup docker build time #463

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Speedup docker build time #463

merged 1 commit into from
Feb 17, 2024

Conversation

anonychun
Copy link
Contributor

Previously individual layers within the Dockerfile installed the same some dependencies repeatedly, causing redundancy and build time increase.

This change:
Moves commonly used dependencies to the base layer of the Dockerfile.
Other layers now inherit these dependencies from the base layer, avoiding redundant installations.
This approach leverages Docker's layering mechanism to ensure all layers have access to required dependencies while eliminating unnecessary repetition.

@robzolkos
Copy link
Contributor

Since this is using the stock standard production Dockerfile that comes with Rails - would it be better to have this upstreamed into Rails (where more eyes could get a look at it). Thoughts @anonychun ?

@anonychun
Copy link
Contributor Author

I already created pull request to Rails, and already being merge rails/rails#51063

@zachgoll zachgoll merged commit ffc33cb into maybe-finance:main Feb 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants