Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker push workflow #327

Closed
wants to merge 1 commit into from

Conversation

indykoning
Copy link

This will automatically push docker images into the github container repository under the organisation

branches:
- 'main'
tags:
- '*'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to push only certain tags, for example:

Suggested change
- '*'
- 'RC*'
- 'preview*

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During development i absolutely agree, though wouldn't we want real version numbers such as 1.0.0 or 2024.2 to have their image created as well?

@zachgoll
Copy link
Collaborator

zachgoll commented Feb 13, 2024

@indykoning this is great, but our Dockerfile is not quite ready and we'll want to make sure that once we start pushing images to GHCR, all images work.

I think we can either close this out and come back to it later or make the Dockerfile updates directly in this PR

Ultimately, I think we're a bit early with this step as we still have lots of code to write which may affect services packed into the Dockerfile

@zachgoll
Copy link
Collaborator

Closing out, will reference this when we introduce official support for a Dockerfile.

@zachgoll zachgoll closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants