Fixes: Sidebar only displays cash balance for investment accounts, not full value #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgoll
reviewed
Nov 11, 2024
| @@ -109,7 +109,7 @@ def net_worth | |||
| end | |||
|
|
|||
| def assets | |||
| Money.new(accounts.active.assets.map { |account| account.balance_money.exchange_to(currency, fallback_rate: 0) }.sum, currency) | |||
There was a problem hiding this comment.
In these two places, we will need to call account.value.exchange_to(currency, fallback_rate: 0) so that users with accounts in multiple currencies can be "rolled up" properly.
|
Closing as this should be fixed via #1526 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1369
PR fixes current issue with sidebar only showing cash value and not full account value.