Bump up to Rails 7.2 #604
Open
Bump up to Rails 7.2 #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-H-GAMELINKS
commented
Dec 16, 2024
|
|
||
| def inbox_url | ||
| "https://#{ENV['DOMAIN']}/inbox" | ||
| end |
Contributor
Author
There was a problem hiding this comment.
default_url_optionsの挙動が変更されており、そのまま扱うのは難しいと判断して環境変数を使うように変更しています。
|
|
||
| def acct | ||
| 'acct:relay@' + Rails.application.default_url_options[:host] | ||
| "acct:relay@#{ENV["DOMAIN"]}" |
Contributor
Author
There was a problem hiding this comment.
同じく環境変数を使うように変更しています
|
|
||
| def actor_url | ||
| PubRelay::Application.routes.url_helpers.actor_url | ||
| "https://#{ENV['DOMAIN']}/actor" |
| type: "Follow", | ||
| actor: @actor['id'], | ||
| object: URI.join(Rails.application.routes.url_helpers.root_url, "/actor") | ||
| object: "https://#{ENV["DOMAIN"]}/actor" |
Contributor
Author
There was a problem hiding this comment.
こちらも同じく環境変数を使うように変更しています
|
|
||
| module PubRelay | ||
| class CLI < Thor | ||
| class Cli < Thor |
Contributor
Author
There was a problem hiding this comment.
定数読み込み周りの対応で定数名などを変更しています
|
|
||
| # Use a different cache store in production. | ||
| # config.cache_store = :mem_cache_store | ||
| config.cache_store = :redis_store, { url: ENV['REDIS_URL'] } |
Contributor
Author
There was a problem hiding this comment.
pub-relay-prototype全体で有効にしていたRedisでのキャッシュを本番環境のみで有効にするように変更しています。
そのため #601 でREDIS_URLが不要とコメントしていましたが一旦残す方向で対応できればと思います。
REDIS_URLとは別にREDIS_HOSTなどを設定すればOKですね
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
pub-relayprototypeで利用するRailsのバージョンを7.2系列にあげています。
内容
備考
またfedifyを利用してローカル環境で建てたリレーサーバからリレーに参加し、投稿が配送されているログまでは確認が取れています。