Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop code coverage ignore blocks and improve test coverage #52

Open
ghost opened this issue Oct 27, 2017 · 0 comments
Open

Drop code coverage ignore blocks and improve test coverage #52

ghost opened this issue Oct 27, 2017 · 0 comments
Labels
testsuite

Comments

@ghost
Copy link

ghost commented Oct 27, 2017 •
edited by ghost
Loading

We have a lot of @codeCoverageIgnore blocks about the source; some are due to driver features which are not easily tested using PDO with drivers like the SQLite driver for integration, some are due to hard to test situations that we were (somewhat) lazy to check for first time around. Let's try to bring these blocks down to a bare minimum.
@ghost ghost added the testsuite label Oct 27, 2017
@ghost ghost self-assigned this Oct 27, 2017
ghost pushed a commit that referenced this issue Oct 28, 2017
@borb
drop coverage ignore, monkey patch trigger_error
0b69be2 
issue #52: replace some of these hacked up mechanisms to catch results
from trigger_error(). use an exception so we can catch with phpunit.
ghost pushed a commit that referenced this issue Oct 28, 2017
@borb
issue #52: missed this use
66a0e1b
@ghost ghost changed the title Drop as many code coverage ignore blocks and improve test coverage Drop code coverage ignore blocks and improve test coverage Oct 28, 2017
@ghost ghost mentioned this issue Oct 28, 2017
Merged
ghost pushed a commit that referenced this issue Oct 29, 2017
@borb
write an opaque data test using vfsStream
98cb2c5 
improving test coverage as per issue #52
ghost pushed a commit that referenced this issue Oct 29, 2017
@borb
drop codeCoverageIgnore, use file_put_contents
f6401f9 
as per issue #52
ghost pushed a commit that referenced this issue Oct 31, 2017
@borb
some more hard-to-test conditions
0b0363a 
issue #52
@borb borb mentioned this issue Oct 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testsuite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants