Add optional attribute to emit event while sliding the cursor #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The consumer of this component can listen for the `range-changed` event when the user has adjusted the ranges. By default the event triggers only when the change has been completed, that is when the sliding movement has finished. In some cases the consumer may want to listen for changes also while sliding the cursor, for example when using custom labels. This is now possible by setting the `emit-event-on-update` attribute.
|
Thank you @dapicester - and kudos for updating the README as well! It's been merged in. |
|
@dapicester I updated the version and this is now included in |
|
Thanks @maxshuty. However I did realize that I had a typo. I did a last minute rename and I got the name wrong. I will submit another MR to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consumer of this component can listen for the
range-changedevent when the user has adjusted the ranges.By default the event triggers only when the change has been completed, that is when the sliding movement has finished.
In some cases the consumer may want to listen for changes also while sliding the cursor, for example when using custom labels.
This is now possible by setting the
emit-event-on-updateattribute.