This repository has been archived by the owner on Dec 22, 2020. It is now read-only.
Super simple game sync #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Game data from the server will now be parsed and injected into the HTML via the python server. Once the HTML loads, the game data will automatically be rendered. This works as many times as you refresh the page!
|
LGTM, thanks for this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo server now injects the game data into the HTML.
By the time the page has loaded, the game data has already been downloaded and synced. This opens up the possibility of continuing game play across devices and browser sessions. A demo /sync has also been added (but doesn't do anything useful, yet).
Thanks to @macfergus for helping out with #45.