-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
cache-manager
v5 changed ttl from milliseconds to seconds.
So, if we works with cache-manager v5, we already use ms by default.
But here under the hood mset
multiply provided ttl by 1000.
node-cache-manager-sqlite/index.js
Line 171 in 36a1fe4
const ttl = (options.ttl || this.#default_ttl) * 1000 |
Suggestion: drop multiplying, add cache-manager v5+ to peer-deeps and increase major version of package.
upd: looks like cache-manager v5 changed a lot since v4, at least they not use callbacks anymore, so requires a bit more work for update current package.
Metadata
Metadata
Assignees
Labels
No labels