-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for inserting ranges. #25
Conversation
golint fails with:
I think we probably shouldn't rename them as they're already public, but what do you think? |
I believe both of those were only just added. We were planning on renaming them when we noticed the issue earlier this week. We haven't done a formal release of this module yet and I don't know if anyone other than you would be using them. Renaming them here or separately seems good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I had a couple of minor comments.
Thanks @oschwald, I've renamed the funcs, added more test cases, and added the range-error check. |
@oschwald Sorry to bump, but if you could review/merge this by today I'd be grateful: I need to use it somewhere ASAP 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks!
Closes #23