Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inserting ranges. #25

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Conversation

UmanShahzad
Copy link
Contributor

Closes #23

@UmanShahzad
Copy link
Contributor Author

golint fails with:

Warning: exported: type name will be used as inserter.InserterFunc by other packages, and that stutters; consider calling this Func (revive)
Warning: exported: type name will be used as inserter.InserterFuncGenerator by other packages, and that stutters; consider calling this FuncGenerator (revive)

I think we probably shouldn't rename them as they're already public, but what do you think?

@oschwald
Copy link
Member

I believe both of those were only just added. We were planning on renaming them when we noticed the issue earlier this week. We haven't done a formal release of this module yet and I don't know if anyone other than you would be using them. Renaming them here or separately seems good.

Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had a couple of minor comments.

@UmanShahzad
Copy link
Contributor Author

Thanks @oschwald, I've renamed the funcs, added more test cases, and added the range-error check.

@UmanShahzad
Copy link
Contributor Author

@oschwald Sorry to bump, but if you could review/merge this by today I'd be grateful: I need to use it somewhere ASAP 😄

@UmanShahzad UmanShahzad requested a review from oschwald August 19, 2021 12:07
Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@oschwald oschwald merged commit efe6d8e into maxmind:main Aug 19, 2021
@UmanShahzad UmanShahzad deleted the insert-range branch August 19, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow inserting ranges
2 participants