-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow inserting ranges #23
Comments
I can possibly contribute this feature. |
@oschwald would you be okay if I had to include a new library for achieving this? I can add the parts needed inline here but then you'd have to be responsible to maintain the difference. |
That seems fine. Did you have a particular library in mind? |
I'm fine with whatever you decide; can use either lib. Either way, a library will be needed, since we need to work on 128-bit numbers for calculating ipv6 subnets from ranges efficiently. It's not a lot of code to implement the needed 128-bit adds + bitwise-and/or, but guessing you don't want that in the codebase. |
I'd prefer |
Alright, no problem. Will probably make a PR tomorrow. |
Made #25 |
The Perl writer allows inserting IP ranges as well as IP networks. The Go writer only supports IP networks currently, so users requiring range insertions must convert ranges to networks manually first.
The text was updated successfully, but these errors were encountered: