Add support for setting the network associated with the record #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when deserializing.
oschwald
commented
Sep 17, 2019
| @@ -0,0 +1,135 @@ | |||
| #region | |||
There was a problem hiding this comment.
This is just a class used in the deserialization tests. It is the same as TypeHolder except without the new network fields. I did this so that I didn't have to make significant changes to the database enumeration tests.
horgh
requested changes
Sep 17, 2019
oschwald
force-pushed
the
greg/network-fixes
branch
2 times, most recently
from
c0f2f1b
to
e1a9ca6
Compare
oschwald
force-pushed
the
greg/network-fixes
branch
from
e1a9ca6
to
a396c30
Compare
horgh
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing the object.
This also enhances the tests around getting the prefix length and includes some general code clean-up/modernization.
After doing many runs of the included benchmark, the before and after differences do not appear to be statistically significant. There were some small performance improvements, but then there is the cost of creating the Network object, passing it around, checking if the constructor param needs to be set, etc.