Optimize ArrayBuffer BytesFromStream #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stream.Length <= int.MaxValue, the stream can just be read in one go into a byte[], instead of going through MemoryStream.ToArray(). This reduces the number of byte[] allocations when initializing.
|
Thanks for the PR! It looks like the tests are failing. Also, please update the tests to ensure both the new code path and the old code path are tested. |
|
Broken test has been fixed. Right now, the new code path will always be used. Does MaxMind have any test databases that are larger than int.MaxValue (2,147,483,647 bytes / ~2 GB) to use in a test for the original code path? |
|
Couldn't we test the old code path by using a stream that doesn't support seeking? Maybe a |
|
That could make sense, will see if I can add that. |
|
Added a test for it. |
|
Thanks! |
oschwald
added a commit
that referenced
this pull request
Jul 31, 2017
oschwald
added a commit
that referenced
this pull request
Jul 11, 2019
Optimize ArrayBuffer BytesFromStream
oschwald
added a commit
that referenced
this pull request
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stream.Length <= int.MaxValue, the stream can just be read in one
go into a byte[], instead of going through MemoryStream.ToArray(). This
reduces the number of byte[] allocations when initializing.