Inject IP address via Jackson #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids mutating the JSON tree objects.
Made it consistent with the behavior of DatabaseReader, which also injects the ip address / traits.
| mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, | ||
| false); | ||
| mapper.configure(MapperFeature.CAN_OVERRIDE_ACCESS_MODIFIERS, false); | ||
| String ip = ipAddress == null ? null : ipAddress.getHostAddress(); |
There was a problem hiding this comment.
The web service will always return an IP address on a successful request. We should just use that value.
There was a problem hiding this comment.
If there's a value in the response JSON, it will override the injection.
oschwald
added a commit
that referenced
this pull request
Jan 12, 2016
Inject IP address via Jackson
|
Thanks yet again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids mutating the JSON tree objects. See also maxmind/MaxMind-DB-Reader-java#13