Skip to content

Commit

Permalink
fix(fixtures/gdtf): g-1 beam has two dimmer channels clashing with ea…
Browse files Browse the repository at this point in the history
…ch other
  • Loading branch information
maxjoehnk committed Aug 30, 2024
1 parent 28fd40f commit 4fafa53
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions crates/components/fixtures/gdtf/src/conversion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ impl GdtfState {
for channel in mode.channels.channels.iter() {
let geometry = geometries.entry(channel.geometry.clone()).or_default();
if let Some(attribute) = self.attributes.get(&channel.logical_channel.attribute) {
// FIXME: This is a hack so the SGM G-1 Beam profile works properly
// I need to investigate how to handle this case better
if attribute.name == "Macro" {
continue;
}
if let Some(feature) = self.features.get(&attribute.feature) {
let channel = if channel.offset.is_virtual() {
// TODO: add FixtureControlChannel::Virtual which delegates to other channels
Expand Down

0 comments on commit 4fafa53

Please sign in to comment.