Additional fix to poll hardening to improve data sync#90
Merged
pavoni merged 5 commits intomaximvelichko:masterfrom May 16, 2018
Merged
Additional fix to poll hardening to improve data sync#90pavoni merged 5 commits intomaximvelichko:masterfrom
pavoni merged 5 commits intomaximvelichko:masterfrom
Conversation
Contributor
Author
|
By the way, there's really only a one-line change here (plus a comment) in subscribe.py (line 157/8). The remaining changes are my editor removing trailing whitespace from the files. |
Contributor
Author
|
Paging @pavoni, and feedback on this one? |
Collaborator
|
Sorry for the long delay - this looks great. Thanks for the contribution, will release a new version shortly. |
Collaborator
|
Now released as 0.2.43. Let me know if you'd like me to do the HA update. |
Contributor
Author
|
I'll leave it to you, please. I still need to bring my dev environment up to where I can run tox and handle all of the other steps separate from my live installation. |
Collaborator
|
Added here home-assistant/core#14540 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #89 , Vera gives inaccurate results across Luup reloads if the timestamp parameters (loadtime and dataversion) are used spanning the reload. That is, if a reload occurs, and Vera is then presented with a dataversion from before the reload, it will give inaccurate deltas not just to the initial call, but to subsequent calls as well. Resetting the timestamp on an exception (usually a RequestException resulting from Vera being unreachable during its reload) forces the next long pull to return a full data set, resyncing the local data and providing a stable dataversion with which to continue.