chore: shifted http-transport to core/v1.1.3#90
Conversation
|
Caution Review failedThe pull request is closed. Summary by CodeRabbit
Summary by CodeRabbit
WalkthroughThe changes update the internal structuring of the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
transports/go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
transports/bifrost-http/integrations/anthropic/types.go(1 hunks)transports/go.mod(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
transports/bifrost-http/integrations/anthropic/types.go (2)
Learnt from: Pratham-Mishra04
PR: maximhq/bifrost#55
File: core/providers/anthropic.go:483-494
Timestamp: 2025-06-04T09:36:27.956Z
Learning: In the Anthropic provider (core/providers/anthropic.go), the user has confirmed through practical experience that the tool_choice parameter should always use an object format with a "type" field (e.g., {"type": "auto"}, {"type": "tool", "name": "function_name"}), even though the official documentation examples sometimes show "auto" as a direct string. The current implementation correctly handles all tool choice types with the object format.
Learnt from: Pratham-Mishra04
PR: maximhq/bifrost#83
File: core/schemas/bifrost.go:186-190
Timestamp: 2025-06-15T14:18:32.703Z
Learning: In core/schemas/bifrost.go, the ToolChoice UnmarshalJSON validation intentionally only checks for empty Type fields and lets providers handle validation of specific tool choice values. This architectural decision keeps schema validation focused on structure while allowing provider-specific semantic validation.
🧬 Code Graph Analysis (1)
transports/bifrost-http/integrations/anthropic/types.go (1)
core/schemas/bifrost.go (6)
ToolChoiceStruct(144-147)ToolChoiceType(123-123)ToolChoice(150-153)ToolChoiceTypeFunction(133-133)Function(108-112)ToolChoiceFunction(139-141)
0263e2c to
003df5d
Compare
b28d30b to
7c27aee
Compare
003df5d to
418d7ae
Compare
7c27aee to
03768a6
Compare
418d7ae to
c80be38
Compare
03768a6 to
300f751
Compare
Merge activity
|
300f751 to
15bab3a
Compare
There was a problem hiding this comment.
✅ BugBot reviewed your changes and found no bugs!
BugBot free trial expires on June 17, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
Updated Anthropic integration to use the new ToolChoiceStruct in the Bifrost schema. This change adapts the Anthropic message request conversion to properly structure tool choice parameters according to the latest core library schema (v1.1.3).

Updated Anthropic integration to use the new ToolChoiceStruct in the Bifrost schema. This change adapts the Anthropic message request conversion to properly structure tool choice parameters according to the latest core library schema (v1.1.3).