Skip to content

bug: fixed provider level minor message parsing bugs #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 1 commit into from
Jun 12, 2025
Merged

bug: fixed provider level minor message parsing bugs #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions core/providers/anthropic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,8 +335,11 @@ func buildAnthropicImageSourceMap(imgContent *schemas.ImageURLStruct) map[string
urlTypeInfo := ExtractURLTypeInfo(sanitizedURL)

formattedImgContent := AnthropicImageContent{
Type: urlTypeInfo.Type,
MediaType: *urlTypeInfo.MediaType,
Type: urlTypeInfo.Type,
}

if urlTypeInfo.MediaType != nil {
formattedImgContent.MediaType = *urlTypeInfo.MediaType
}

if urlTypeInfo.DataURLWithoutPrefix != nil {
Expand Down
7 changes: 5 additions & 2 deletions core/providers/bedrock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,8 +522,11 @@ func (provider *BedrockProvider) prepareChatCompletionMessages(messages []schema
urlTypeInfo := ExtractURLTypeInfo(sanitizedURL)

formattedImgContent := AnthropicImageContent{
Type: urlTypeInfo.Type,
MediaType: *urlTypeInfo.MediaType,
Type: urlTypeInfo.Type,
}

if urlTypeInfo.MediaType != nil {
formattedImgContent.MediaType = *urlTypeInfo.MediaType
}

if urlTypeInfo.DataURLWithoutPrefix != nil {
Expand Down
9 changes: 6 additions & 3 deletions core/providers/cohere.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,9 +459,12 @@ func processImageContent(imageContent *schemas.ImageURLStruct) map[string]interf
urlTypeInfo := ExtractURLTypeInfo(sanitizedURL)

formattedImgContent := AnthropicImageContent{
Type: urlTypeInfo.Type,
URL: sanitizedURL,
MediaType: *urlTypeInfo.MediaType,
Type: urlTypeInfo.Type,
URL: sanitizedURL,
}

if urlTypeInfo.MediaType != nil {
formattedImgContent.MediaType = *urlTypeInfo.MediaType
}
Comment thread
Pratham-Mishra04 marked this conversation as resolved.

return map[string]interface{}{
Expand Down
2 changes: 1 addition & 1 deletion core/providers/openai.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ func prepareOpenAIChatRequest(messages []schemas.BifrostMessage, params *schemas
if msg.Role == schemas.ModelChatMessageRoleAssistant {
assistantMessage := map[string]interface{}{
"role": msg.Role,
"content": coalesceString(msg.Content.ContentStr),
"content": msg.Content,
}
Comment thread
Pratham-Mishra04 marked this conversation as resolved.
if msg.AssistantMessage != nil && msg.AssistantMessage.ToolCalls != nil {
assistantMessage["tool_calls"] = *msg.AssistantMessage.ToolCalls
Expand Down
9 changes: 0 additions & 9 deletions core/providers/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,15 +338,6 @@ func StrPtr(s string) *string {
return &s
}

// coalesceString returns the string value of a pointer to a string, or an empty string if the pointer is nil.
// This is a helper function for safely handling pointer-to-string values.
func coalesceString(s *string) string {
if s == nil {
return ""
}
return *s
}

//* IMAGE UTILS *//

// SanitizeImageURL sanitizes and validates an image URL.
Expand Down