migration test fixes - #7038
Merged
Merged
migration test fixes#7038
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe migration test script adds v2.1.0 fixture generation for schema-dependent columns and Virtual MCP records. PostgreSQL and SQLite paths invoke the new fixture function after v2.0.0 fixtures. ChangesMigration fixture generation
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
akshaydeo
marked this pull request as ready for review
September 9, 2026 15:26
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds v2.1.0 migration test fixtures to the migration test script, ensuring that schema changes introduced in v2.1.0 are validated when running migration tests against older releases.
Changes
append_v210_fixturesfunction that probes for and applies column-level UPDATEs for new columns introduced in v2.1.0 across tables includingconfig_client,config_keys,config_mcp_clients,config_providers,governance_model_pricing,governance_virtual_keys,logs, andmcp_tool_logs.enterprise_mcp_tool_groupsandenterprise_mcp_tool_group_virtual_keysto cover the Virtual MCP table structure preserved from the enterprise tool-group era.append_v210_fixturesinto both the PostgreSQL and SQLite branches ofappend_dynamic_mcp_clients_insert, following the same probing pattern used byappend_v200_fixturesso the fixture set degrades gracefully against older schema versions.Type of change
Affected areas
How to test
Run the migration test workflow locally or via CI. The new fixtures will be applied automatically during the migration test run for both PostgreSQL and SQLite database types.
Verify that the migration tests pass against both the current release and older releases without errors related to missing columns in the v2.1.0 schema.
Screenshots/Recordings
N/A
Breaking changes
Related issues
N/A
Security considerations
No security implications. Fixture values use test-scoped identifiers and no real secrets or PII.
Checklist
docs/contributing/README.mdand followed the guidelines