fix(test): move misplaced budget override validity anchor tests to correct describe block

[impoiler]

Summary

A test for calendar-aligned budget override validity was accidentally nested inside an unrelated it block in the budgetSignature without ids describe block, causing it to never actually run. This PR moves the test to the correct location within the budget overrides describe block.

Changes

• Removed the misplaced it("anchors calendar-aligned validity to the current period boundary", ...) block that was nested inside the budgetSignature without ids test, where it would never execute
• Added the same test cases correctly at the top level of the budget overrides describe block, where they are properly registered and run

Type of change

• Bug fix

Affected areas

• UI (React)

How to test

cd ui
pnpm i || npm i
pnpm test || npm test

The previously dormant test cases for getBudgetOverrideValidUntil with monthly, weekly, daily, and yearly reset durations should now execute and pass.

Breaking changes

• No

Related issues

Security considerations

None.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 02fe09ca-f06c-4c94-96ab-415136b5fb54

📥 Commits

Reviewing files that changed from the base of the PR and between 0f8eea3 and f13571c.

📒 Files selected for processing (1)

• ui/lib/utils/governance.test.ts

---

📝 Walkthrough

Summary by CodeRabbit

• Tests
  • Added coverage for calendar-aligned budget override validity across monthly, weekly, daily, and yearly schedules.
  • Reorganized related test cases without changing application behavior.

Walkthrough

The change adds test coverage for calendar-aligned budget override validity. The tests verify that monthly, weekly, daily, and yearly schedules anchor validity to the next period boundary.

Changes

Budget override validation

Layer / File(s)	Summary
Calendar boundary validity tests ui/lib/utils/governance.test.ts	Adds assertions for monthly, weekly, daily, and yearly reset durations. The existing test block was relocated without changing its assertions or behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: akshaydeo, danpiths

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the test fix and the move of misplaced budget override validity tests.
Description check	✅ Passed	The description explains the problem, changes, testing steps, affected area, and breaking-change status; optional sections are adequately addressed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 08-11-fix_fix_governance.test.ts_file

---

_{Comment @coderabbitai help to get the list of available commands.}

[impoiler]

• fix: update custom pricing docs URL #6052
• test: add needs_session_stickiness to MCP client e2e collection #6049
• fix(test): move misplaced budget override validity anchor tests to correct describe block #6048 👈 (View in Graphite)
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[akshaydeo]

Merge activity

• Aug 11, 8:40 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Aug 11, 8:40 AM UTC: @akshaydeo merged this pull request with Graphite.