server: export ObserveWarmupRoutingEmbedding for enterprise

[kohlivrinda]

Summary

observeWarmupRoutingEmbedding was unexported, making it unreachable from embedder packages that reimplement Bootstrap rather than delegating to it. Those embedders could not wire the warmup embedding usage observer, causing warmup embed token usage to be silently dropped with no recovery path.

Changes

• Exported observeWarmupRoutingEmbedding → ObserveWarmupRoutingEmbedding so embedders in external packages can reference it directly through the embedded server when setting up their own Bootstrap logic.
• Updated both call sites (Bootstrap and ReloadPlugin) to reference the exported name.
• Expanded the method comment to explain why it is exported and the consequence of missing this wiring.

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

Verify that an embedder package that embeds BifrostHTTPServer and calls SetWarmupEmbedUsageObserver with s.ObserveWarmupRoutingEmbedding compiles successfully, and that warmup embedding token usage is recorded in Prometheus routing overhead counters after a governance plugin reload or server bootstrap.

go test ./...

Breaking changes

• Yes
• No

Related issues

Security considerations

None. This is a visibility change on an internal telemetry observer; no auth, secrets, or PII are involved.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f63e0eb8-2131-4072-998c-1ee7bed6d846

📥 Commits

Reviewing files that changed from the base of the PR and between f5ea618 and 8e397a9.

📒 Files selected for processing (1)

• transports/bifrost-http/server/server.go

🚧 Files skipped from review as they are similar to previous changes (1)

• transports/bifrost-http/server/server.go

---

📝 Walkthrough

Summary by CodeRabbit

• Refactor

  • Improved consistency in warmup embedding monitoring across supported integrations.
  • Existing monitoring behavior, results, and operational workflows remain unchanged.
  • No user-facing functionality, configuration, or performance changes are expected from this maintenance update.

• Documentation

  • Added guidance for custom bootstrap integrations to preserve warmup monitoring behavior.
  • Custom integrations replacing the default bootstrap process can explicitly connect the warmup monitoring callback.

Walkthrough

The warmup embedding observer is exported as ObserveWarmupRoutingEmbedding. Plugin reload and bootstrap wiring use the exported callback. Observer behavior remains unchanged.

Changes

Warmup embedding observer

Layer / File(s)	Summary
Export observer and update callbacks transports/bifrost-http/server/server.go	The observer method is exported and documented. Plugin reload and bootstrap wiring pass the exported callback. Its parameters and behavior remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to 8e397

This localized visibility change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Possibly related PRs

• maximhq/bifrost#5686: Adds the warmup embedding observer wiring that this PR exposes for bootstrap and plugin reload.

Suggested reviewers: akshaydeo, pratham-mishra04

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the server change: exporting ObserveWarmupRoutingEmbedding for external enterprise embedders.
Description check	✅ Passed	The description follows the template and explains the purpose, changes, affected areas, testing, breaking changes, and security impact.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 08-03-server_export_observewarmuproutingembedding_for_enterprise

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kohlivrinda]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• semantic router: incremental embedding + embed usage accounting #5896 : 2 dependent PRs (#5901 , #5924 )
• semantic router ui revamp #5865
• move complexity exemplars to configstore with backfill migration #5842
• feat(complexity): harness-aware complexity input extraction for cc and codex #5810
• server: export ObserveWarmupRoutingEmbedding for enterprise #5791 👈 (View in Graphite)
• weaviate + redis adapter fixes #5790
• semantic routing ui #5743
• semantic router: dimension probe + message history window #5748
• semantic cache: min similarity + fallback logging #5742
• smenatic router: budgeting+telemetry management #5686
• semantic routing #5: added semantic classifier for complexity router + handlers changes #5680
• semantic router #3: embedding executor #5656
• semantic router #2: semantic routing config #5655
• semantic router #1: add chromem backend #5628
• complexity : reducing keyword lists from 4 -> 3 lists #5602
• helm and docs changes #5530
• update complexity boundaries #5529
• expose tier/mechanism on every surface #5499
• structured logging #5497
• complexity tier merge #5494
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.