fix: vllm stream truncation - #5585
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe vLLM transcription provider now passes a nil payload when reporting an unexpectedly truncated SSE stream without a terminal marker. ChangesvLLM transcription stream
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
sammaji
marked this pull request as ready for review
July 27, 2026 13:05
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
akshaydeo
approved these changes
Jul 27, 2026
Contributor
Merge activity
|
akhsaul
pushed a commit
to akhsaul/bifrost
that referenced
this pull request
Aug 27, 2026
## Summary Fixes an issue in the vLLM provider's `TranscriptionStream` where a non-nil byte buffer was being passed to `SendStreamTruncatedError` when a stream is detected as truncated. Passing `nil` instead ensures consistent behavior and avoids potentially sending stale or partial buffer contents as part of the truncation error. ## Changes - In the truncation detection path of `TranscriptionStream`, the `body.Bytes()` argument passed to `SendStreamTruncatedError` is replaced with `nil`, aligning with the intended contract for that error path. ## Type of change - [x] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [x] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test Trigger a transcription stream request against a vLLM backend that terminates without sending `[DONE]` and verify that the truncation error is surfaced correctly without any partial body data being included. ```sh go test ./core/providers/vllm/... ``` ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations No security implications. The change removes the forwarding of potentially partial response body bytes in an error path, which reduces the risk of leaking incomplete data. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
occcat
pushed a commit
to occcat/bifrost
that referenced
this pull request
Sep 2, 2026
## Summary Fixes an issue in the vLLM provider's `TranscriptionStream` where a non-nil byte buffer was being passed to `SendStreamTruncatedError` when a stream is detected as truncated. Passing `nil` instead ensures consistent behavior and avoids potentially sending stale or partial buffer contents as part of the truncation error. ## Changes - In the truncation detection path of `TranscriptionStream`, the `body.Bytes()` argument passed to `SendStreamTruncatedError` is replaced with `nil`, aligning with the intended contract for that error path. ## Type of change - [x] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [x] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test Trigger a transcription stream request against a vLLM backend that terminates without sending `[DONE]` and verify that the truncation error is surfaced correctly without any partial body data being included. ```sh go test ./core/providers/vllm/... ``` ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations No security implications. The change removes the forwarding of potentially partial response body bytes in an error path, which reduces the risk of leaking incomplete data. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue in the vLLM provider's
TranscriptionStreamwhere a non-nil byte buffer was being passed toSendStreamTruncatedErrorwhen a stream is detected as truncated. Passingnilinstead ensures consistent behavior and avoids potentially sending stale or partial buffer contents as part of the truncation error.Changes
TranscriptionStream, thebody.Bytes()argument passed toSendStreamTruncatedErroris replaced withnil, aligning with the intended contract for that error path.Type of change
Affected areas
How to test
Trigger a transcription stream request against a vLLM backend that terminates without sending
[DONE]and verify that the truncation error is surfaced correctly without any partial body data being included.go test ./core/providers/vllm/...Breaking changes
Related issues
Security considerations
No security implications. The change removes the forwarding of potentially partial response body bytes in an error path, which reduces the risk of leaking incomplete data.
Checklist
docs/contributing/README.mdand followed the guidelines