Skip to content

chore: remove WEBHOOK_EVENT_COLORS and sort events in webhook badges - #5400

Merged
Pratham-Mishra04 merged 1 commit into
devfrom
07-21-fix_sort_webhook_events_and_drop_event_badge_colors
Jul 21, 2026
Merged

chore: remove WEBHOOK_EVENT_COLORS and sort events in webhook badges#5400
Pratham-Mishra04 merged 1 commit into
devfrom
07-21-fix_sort_webhook_events_and_drop_event_badge_colors

Conversation

@Pratham-Mishra04

Copy link
Copy Markdown
Collaborator

Summary

Removes color-coded styling from webhook event badges and replaces it with a uniform unstyled appearance. Previously, event badges used green/red tints to mirror delivery outcome colors, but this coupling was misleading and unnecessary.

Changes

  • Removed the WEBHOOK_EVENT_COLORS constant and its usage across the webhook details sheet and webhooks list view — event badges now render without background color tints
  • Events in the webhooks list view are now sorted alphabetically before rendering for consistent display order

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Navigate to the Webhooks section of the workspace and verify:

  1. Event badges on the webhook list view appear without green/red background tints and are sorted alphabetically
  2. Event badges in the webhook details sheet (both the endpoint info section and the delivery history table) appear without color tints
cd ui
pnpm i || npm i
pnpm build || npm run build

Screenshots/Recordings

Before: Event badges were tinted green (bg-green-100 text-green-800) or red (bg-red-100 text-red-800) based on event type.

After: All event badges render with a plain outline style regardless of event type.

Breaking changes

  • No

Related issues

Security considerations

None.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Pratham-Mishra04 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 77cac774-c73e-43f8-ae0a-ce28a7186fdd

📥 Commits

Reviewing files that changed from the base of the PR and between cff19eb and d3debf4.

📒 Files selected for processing (3)
  • ui/app/workspace/webhooks/views/webhookDetailsSheet.tsx
  • ui/app/workspace/webhooks/views/webhooksView.tsx
  • ui/lib/types/webhooks.ts
📝 Walkthrough

Walkthrough

Webhook types now provide delivery tuning defaults and no longer export event badge colors. Webhook views render event badges without dynamic colors, while the main table sorts endpoint events before display.

Changes

Webhook UI and type updates

Layer / File(s) Summary
Webhook type exports
ui/lib/types/webhooks.ts
Removes WEBHOOK_EVENT_COLORS and adds WEBHOOK_TUNING_DEFAULTS with delivery tuning values.
Webhook event badge rendering
ui/app/workspace/webhooks/views/webhookDetailsSheet.tsx, ui/app/workspace/webhooks/views/webhooksView.tsx
Removes event-specific badge colors from detail and table views, and sorts table events before rendering.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • maximhq/bifrost#5264: Updates webhook management UI event badge rendering and removes usage of WEBHOOK_EVENT_COLORS.

Suggested reviewers: akshaydeo, danpiths

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: removing webhook badge colors and sorting events.
Description check ✅ Passed The description covers the required sections, including summary, changes, testing, screenshots, breaking changes, and security.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 07-21-fix_sort_webhook_events_and_drop_event_badge_colors

Comment @coderabbitai help to get the list of available commands.

@Pratham-Mishra04
Pratham-Mishra04 force-pushed the 07-21-fix_sort_webhook_events_and_drop_event_badge_colors branch from bc053d0 to cff19eb Compare July 21, 2026 04:35
@Pratham-Mishra04
Pratham-Mishra04 force-pushed the 07-21-docs_document_webhook_error_error_omitted_payload_fields branch from 3099b9c to 16c59ee Compare July 21, 2026 04:35
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 21, 2026
@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
ui/app/workspace/webhooks/views/webhookDetailsSheet.tsx Removes event-specific colors from endpoint and delivery event badges.
ui/app/workspace/webhooks/views/webhooksView.tsx Uses plain event badges and sorts a copied events array before rendering.
ui/lib/types/webhooks.ts Removes the unused webhook event color mapping.

Reviews (2): Last reviewed commit: "fix: sort webhook events and drop event ..." | Re-trigger Greptile

Pratham-Mishra04 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jul 21, 4:44 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 21, 4:50 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 21, 4:51 AM UTC: @Pratham-Mishra04 merged this pull request with Graphite.

@Pratham-Mishra04
Pratham-Mishra04 changed the base branch from 07-21-docs_document_webhook_error_error_omitted_payload_fields to graphite-base/5400 July 21, 2026 04:46
@Pratham-Mishra04
Pratham-Mishra04 changed the base branch from graphite-base/5400 to dev July 21, 2026 04:49
@Pratham-Mishra04
Pratham-Mishra04 dismissed coderabbitai[bot]’s stale review July 21, 2026 04:49

The base branch was changed.

@Pratham-Mishra04
Pratham-Mishra04 requested a review from a team as a code owner July 21, 2026 04:49
@Pratham-Mishra04
Pratham-Mishra04 force-pushed the 07-21-fix_sort_webhook_events_and_drop_event_badge_colors branch from cff19eb to d3debf4 Compare July 21, 2026 04:49
@Pratham-Mishra04
Pratham-Mishra04 merged commit 34541a0 into dev Jul 21, 2026
14 of 16 checks passed
@Pratham-Mishra04
Pratham-Mishra04 deleted the 07-21-fix_sort_webhook_events_and_drop_event_badge_colors branch July 21, 2026 04:51
akhsaul pushed a commit to akhsaul/bifrost that referenced this pull request Aug 27, 2026
maximhq#5400)

## Summary

Removes color-coded styling from webhook event badges and replaces it with a uniform unstyled appearance. Previously, event badges used green/red tints to mirror delivery outcome colors, but this coupling was misleading and unnecessary.

## Changes

- Removed the `WEBHOOK_EVENT_COLORS` constant and its usage across the webhook details sheet and webhooks list view — event badges now render without background color tints
- Events in the webhooks list view are now sorted alphabetically before rendering for consistent display order

## Type of change

- [ ] Bug fix
- [ ] Feature
- [x] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

Navigate to the Webhooks section of the workspace and verify:
1. Event badges on the webhook list view appear without green/red background tints and are sorted alphabetically
2. Event badges in the webhook details sheet (both the endpoint info section and the delivery history table) appear without color tints

```sh
cd ui
pnpm i || npm i
pnpm build || npm run build
```

## Screenshots/Recordings

Before: Event badges were tinted green (`bg-green-100 text-green-800`) or red (`bg-red-100 text-red-800`) based on event type.

After: All event badges render with a plain outline style regardless of event type.

## Breaking changes

- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
occcat pushed a commit to occcat/bifrost that referenced this pull request Sep 2, 2026
maximhq#5400)

## Summary

Removes color-coded styling from webhook event badges and replaces it with a uniform unstyled appearance. Previously, event badges used green/red tints to mirror delivery outcome colors, but this coupling was misleading and unnecessary.

## Changes

- Removed the `WEBHOOK_EVENT_COLORS` constant and its usage across the webhook details sheet and webhooks list view — event badges now render without background color tints
- Events in the webhooks list view are now sorted alphabetically before rendering for consistent display order

## Type of change

- [ ] Bug fix
- [ ] Feature
- [x] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

Navigate to the Webhooks section of the workspace and verify:
1. Event badges on the webhook list view appear without green/red background tints and are sorted alphabetically
2. Event badges in the webhook details sheet (both the endpoint info section and the delivery history table) appear without color tints

```sh
cd ui
pnpm i || npm i
pnpm build || npm run build
```

## Screenshots/Recordings

Before: Event badges were tinted green (`bg-green-100 text-green-800`) or red (`bg-red-100 text-red-800`) based on event type.

After: All event badges render with a plain outline style regardless of event type.

## Breaking changes

- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants