chore: remove WEBHOOK_EVENT_COLORS and sort events in webhook badges - #5400
Conversation
|
|
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughWebhook types now provide delivery tuning defaults and no longer export event badge colors. Webhook views render event badges without dynamic colors, while the main table sorts endpoint events before display. ChangesWebhook UI and type updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bc053d0 to
cff19eb
Compare
3099b9c to
16c59ee
Compare
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix: sort webhook events and drop event ..." | Re-trigger Greptile |
Merge activity
|
The base branch was changed.
cff19eb to
d3debf4
Compare
maximhq#5400) ## Summary Removes color-coded styling from webhook event badges and replaces it with a uniform unstyled appearance. Previously, event badges used green/red tints to mirror delivery outcome colors, but this coupling was misleading and unnecessary. ## Changes - Removed the `WEBHOOK_EVENT_COLORS` constant and its usage across the webhook details sheet and webhooks list view — event badges now render without background color tints - Events in the webhooks list view are now sorted alphabetically before rendering for consistent display order ## Type of change - [ ] Bug fix - [ ] Feature - [x] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test Navigate to the Webhooks section of the workspace and verify: 1. Event badges on the webhook list view appear without green/red background tints and are sorted alphabetically 2. Event badges in the webhook details sheet (both the endpoint info section and the delivery history table) appear without color tints ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` ## Screenshots/Recordings Before: Event badges were tinted green (`bg-green-100 text-green-800`) or red (`bg-red-100 text-red-800`) based on event type. After: All event badges render with a plain outline style regardless of event type. ## Breaking changes - [x] No ## Related issues ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
maximhq#5400) ## Summary Removes color-coded styling from webhook event badges and replaces it with a uniform unstyled appearance. Previously, event badges used green/red tints to mirror delivery outcome colors, but this coupling was misleading and unnecessary. ## Changes - Removed the `WEBHOOK_EVENT_COLORS` constant and its usage across the webhook details sheet and webhooks list view — event badges now render without background color tints - Events in the webhooks list view are now sorted alphabetically before rendering for consistent display order ## Type of change - [ ] Bug fix - [ ] Feature - [x] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test Navigate to the Webhooks section of the workspace and verify: 1. Event badges on the webhook list view appear without green/red background tints and are sorted alphabetically 2. Event badges in the webhook details sheet (both the endpoint info section and the delivery history table) appear without color tints ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` ## Screenshots/Recordings Before: Event badges were tinted green (`bg-green-100 text-green-800`) or red (`bg-red-100 text-red-800`) based on event type. After: All event badges render with a plain outline style regardless of event type. ## Breaking changes - [x] No ## Related issues ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable

Summary
Removes color-coded styling from webhook event badges and replaces it with a uniform unstyled appearance. Previously, event badges used green/red tints to mirror delivery outcome colors, but this coupling was misleading and unnecessary.
Changes
WEBHOOK_EVENT_COLORSconstant and its usage across the webhook details sheet and webhooks list view — event badges now render without background color tintsType of change
Affected areas
How to test
Navigate to the Webhooks section of the workspace and verify:
Screenshots/Recordings
Before: Event badges were tinted green (
bg-green-100 text-green-800) or red (bg-red-100 text-red-800) based on event type.After: All event badges render with a plain outline style regardless of event type.
Breaking changes
Related issues
Security considerations
None.
Checklist
docs/contributing/README.mdand followed the guidelines