Skip to content

feat: filter out empty API keys and improve tool call handling#53

Closed
Pratham-Mishra04 wants to merge 1 commit intofeature/06-03-reconcile-message-type-across-bifrostfrom
06-03-feat_tool_call_results_support_added
Closed

feat: filter out empty API keys and improve tool call handling#53
Pratham-Mishra04 wants to merge 1 commit intofeature/06-03-reconcile-message-type-across-bifrostfrom
06-03-feat_tool_call_results_support_added

Conversation

@Pratham-Mishra04
Copy link
Copy Markdown
Collaborator

Add support for tool call results in Anthropic and Bedrock providers

This PR enhances the handling of tool call results in the Anthropic and Bedrock providers, enabling proper communication with AI models when tools are used. Key changes include:

  • Added proper handling of ToolCallResultID in message processing for Anthropic and Bedrock providers
  • Renamed ToolCallID to ToolCallResultID in the Message schema for consistency
  • Implemented special handling for sequential tool messages, merging them appropriately
  • Added helper function getRoleFromMessage to extract and validate message roles
  • Enhanced image content handling in tool call results
  • Added validation to filter out keys with empty values in SelectKeyFromProviderForModel
  • Updated test configurations to enable tool call testing for OpenAI and Vertex providers

These changes ensure that tool call results are properly formatted according to each provider's API requirements, improving the reliability of tool-based interactions across different AI models.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Collaborator Author

Pratham-Mishra04 commented Jun 3, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@danpiths danpiths changed the base branch from main to graphite-base/53 June 3, 2025 16:18
@danpiths danpiths force-pushed the 06-03-feat_tool_call_results_support_added branch from f8fc7ee to b4ca635 Compare June 3, 2025 16:18
@danpiths danpiths changed the base branch from graphite-base/53 to feature/06-03-reconcile-message-type-across-bifrost June 3, 2025 16:18
@danpiths danpiths requested a review from Tushkiz June 3, 2025 16:18
@danpiths danpiths force-pushed the 06-03-feat_tool_call_results_support_added branch from b4ca635 to 5c3464c Compare June 3, 2025 16:27
@Pratham-Mishra04 Pratham-Mishra04 deleted the 06-03-feat_tool_call_results_support_added branch June 4, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant