Skip to content

Revert "add support for clickhouse for enterprise logstore tables" - #5225

Merged
akshaydeo merged 1 commit into
devfrom
revert-5182-07-14-add_support_for_clickhouse_for_enterprise_logstore_tables
Jul 15, 2026
Merged

Revert "add support for clickhouse for enterprise logstore tables"#5225
akshaydeo merged 1 commit into
devfrom
revert-5182-07-14-add_support_for_clickhouse_for_enterprise_logstore_tables

Conversation

@akshaydeo

Copy link
Copy Markdown
Contributor

Reverts #5182

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 22 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d7a1e09-465d-4d62-9e1f-a4709b553c46

📥 Commits

Reviewing files that changed from the base of the PR and between 91558a5 and b4ed01d.

📒 Files selected for processing (2)
  • framework/logstore/clickhouseextension.go
  • framework/logstore/clickhousestore_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-5182-07-14-add_support_for_clickhouse_for_enterprise_logstore_tables

Comment @coderabbitai help to get the list of available commands.

@akshaydeo
akshaydeo merged commit dd5df2b into dev Jul 15, 2026
10 of 13 checks passed
@akshaydeo
akshaydeo deleted the revert-5182-07-14-add_support_for_clickhouse_for_enterprise_logstore_tables branch July 15, 2026 05:07
@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

Enterprise modules using the removed ClickHouse extension API can no longer build.

  • The revert removes exported types and methods without a compatibility path.
  • Existing consumers receive undefined-symbol compilation errors.
  • No replacement remains for creating and reconciling enterprise ClickHouse tables.

framework/logstore/clickhouseextension.go

Important Files Changed

Filename Overview
framework/logstore/clickhouseextension.go Deletes the exported API used to create and reconcile extension-owned ClickHouse tables.
framework/logstore/clickhousestore_test.go Removes tests for extension-table creation, hybrid delegation, and option validation.

Comments Outside Diff (1)

  1. framework/logstore/clickhouseextension.go

    P1 Enterprise ClickHouse API Removed

    Any enterprise module that adopted ClickHouseExtensionTableOptions or EnsureClickHouseTable now fails to compile because this revert removes the exported type and methods without a replacement. This also removes the only exported path that created and reconciled extension-owned ClickHouse tables, so affected enterprise builds cannot initialize those tables.

    Context Used: Review Bifrost PRs for correctness, regressions, c... (source)

Reviews (1): Last reviewed commit: "Revert "add support for clickhouse for e..." | Re-trigger Greptile

akshaydeo added a commit that referenced this pull request Jul 18, 2026
…ce (#5150)

* add support for clickhouse for enterprise logstore tables

* Revert "add support for clickhouse for enterprise logstore tables" (#5225)

* Delete 1

Signed-off-by: Akshay Deo <akshay@akshaydeo.com>

* fix: complete visible thinking items on the streaming Responses surface

---------

Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
Co-authored-by: Sahil Choudhary <sahil.codes.it@gmail.com>
Co-authored-by: Akshay Deo <akshay@akshaydeo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants