feat: add BedrockMantleSection UI component and project_id override for Bedrock deployments - #5142
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe deployment overrides UI adds Project ID support for Bedrock, introduces Region and Project ID overrides for Bedrock Mantle, and dispatches the ChangesBedrock Mantle override support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
impoiler
changed the title
BedrockMantleSection UI component and project_id override for Bedrock deployments
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (5): Last reviewed commit: "feat: per model bedrock overrides suppor..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
abde3bd to
eeeb22d
Compare
9d73c45 to
59f61b6
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/app/workspace/providers/fragments/deploymentsTable.tsx`:
- Around line 235-242: Add stable, unique data-testid attributes for the new
Bedrock deployment inputs around the SecretVarField controls, since
SecretVarField does not forward extra props. Use deployment-bedrock-region-input
for the region control and deployment-bedrock-project-input for the project_id
control, preserving their existing behavior and values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 17ea25b1-b518-4d21-9f63-3b8447f1d99a
📒 Files selected for processing (3)
ui/app/workspace/providers/fragments/deploymentsTable.tsxui/lib/types/config.tsui/lib/types/schemas.ts
eeeb22d to
3c0e2be
Compare
59f61b6 to
6ac4e59
Compare
3c0e2be to
4d1d2a8
Compare
6ac4e59 to
67d0f5c
Compare
Merge activity
|
The base branch was changed.
67d0f5c to
93339cf
Compare
…de for Bedrock deployments (#5142) ## Summary Adds UI support for a new `bedrock_mantle` provider type, including a dedicated configuration section with region and project ID overrides. Also clarifies that `project_id` is a shared per-alias field used across Vertex, Bedrock, and Bedrock Mantle providers, and adds a `project_id` field to the existing Bedrock section. ## Changes - Added a `BedrockMantleSection` component that renders region and project ID override fields for `bedrock_mantle` deployments, mirroring the pattern used by other provider sections. - Added a `project_id` field to the existing `BedrockSection` so Bedrock deployments can scope calls to a specific project via the `OpenAI-Project` header. - Wired `bedrock_mantle` into the `ProviderSection` switch so the new section renders correctly. - Updated comments in `config.ts` and `schemas.ts` to clarify that `project_id` is a shared top-level alias field used by Vertex, Bedrock, and Bedrock Mantle, avoiding confusion about its scope. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [x] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test 1. Navigate to a workspace provider deployment configuration in the UI. 2. Select `bedrock_mantle` as the provider type and confirm the **Bedrock Mantle overrides** section appears with **Region** and **Project ID** fields. 3. Select `bedrock` as the provider type and confirm the **Project ID** field appears alongside the existing fields. 4. Enter values (including `env.VAR` references) and verify they are saved and restored correctly. ```sh cd ui pnpm i || npm i pnpm test || npm test pnpm build || npm run build ``` ## Screenshots/Recordings _Add before/after screenshots of the Bedrock and Bedrock Mantle deployment configuration panels._ ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations Project ID and region values are handled via `SecretVarField`, consistent with how other sensitive deployment configuration fields are managed. No new secret storage mechanisms are introduced. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
2 participants
Summary
Adds UI support for a new
bedrock_mantleprovider type, including a dedicated configuration section with region and project ID overrides. Also clarifies thatproject_idis a shared per-alias field used across Vertex, Bedrock, and Bedrock Mantle providers, and adds aproject_idfield to the existing Bedrock section.Changes
BedrockMantleSectioncomponent that renders region and project ID override fields forbedrock_mantledeployments, mirroring the pattern used by other provider sections.project_idfield to the existingBedrockSectionso Bedrock deployments can scope calls to a specific project via theOpenAI-Projectheader.bedrock_mantleinto theProviderSectionswitch so the new section renders correctly.config.tsandschemas.tsto clarify thatproject_idis a shared top-level alias field used by Vertex, Bedrock, and Bedrock Mantle, avoiding confusion about its scope.Type of change
Affected areas
How to test
bedrock_mantleas the provider type and confirm the Bedrock Mantle overrides section appears with Region and Project ID fields.bedrockas the provider type and confirm the Project ID field appears alongside the existing fields.env.VARreferences) and verify they are saved and restored correctly.Screenshots/Recordings
Add before/after screenshots of the Bedrock and Bedrock Mantle deployment configuration panels.
Breaking changes
Related issues
Security considerations
Project ID and region values are handled via
SecretVarField, consistent with how other sensitive deployment configuration fields are managed. No new secret storage mechanisms are introduced.Checklist
docs/contributing/README.mdand followed the guidelines