mod fixes - #5127
Conversation
📝 WalkthroughWalkthroughCodex tool-item unmarshalling now normalizes and exposes ChangesCodex tool argument preservation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "mod fixes" | Re-trigger Greptile |
## Summary Removes an unintended raw byte capture for `tool_search_call` messages during JSON unmarshalling, preventing the raw payload from being stored redundantly in `rawToolSearch` while still preserving the `arguments` field for downstream consumers. ## Changes - Removed the `m.rawToolSearch = append([]byte(nil), data...)` assignment inside the `isRawPreservedItem` branch of `UnmarshalJSON`. The comment clarifying that `MarshalJSON` re-emits preserved bytes verbatim is retained, as the round-trip behavior is unchanged. - Bumped `github.com/maximhq/bifrost/core` from `v1.6.3` to `v1.7.0` across the test seed modules. ## Type of change - [x] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [x] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test ```sh go test ./core/schemas/... ``` Verify that `tool_search_call` messages round-trip correctly through `UnmarshalJSON` → `MarshalJSON` and that the `Arguments` field remains accessible to downstream consumers after unmarshalling. ## Screenshots/Recordings N/A ## Breaking changes - [ ] Yes - [x] No ## Related issues N/A ## Security considerations No security implications. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable

Summary
Removes an unintended raw byte capture for
tool_search_callmessages during JSON unmarshalling, preventing the raw payload from being stored redundantly inrawToolSearchwhile still preserving theargumentsfield for downstream consumers.Changes
m.rawToolSearch = append([]byte(nil), data...)assignment inside theisRawPreservedItembranch ofUnmarshalJSON. The comment clarifying thatMarshalJSONre-emits preserved bytes verbatim is retained, as the round-trip behavior is unchanged.github.com/maximhq/bifrost/corefromv1.6.3tov1.7.0across the test seed modules.Type of change
Affected areas
How to test
go test ./core/schemas/...Verify that
tool_search_callmessages round-trip correctly throughUnmarshalJSON→MarshalJSONand that theArgumentsfield remains accessible to downstream consumers after unmarshalling.Screenshots/Recordings
N/A
Breaking changes
Related issues
N/A
Security considerations
No security implications.
Checklist
docs/contributing/README.mdand followed the guidelines