Skip to content

mod updates - #4980

Merged
akshaydeo merged 1 commit into
v2.0.0from
07-06-mod_updates
Jul 7, 2026
Merged

mod updates#4980
akshaydeo merged 1 commit into
v2.0.0from
07-06-mod_updates

Conversation

@akshaydeo

Copy link
Copy Markdown
Contributor

Summary

Briefly explain the purpose of this PR and the problem it solves.

Changes

  • What was changed and why
  • Any notable design decisions or trade-offs

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Describe the steps to validate this change. Include commands and expected outcomes.

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

If adding new configs or environment variables, document them here.

Screenshots/Recordings

If UI changes, add before/after screenshots or short clips.

Breaking changes

  • Yes
  • No

If yes, describe impact and migration instructions.

Related issues

Link related issues and discussions. Example: Closes #123

Security considerations

Note any security implications (auth, secrets, PII, sandboxing, etc.).

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This change adds a direct github.com/google/uuid dependency at v1.6.0 in plugins/logging/go.mod.

Changes

Dependency update

Layer / File(s) Summary
Add uuid dependency
plugins/logging/go.mod
Adds github.com/google/uuid at v1.6.0 to the logging plugin module requirements.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related issues: #123 (Files API Support) — not directly addressed by this dependency update.

Suggested labels: dependencies

Suggested reviewers: none required

🚥 Pre-merge checks | ✅ 1 | ❌ 4

❌ Failed checks (3 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The change only adds a uuid dependency and does not implement Files API support or POST /v1/files. Implement file upload API support for the targeted providers, including POST /v1/files and related storage or RAG workflows.
Out of Scope Changes check ⚠️ Warning Adding github.com/google/uuid to go.mod is unrelated to the Files API objective. Remove the dependency-only change unless it directly supports the Files API work, or add the missing feature implementation.
Description check ⚠️ Warning The description is only the template and lacks the required filled-in summary, changes, testing, and impact details. Populate the template with the PR purpose, concrete changes, test steps, affected areas, and any breaking or security notes.
Title check ❓ Inconclusive The title is too vague and does not describe the dependency change in this PR. Rename it to reflect the actual change, such as "Add github.com/google/uuid to plugins/logging".
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 07-06-mod_updates

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@akshaydeo
akshaydeo marked this pull request as ready for review July 6, 2026 23:48

akshaydeo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akshaydeo akshaydeo mentioned this pull request Jul 6, 2026
18 tasks
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 6, 2026
@greptile-apps

greptile-apps Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — the change is a one-line go.mod update that correctly declares an already-used and already-checksummed dependency as direct.

The only change is promoting github.com/google/uuid v1.6.0 to an explicit direct dependency. The package was already in the transitive graph and the go.sum was already correct, so this is a housekeeping fix with no risk to runtime behavior.

No files require special attention.

Important Files Changed

Filename Overview
plugins/logging/go.mod Promotes github.com/google/uuid v1.6.0 from an implicit transitive dependency to an explicit direct require, correctly reflecting that operations.go imports it directly. go.sum already contains the matching checksums.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[plugins/logging module] -->|direct import| B[github.com/google/uuid v1.6.0]
    A -->|direct import| C[github.com/maximhq/bifrost/core v1.6.3]
    A -->|direct import| D[github.com/maximhq/bifrost/framework v1.4.3]
    A -->|direct import| E[github.com/bytedance/sonic v1.15.1]
    B -->|used in| F[operations.go: uuid.NewString]
    note1[go.sum already has uuid checksums from transitive dep graph]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[plugins/logging module] -->|direct import| B[github.com/google/uuid v1.6.0]
    A -->|direct import| C[github.com/maximhq/bifrost/core v1.6.3]
    A -->|direct import| D[github.com/maximhq/bifrost/framework v1.4.3]
    A -->|direct import| E[github.com/bytedance/sonic v1.15.1]
    B -->|used in| F[operations.go: uuid.NewString]
    note1[go.sum already has uuid checksums from transitive dep graph]
Loading

Reviews (3): Last reviewed commit: "mod updates" | Re-trigger Greptile

Comment thread plugins/logging/go.mod
Comment on lines +8 to +9
github.com/maximhq/bifrost/core v1.6.3
github.com/maximhq/bifrost/framework v1.4.3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 go.sum not updated for new dependency versions

go.sum still only contains checksums for core v1.6.2 and framework v1.4.2; there are no entries for the newly required v1.6.3 / v1.4.3. Go's module verification will refuse to build or test this module when the sum database entry is missing — any CI that runs go build ./... or go test ./... inside plugins/logging without -mod=mod will fail with a "missing go.sum entry" error. Running go mod tidy (or go get github.com/maximhq/bifrost/core@v1.6.3 github.com/maximhq/bifrost/framework@v1.4.3) from within plugins/logging/ would regenerate go.sum with the required hashes.

Comment thread plugins/logging/go.mod
Comment on lines +8 to +9
github.com/maximhq/bifrost/core v1.6.3
github.com/maximhq/bifrost/framework v1.4.3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Version bump not applied consistently across sibling plugins

All other plugin modules (compat, governance, jsonparser, maxim, mocker, modelcatalogresolver, otel, prompts, semanticcache, telemetry) still declare core v1.6.2 / framework v1.4.2. If v1.6.3 / v1.4.3 contain correctness or API-compatibility fixes that logging depends on, those same fixes are absent in every other plugin. Was this intentional — i.e., does logging uniquely require these versions — or should all sibling plugins be updated together?

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Is this intentional, or should the version bump be applied to all sibling plugin modules?

@akshaydeo
akshaydeo force-pushed the 07-06-test_case_fixes_for_cancelling_streams branch from 741b716 to c0ef15d Compare July 7, 2026 00:19
@akshaydeo
akshaydeo force-pushed the 07-06-mod_updates branch from 51ece24 to 478124c Compare July 7, 2026 00:19

akshaydeo commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 7, 12:21 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 7, 12:23 AM UTC: @akshaydeo merged this pull request with Graphite.

@akshaydeo
akshaydeo changed the base branch from 07-06-test_case_fixes_for_cancelling_streams to graphite-base/4980 July 7, 2026 00:22
@akshaydeo
akshaydeo changed the base branch from graphite-base/4980 to v2.0.0 July 7, 2026 00:22
@akshaydeo
akshaydeo dismissed coderabbitai[bot]’s stale review July 7, 2026 00:22

The base branch was changed.

@akshaydeo
akshaydeo merged commit 838a493 into v2.0.0 Jul 7, 2026
10 of 12 checks passed
@akshaydeo
akshaydeo deleted the 07-06-mod_updates branch July 7, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants