mod updates - #4980
Conversation
📝 WalkthroughWalkthroughThis change adds a direct ChangesDependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Related issues: Suggested labels: dependencies Suggested reviewers: none required 🚥 Pre-merge checks | ✅ 1 | ❌ 4❌ Failed checks (3 warnings, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| github.com/maximhq/bifrost/core v1.6.3 | ||
| github.com/maximhq/bifrost/framework v1.4.3 |
There was a problem hiding this comment.
go.sum not updated for new dependency versions
go.sum still only contains checksums for core v1.6.2 and framework v1.4.2; there are no entries for the newly required v1.6.3 / v1.4.3. Go's module verification will refuse to build or test this module when the sum database entry is missing — any CI that runs go build ./... or go test ./... inside plugins/logging without -mod=mod will fail with a "missing go.sum entry" error. Running go mod tidy (or go get github.com/maximhq/bifrost/core@v1.6.3 github.com/maximhq/bifrost/framework@v1.4.3) from within plugins/logging/ would regenerate go.sum with the required hashes.
| github.com/maximhq/bifrost/core v1.6.3 | ||
| github.com/maximhq/bifrost/framework v1.4.3 |
There was a problem hiding this comment.
Version bump not applied consistently across sibling plugins
All other plugin modules (compat, governance, jsonparser, maxim, mocker, modelcatalogresolver, otel, prompts, semanticcache, telemetry) still declare core v1.6.2 / framework v1.4.2. If v1.6.3 / v1.4.3 contain correctness or API-compatibility fixes that logging depends on, those same fixes are absent in every other plugin. Was this intentional — i.e., does logging uniquely require these versions — or should all sibling plugins be updated together?
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Is this intentional, or should the version bump be applied to all sibling plugin modules?
741b716 to
c0ef15d
Compare
51ece24 to
478124c
Compare
Merge activity
|
The base branch was changed.

Summary
Briefly explain the purpose of this PR and the problem it solves.
Changes
Type of change
Affected areas
How to test
Describe the steps to validate this change. Include commands and expected outcomes.
If adding new configs or environment variables, document them here.
Screenshots/Recordings
If UI changes, add before/after screenshots or short clips.
Breaking changes
If yes, describe impact and migration instructions.
Related issues
Link related issues and discussions. Example: Closes #123
Security considerations
Note any security implications (auth, secrets, PII, sandboxing, etc.).
Checklist
docs/contributing/README.mdand followed the guidelines