Skip to content

chore: ui build fix - #4933

Merged
akshaydeo merged 1 commit into
devfrom
07-06-chore_ui_build_fix
Jul 6, 2026
Merged

chore: ui build fix#4933
akshaydeo merged 1 commit into
devfrom
07-06-chore_ui_build_fix

Conversation

@TejasGhatte

Copy link
Copy Markdown
Collaborator

Summary

Briefly explain the purpose of this PR and the problem it solves.

Changes

  • What was changed and why
  • Any notable design decisions or trade-offs

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Describe the steps to validate this change. Include commands and expected outcomes.

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

If adding new configs or environment variables, document them here.

Screenshots/Recordings

If UI changes, add before/after screenshots or short clips.

Breaking changes

  • Yes
  • No

If yes, describe impact and migration instructions.

Related issues

Link related issues and discussions. Example: Closes #123

Security considerations

Note any security implications (auth, secrets, PII, sandboxing, etc.).

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


tejas ghatte seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@TejasGhatte
TejasGhatte marked this pull request as ready for review July 6, 2026 06:24
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ea45b2c4-620f-4e7c-a6ae-916891f534de

📥 Commits

Reviewing files that changed from the base of the PR and between 339dd7a and cd389b1.

📒 Files selected for processing (1)
  • ui/lib/types/logs.ts

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added support for showing cancelled counts in MCP histogram buckets.

Walkthrough

Added an optional cancelled?: number field to the MCPHistogramBucket interface in ui/lib/types/logs.ts to represent cancelled counts in MCP histogram bucket data.

Changes

MCP Histogram Type Update

Layer / File(s) Summary
Add cancelled field to type
ui/lib/types/logs.ts
Added optional cancelled?: number property to the MCPHistogramBucket interface.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • maximhq/bifrost#4930: Adds cancelled counts to histogram/model usage aggregation and bucket data, directly aligning with this type addition.

Suggested reviewers: danpiths, akshaydeo

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is still the unfilled template and lacks a real summary, changes, testing, and related issue details. Replace the template with a filled-out summary, change list, testing steps, affected areas, and related issue references.
Linked Issues check ⚠️ Warning The PR does not implement the requested Files API support or the POST /v1/files endpoint. Add file upload support and provider integration for the Files API, including POST /v1/files and the related RAG/fine-tuning use cases.
Out of Scope Changes check ⚠️ Warning The only code change adds a cancelled field to MCPHistogramBucket, which is unrelated to the Files API request. Remove unrelated type changes or align the PR to the Files API scope by implementing file upload support.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed Title is related to the UI change, but it is broader than the actual type update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 07-06-chore_ui_build_fix

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
coderabbitai Bot requested review from akshaydeo and danpiths July 6, 2026 06:25
@greptile-apps

greptile-apps Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The type change is safe to merge and unblocks the build; the mcpVolumeChart.tsx and CSV export gaps are follow-up items that don't affect correctness of the fix itself.

The single-line type addition is correct and non-breaking. Two consumers — the MCP volume chart and the MCP CSV export — were not updated to surface the new field, leaving cancelled executions silently invisible in charts and omitted from exports.

ui/app/workspace/dashboard/components/charts/mcpVolumeChart.tsx and ui/app/workspace/dashboard/utils/exportUtils.ts both need a cancelled series/column to stay consistent with the rest of the dashboard.

Important Files Changed

Filename Overview
ui/lib/types/logs.ts Adds optional cancelled?: number to MCPHistogramBucket — safe, backward-compatible type fix that unblocks the build when the backend starts returning this field.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[MCPHistogramBucket type\ncancelled?: number added] --> B[logsVolumeChart.tsx\nbucket.cancelled ?? 0 ✅]
    A --> C[mcpVolumeChart.tsx\ncancelled Bar/Area missing ⚠️]
    A --> D[exportUtils mcpVolumeToCSV\ncancelled column missing ⚠️]
    A --> E[exportUtils overviewVolumeToCSV\nb.cancelled ?? 0 ✅]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[MCPHistogramBucket type\ncancelled?: number added] --> B[logsVolumeChart.tsx\nbucket.cancelled ?? 0 ✅]
    A --> C[mcpVolumeChart.tsx\ncancelled Bar/Area missing ⚠️]
    A --> D[exportUtils mcpVolumeToCSV\ncancelled column missing ⚠️]
    A --> E[exportUtils overviewVolumeToCSV\nb.cancelled ?? 0 ✅]
Loading

Reviews (1): Last reviewed commit: "chore: ui build fix" | Re-trigger Greptile

akshaydeo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Merge activity

  • Jul 6, 6:28 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 6, 6:29 AM UTC: @akshaydeo merged this pull request with Graphite.

@akshaydeo
akshaydeo merged commit 6731d0b into dev Jul 6, 2026
15 of 16 checks passed
@akshaydeo
akshaydeo deleted the 07-06-chore_ui_build_fix branch July 6, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files API Support

3 participants