docs: update benchmarking docs for new CLI flags, mocker/hitter tools, and revised result schema - #4909
Conversation
|
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughDocumentation for benchmark runs is updated to use a root ChangesBenchmarking documentation update
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4462c49 to
520e833
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/benchmarking/run-your-own-benchmarks.mdx`:
- Around line 357-359: The port check troubleshooting snippet is hardcoded to
8080 and no longer matches the configurable BIFROST_PORT setup. Update the
benchmark verification example in the relevant markdown section to reference the
configured port value instead of a fixed port, so it stays aligned with the
documented environment-based configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 943ee1e3-c5fa-4bcf-9bc6-f80e3f54d90e
📒 Files selected for processing (1)
docs/benchmarking/run-your-own-benchmarks.mdx
Merge activity
|

Summary
Updates the benchmarking documentation to reflect the current CLI interface and feature set of the Bifrost benchmarking tool, including two new companion tools (
mockerandhitter), a revised flag schema, and new benchmark scenarios.Changes
mocker(mock LLM provider) andhitter(load generator) companion tools shipped with the benchmarking repo-portflag with.env-based port configuration (BIFROST_PORT, etc.) and updated all examples accordingly-rateor-usersa required mutually exclusive pair, replacing the old optional-ratewith a default; added a "Rate vs. Users Mode" explanation section-timeout,-cooldown,-model,-host,-path,-suffix,-request-type,-prompt-file,-ramp-up,-ramp-up-duration,-debug-include-provider-in-requestand-endpointflags, which no longer exist1.26.1+to1.24+-request-type embedding,-prompt-file, and the bundled prompt fixture filesdrop_reasons,server_peak_memory_mb,status_code_counts, etc.)-rate/-users, "No process found on port", and attack timeout errorsmockertoolType of change
Affected areas
How to test
Review the rendered documentation to confirm:
-rateor-usersinstead of the removed-portflag.envconfiguration section accurately describes port-based gateway configurationBreaking changes
Related issues
Security considerations
None. Documentation-only change.
Checklist
docs/contributing/README.mdand followed the guidelines