docs: clarify two-layer token refresh behavior and disabled-client refresh token expiry - #4849
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Confidence Score: 5/5Documentation-only change with no code modifications; safe to merge. The prose accurately reflects the implementation: GetExpiringOauthTokens in framework/configstore/rdb.go joins against config_mcp_clients and filters out disabled clients, confirming the background refresh pauses while the client is disabled claim, and GetAccessToken in framework/oauth2/main.go performs the inline refresh described as the on-use layer. The docs.json navigation entry for this page already exists. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "docs: mcp refresh token updates docs" | Re-trigger Greptile |
|
|
730a280 to
ecd3323
Compare
a77ddfd to
95ae623
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates the MCP OAuth documentation to clarify token refresh behavior, describing background proactive refresh and inline on-use refresh, noting that background refresh pauses when the client is disabled, and adding a related troubleshooting note. ChangesOAuth refresh documentation update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Merge activity
|
The base branch was changed.
ecd3323 to
f3b687c
Compare
* upstream/dev: feat(mcp): add per-MCP-server tool execution timeout (maximhq#4472) fix: billing on failed responses stream requests anthropic and bedrock (maximhq#4842) fix: gemini openai through signature compatibility (maximhq#4810) fix: cancelled state in logs (maximhq#4831) fix: perplexity responses api compatibility (maximhq#4813) docs: clarify two-layer token refresh behavior and disabled-client refresh token expiry (maximhq#4849) fix: skip background token refresh for disabled/unconfigured MCP clients and guarantee non-nil logger in sync workers (maximhq#4848)

Summary
Documents the two-layer automatic token refresh behavior in Bifrost's OAuth flow, clarifying how background refresh and on-use refresh work together, and what happens when an MCP client is disabled.
Changes
Type of change
Affected areas
How to test
Review the rendered docs to confirm the updated "Automatic refresh" section and troubleshooting accordion entry are accurate and clearly worded.
Breaking changes
Related issues
Security considerations
None. This is a documentation-only change.
Checklist
docs/contributing/README.mdand followed the guidelines