Skip to content

fix: update audit logs page layout classes and add newline at EOF - #4719

Merged
akshaydeo merged 4 commits into
devfrom
06-26-fix_audit_logs_page_width
Jun 26, 2026
Merged

akshaydeo merged 4 commits into
devfrom
06-26-fix_audit_logs_page_width

Conversation

@impoiler

@impoiler impoiler commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the layout of the Audit Logs page to correctly fill the viewport and apply the appropriate background and border styles.

Changes

  • Replaced h-[calc(100dvh-1rem)] with h-[calc(100vh-16px)] for consistent viewport height calculation
  • Swapped mx-auto flex flex-col p-4 utility classes for no-border-parent bg-background flex to align with the layout conventions used elsewhere in the app
  • Added missing newline at end of file

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Navigate to the Audit Logs page and verify:

  • The page fills the full viewport height without overflow or clipping
  • The background color and border styling match the rest of the workspace layout
cd ui
pnpm i || npm i
pnpm build || npm run build

Screenshots/Recordings

Add before/after screenshots showing the corrected Audit Logs page layout.

Breaking changes

  • Yes
  • No

Related issues

Security considerations

None.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 12eb52b1-1ffa-40fd-b212-027fb9e7b21d

📥 Commits

Reviewing files that changed from the base of the PR and between d478309 and 3ab32b4.

📒 Files selected for processing (1)
  • ui/app/workspace/audit-logs/page.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • ui/app/workspace/audit-logs/page.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Updated the Audit Logs page layout to a full-width, borderless row flex design with refreshed background styling.
    • Adjusted the page’s height/viewport fit for more consistent on-screen presentation while keeping the audit log view visible.

Walkthrough

The audit logs page wrapper styling was updated to use a full-width flex layout and a different viewport height calculation. The AuditLogsView component remains rendered in the same place.

Changes

Audit logs page layout

Layer / File(s) Summary
Page wrapper layout
ui/app/workspace/audit-logs/page.tsx
The outer wrapper around AuditLogsView changes Tailwind classes, including width, background, flex direction, and height calculation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I hop through layouts, light and free,
With bg-background around me.
A wider page, a taller sky,
Yet AuditLogsView still waves hi.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: updating Audit Logs page layout classes and the EOF newline.
Description check ✅ Passed The description follows the template and covers summary, changes, type, affected area, testing, screenshots, breaking changes, issues, security, and checklist.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 06-26-fix_audit_logs_page_width

Comment @coderabbitai help to get the list of available commands.

@impoiler
impoiler force-pushed the 06-26-fix_audit_logs_page_width branch from 5213094 to cf31023 Compare June 26, 2026 08:36
@impoiler
impoiler force-pushed the 06-26-chore_show_tooltip_for_logs_filter_sidebar_for_overflowing_text branch from b1db6a0 to 093f669 Compare June 26, 2026 08:36
@impoiler impoiler changed the title fix: audit logs page width fix: update audit logs page layout classes and add newline at EOF Jun 26, 2026
@impoiler impoiler self-assigned this Jun 26, 2026
@impoiler
impoiler marked this pull request as ready for review June 26, 2026 09:30
@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — the change is a one-line CSS class swap with no logic, data flow, or component structure changes.

The only touched file is a thin page wrapper that passes directly to AuditLogsView. The class changes align with the established full-viewport pattern visible in dashboard, mcp-logs, and logs pages, and no data-testid attributes, state, or API calls are involved.

No files require special attention.

Important Files Changed

Filename Overview
ui/app/workspace/audit-logs/page.tsx Layout wrapper classes updated to match the full-viewport pattern used in dashboard and mcp-logs pages; newline added at EOF. No logic, data, or testid changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[AuditLogsPage wrapper div] -->|before| B["no-padding-parent mx-auto flex h-[calc(100dvh-1rem)] w-full flex-col p-4"]
    A -->|after| C["no-padding-parent no-border-parent bg-background flex h-[calc(100vh-16px)] w-full"]
    C --> D[AuditLogsView]
    B --> D
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[AuditLogsPage wrapper div] -->|before| B["no-padding-parent mx-auto flex h-[calc(100dvh-1rem)] w-full flex-col p-4"]
    A -->|after| C["no-padding-parent no-border-parent bg-background flex h-[calc(100vh-16px)] w-full"]
    C --> D[AuditLogsView]
    B --> D
Loading

Reviews (4): Last reviewed commit: "fix: audit logs page width" | Re-trigger Greptile

Comment thread ui/app/workspace/audit-logs/page.tsx
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 26, 2026
@impoiler
impoiler force-pushed the 06-26-fix_audit_logs_page_width branch from cf31023 to 531106c Compare June 26, 2026 09:37
@impoiler
impoiler force-pushed the 06-26-chore_show_tooltip_for_logs_filter_sidebar_for_overflowing_text branch from 093f669 to 5d2afe1 Compare June 26, 2026 09:37
@impoiler
impoiler force-pushed the 06-26-fix_audit_logs_page_width branch from 531106c to d478309 Compare June 26, 2026 11:33
@impoiler
impoiler force-pushed the 06-26-chore_show_tooltip_for_logs_filter_sidebar_for_overflowing_text branch from 5d2afe1 to 68ab98f Compare June 26, 2026 11:33
@impoiler
impoiler force-pushed the 06-26-chore_show_tooltip_for_logs_filter_sidebar_for_overflowing_text branch from 68ab98f to 53c60fc Compare June 26, 2026 12:23
@impoiler
impoiler force-pushed the 06-26-fix_audit_logs_page_width branch from d478309 to 3ab32b4 Compare June 26, 2026 12:23

akshaydeo commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Merge activity

  • Jun 26, 1:47 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 26, 1:51 PM UTC: @akshaydeo merged this pull request with Graphite.

@akshaydeo
akshaydeo changed the base branch from 06-26-chore_show_tooltip_for_logs_filter_sidebar_for_overflowing_text to graphite-base/4719 June 26, 2026 13:50
@akshaydeo
akshaydeo changed the base branch from graphite-base/4719 to dev June 26, 2026 13:51
@akshaydeo
akshaydeo dismissed coderabbitai[bot]’s stale review June 26, 2026 13:51

The base branch was changed.

@akshaydeo
akshaydeo merged commit eb6a602 into dev Jun 26, 2026
12 checks passed
@akshaydeo
akshaydeo deleted the 06-26-fix_audit_logs_page_width branch June 26, 2026 13:51
akshaydeo pushed a commit that referenced this pull request Jun 30, 2026
)

## Summary

Fixes the layout of the Audit Logs page to correctly fill the viewport and apply the appropriate background and border styles.

## Changes

- Replaced `h-[calc(100dvh-1rem)]` with `h-[calc(100vh-16px)]` for consistent viewport height calculation
- Swapped `mx-auto flex flex-col p-4` utility classes for `no-border-parent bg-background flex` to align with the layout conventions used elsewhere in the app
- Added missing newline at end of file

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

Navigate to the Audit Logs page and verify:
- The page fills the full viewport height without overflow or clipping
- The background color and border styling match the rest of the workspace layout

```sh
cd ui
pnpm i || npm i
pnpm build || npm run build
```

## Screenshots/Recordings

Add before/after screenshots showing the corrected Audit Logs page layout.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
R-droid101 pushed a commit to R-droid101/bifrost that referenced this pull request Jul 1, 2026
…ximhq#4719)

## Summary

Fixes the layout of the Audit Logs page to correctly fill the viewport and apply the appropriate background and border styles.

## Changes

- Replaced `h-[calc(100dvh-1rem)]` with `h-[calc(100vh-16px)]` for consistent viewport height calculation
- Swapped `mx-auto flex flex-col p-4` utility classes for `no-border-parent bg-background flex` to align with the layout conventions used elsewhere in the app
- Added missing newline at end of file

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

Navigate to the Audit Logs page and verify:
- The page fills the full viewport height without overflow or clipping
- The background color and border styling match the rest of the workspace layout

```sh
cd ui
pnpm i || npm i
pnpm build || npm run build
```

## Screenshots/Recordings

Add before/after screenshots showing the corrected Audit Logs page layout.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
akshaydeo pushed a commit that referenced this pull request Jul 1, 2026
)

## Summary

Fixes the layout of the Audit Logs page to correctly fill the viewport and apply the appropriate background and border styles.

## Changes

- Replaced `h-[calc(100dvh-1rem)]` with `h-[calc(100vh-16px)]` for consistent viewport height calculation
- Swapped `mx-auto flex flex-col p-4` utility classes for `no-border-parent bg-background flex` to align with the layout conventions used elsewhere in the app
- Added missing newline at end of file

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

Navigate to the Audit Logs page and verify:
- The page fills the full viewport height without overflow or clipping
- The background color and border styling match the rest of the workspace layout

```sh
cd ui
pnpm i || npm i
pnpm build || npm run build
```

## Screenshots/Recordings

Add before/after screenshots showing the corrected Audit Logs page layout.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants