Enterprise changelog

[akshaydeo]

No description provided.

[coderabbitai]

Warning

Review limit reached

@akshaydeo, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 4 seconds. Learn how PR review limits work.

To continue reviewing without waiting, enable usage-based billing in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 139a9bd4-9c4e-42c5-802d-251985d61a86

📥 Commits

Reviewing files that changed from the base of the PR and between f1fc4b9 and 23a5463.

📒 Files selected for processing (4)

• .github/workflows/scripts/cost-accuracy-test.sh
• .github/workflows/scripts/load-test.sh
• docs/changelogs/ent-v1.4.13.mdx
• docs/docs.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[greptile-apps]

Confidence Score: 3/5

The Go handler and test file changes both need fixes before merging: the test file cannot compile as written, and the handler logic silently bypasses provider filtering for VKs that rely on the database default for IsActive.

Two concrete defects in the changed Go files: new(true) / new(false) are not valid Go expressions and will prevent the test package from building; and the nil-IsActive guard causes active VKs (those with a NULL DB value) to skip provider filtering on list-models, producing a wider model list than the VK configuration allows. The docs and CI script changes are clean.

transports/bifrost-http/handlers/list_models_vk.go and its test file need attention — the nil handling logic and the pointer-literal syntax both require correction.

Important Files Changed

Filename	Overview
transports/bifrost-http/handlers/list_models_vk.go	Adapts IsActive from bool to *bool — but the nil guard causes active VKs with a NULL DB value to bypass provider filtering entirely, which is the opposite of the intended behavior.
transports/bifrost-http/handlers/list_models_vk_test.go	Updates tests for the pointer IsActive field but uses new(true) / new(false) which are not valid Go — new requires a type argument, so the test file will not compile.
.github/workflows/scripts/cost-accuracy-test.sh	Adds Go workspace setup before the cost-accuracy build step; GOTOOLCHAIN=auto set inside the sourced script won't propagate to the parent shell, but the go.work file written to disk will.
.github/workflows/scripts/load-test.sh	Same pattern as cost-accuracy-test.sh — workspace setup added before the build; same note applies about GOTOOLCHAIN=auto scoping.
docs/changelogs/ent-v1.4.13.mdx	New enterprise v1.4.13 changelog page documenting features and fixes; added correctly to docs.json navigation.
docs/docs.json	Adds changelogs/ent-v1.4.13 at the top of the Enterprise changelog list — correctly ordered and placed.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[GET /v1/models request] --> B{VK header present?}
    B -- No --> C[Allow all providers]
    B -- Yes --> D{ConfigStore available?}
    D -- No --> E[503 Service Unavailable]
    D -- Yes --> F[GetVirtualKeyByValue]
    F --> G{Error?}
    G -- ErrNotFound --> C
    G -- Other error --> H[500 Internal Server Error]
    G -- nil --> I{vk == nil?}
    I -- Yes --> C
    I -- No --> J{vk.IsActive == nil?}
    J -- Yes --> C
    J -- No --> K{*vk.IsActive == false?}
    K -- Yes --> C
    K -- No --> L[Set BifrostContextKeyAvailableProviders]
    L --> M[Filtered model listing]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[GET /v1/models request] --> B{VK header present?}
    B -- No --> C[Allow all providers]
    B -- Yes --> D{ConfigStore available?}
    D -- No --> E[503 Service Unavailable]
    D -- Yes --> F[GetVirtualKeyByValue]
    F --> G{Error?}
    G -- ErrNotFound --> C
    G -- Other error --> H[500 Internal Server Error]
    G -- nil --> I{vk == nil?}
    I -- Yes --> C
    I -- No --> J{vk.IsActive == nil?}
    J -- Yes --> C
    J -- No --> K{*vk.IsActive == false?}
    K -- Yes --> C
    K -- No --> L[Set BifrostContextKeyAvailableProviders]
    L --> M[Filtered model listing]

Loading

Comments Outside Diff (2)

1. transports/bifrost-http/handlers/list_models_vk_test.go, line 32 (link)

   new(true) / new(false) are compile errors

   In Go, new is a built-in that requires a type argument (new(bool)), not a value. new(true) and new(false) will be rejected by the compiler with "true (untyped bool constant) is not a type". Both test cases will fail to build, so CI cannot pass. The same issue is on line 128.

   A common pattern for inline bool pointer literals is a small helper or an address-of-variable expression: b := true; IsActive: &b

2. transports/bifrost-http/handlers/list_models_vk.go, line 42-44 (link)

   IsActive == nil treated as inactive — contradicts DB semantics

   The TableVirtualKey struct documents // Nil means true (DB default) and provides IsActiveValue() which returns true when IsActive == nil. Records inserted without an explicit IsActive value will have IsActive = NULL in the database, meaning they are semantically active. With the current condition, those VKs reach return true without setting BifrostContextKeyAvailableProviders, so list-models will show all providers instead of the VK-restricted set. Using the existing IsActiveValue() helper avoids the ambiguity: if vk == nil || !vk.IsActiveValue(). There is also no test covering the IsActive == nil path, so this regression would be invisible in CI even once the compilation issue above is resolved.

_{Reviews (1): Last reviewed commit: "Merge branch 'main' into dev" | Re-trigger Greptile}