Skip to content

chore: bump Bifrost Helm chart to 2.1.24 with private network fix, env label, Datadog host/port split, passwordCommand, async log tuning, deployment strategy, and skills registry - #4474

Merged
akshaydeo merged 2 commits into
mainfrom
06-17-chore_bump_helm_version
Jun 16, 2026

Conversation

@BearTS

@BearTS BearTS commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Releases Bifrost Helm chart v2.1.24, fixing several fields that were defined in the schema but never wired into _helpers.tpl (and therefore silently dropped), and adding new configuration options for networking, logging, deployment strategy, and provider model filtering.

Changes

  • allow_private_network in provider networkConfig is now rendered by _helpers.tpl; it was present in the schema but had no effect previously.
  • bifrost.envLabel (max 10 chars) now maps to env_label, surfacing an environment label in the management UI sidebar.
  • Datadog plugin gains separate agent_host/agent_port and dogstatsd_host/dogstatsd_port fields as an alternative to the combined *_addr fields (defaulting to ports 8126/8125).
  • passwordCommand added for the PostgreSQL store (config + logs) to support dynamic password retrieval via stdout.
  • Async log writer tuning block added for SQLite and PostgreSQL (maxBatchSize, batchInterval, maxBatchBytes, writeQueueCapacity, deferredUsageConcurrency).
  • Top-level strategy field added for Deployment update strategy; passing {} preserves the Kubernetes default.
  • bifrost.client.allowDirectKeys and bifrost.client.mcpExternalClientUrl were previously unmapped in _helpers.tpl and silently dropped; they now render correctly.
  • blacklisted_models added alongside allowed_models in provider config.
  • bifrost.skillsRegistry (enabled + skills[]) now renders verbatim into skills_registry.

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

helm repo update
helm install bifrost bifrost/bifrost --version 2.1.24

Validate the newly wired fields by setting them in values.yaml and confirming they appear in the rendered manifests:

helm template bifrost bifrost/bifrost --version 2.1.24 -f your-values.yaml | grep -E "allow_private_network|env_label|blacklisted_models|skills_registry"

Breaking changes

  • Yes
  • No

Related issues

Security considerations

passwordCommand for PostgreSQL executes a shell command to retrieve the database password at runtime. Ensure the command and its environment are appropriately sandboxed and that secrets are not inadvertently logged.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d99ec0a7-88e8-45ee-a3f2-44b798f2f3a5

📥 Commits

Reviewing files that changed from the base of the PR and between 4444338 and cca3f1c.

📒 Files selected for processing (5)
  • docs/changelogs/helm-v2.1.24.mdx
  • docs/docs.json
  • helm-charts/bifrost/Chart.yaml
  • helm-charts/bifrost/README.md
  • helm-charts/index.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Documentation

    • Released Helm chart v2.1.24 with configuration improvements including PostgreSQL password handling, Datadog agent tuning, deployment strategy options, and skills registry support.
  • Chores

    • Updated Helm chart version to 2.1.24 and refreshed repository metadata.

Walkthrough

Bumps the bifrost Helm chart version from 2.1.23 to 2.1.24 in Chart.yaml, adds a new 2.1.24 release entry in helm-charts/index.yaml, updates README.md with the new version and changelog bullet list, creates the helm-v2.1.24.mdx changelog file, and registers it in the docs navigation.

Changes

Helm v2.1.24 Release

Layer / File(s) Summary
Chart version bump and index entry
helm-charts/bifrost/Chart.yaml, helm-charts/index.yaml
version field updated from 2.1.23 to 2.1.24; index.yaml gains a new bifrost release record with updated digest, urls, created, and generated timestamp fields.
Changelog content and docs navigation
docs/changelogs/helm-v2.1.24.mdx, docs/docs.json, helm-charts/bifrost/README.md
New helm-v2.1.24.mdx file lists configuration/rendering changes for this release; docs.json inserts the new page at the top of the Helm changelogs list; README.md latest version and top changelog section updated to 2.1.24.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • maximhq/bifrost#4336: Directly preceding Helm chart release bump (v2.1.23) updating the same set of files (Chart.yaml, README.md, index.yaml, changelog docs).
  • maximhq/bifrost#3755: Same pattern of Helm chart version bump with corresponding README.md, index.yaml, and changelog documentation updates.
  • maximhq/bifrost#3623: Another prior Helm chart release bump for bifrost updating the same metadata and documentation files.

Suggested reviewers

  • danpiths

Poem

🐇 A hop and a skip, the version's 2.1.24,
The changelog is written, the index updated once more,
New fields and new renames, the README now gleams,
A small little bump, but it's bigger than it seems!
Snuggle the docs, little rabbit — off to the store! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title comprehensively describes the main changes in the PR, including version bump and key features like private network fix, env label, Datadog split, passwordCommand, async log tuning, deployment strategy, and skills registry.
Description check ✅ Passed The description is well-structured, covering Summary, Changes, Type of change, Affected areas, How to test, Breaking changes, Security considerations, and most checklist items, closely following the template requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 06-17-chore_bump_helm_version

Comment @coderabbitai help to get the list of available commands and usage tips.

@BearTS BearTS changed the title chore: bump helm version chore: bump Bifrost Helm chart to 2.1.24 with private network fix, env label, Datadog host/port split, passwordCommand, async log tuning, deployment strategy, and skills registry Jun 16, 2026
@BearTS
BearTS marked this pull request as ready for review June 16, 2026 19:10
@BearTS
BearTS requested a review from a team as a code owner June 16, 2026 19:10
@coderabbitai
coderabbitai Bot requested a review from danpiths June 16, 2026 19:11
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 16, 2026

akshaydeo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Merge activity

  • Jun 16, 7:17 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 16, 7:18 PM UTC: @akshaydeo merged this pull request with Graphite.

@akshaydeo
akshaydeo changed the base branch from 06-17-feat_helm_updates to graphite-base/4474 June 16, 2026 19:17
@akshaydeo
akshaydeo changed the base branch from graphite-base/4474 to main June 16, 2026 19:18
@akshaydeo
akshaydeo dismissed coderabbitai[bot]’s stale review June 16, 2026 19:18

The base branch was changed.

@akshaydeo
akshaydeo merged commit 1ae56ad into main Jun 16, 2026
11 checks passed
@akshaydeo
akshaydeo deleted the 06-17-chore_bump_helm_version branch June 16, 2026 19:18
@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The chart release metadata and documentation updates are mostly straightforward, but the advertised provider blacklist behavior needs attention before merge.

The changed files are limited in scope and the issue is isolated to a documented Helm configuration path that can mislead users relying on model blocking.

docs/changelogs/helm-v2.1.24.mdx

T-Rex T-Rex Logs

What T-Rex did

    • Retrieved the matching base render for wired fields from helm-render-wired-fields-01-before.txt to serve as a baseline for comparison.
    • Compared the head render from helm-render-wired-fields-02-after.txt to the base render and confirmed the head render exited with code 0 and that ConfigMap fields were extracted, but noted mismatches: providers.openai.networkConfig.allowPrivateNetwork vs network_config.allow_private_network, and Datadog config omits defaulted agent_port/dogstatsd_port.
    • Executed the empty-default strategy scenario and captured helm-strategy-empty-default-01-before.txt, which shows an empty strategy/SQLite writer run with exit 0 and writer tuning in logs_store.writer.
    • Captured the after-state of the empty-default strategy run as helm-strategy-empty-default-02-after.txt, which shows exit 0 and writer tuning visible in logs_store.writer.

View all artifacts

T-Rex Ran code and verified through T-Rex

Comments Outside Diff (2)

  1. General comment

    P1 Provider allowPrivateNetwork values are not normalized to network_config.allow_private_network

    • Bug
      • The changelog promises provider networkConfig allow-private-network support renders as allow_private_network, but the head rendered ConfigMap preserves the camelCase input as providers.openai.networkConfig.allowPrivateNetwork. That means consumers expecting Bifrost's snake_case config contract will not receive the documented network_config.allow_private_network field.
    • Cause
      • The values-to-config helper only wires an existing snake_case .network_config.allow_private_network path; it does not normalize the documented camelCase Helm values path networkConfig.allowPrivateNetwork into network_config.allow_private_network. Evidence: helm-render-wired-fields-02-after.txt lines 94-106 show networkConfig.allowPrivateNetwork. The documentation claim is anchored at docs/changelogs/helm-v2.1.24.mdx:10.
    • Fix
      • Update the Helm helper to accept provider.networkConfig.allowPrivateNetwork and render it into network_config.allow_private_network in config.json, preserving any existing snake_case override behavior as needed. Add a Helm template test for this casing conversion.

    T-Rex Ran code and verified through T-Rex

  2. General comment

    P1 Datadog split host fields do not render default agent_port/dogstatsd_port values

    • Bug
      • The changelog and README comments claim agent_port and dogstatsd_port default to 8126/8125 when agent_host/dogstatsd_host are set. In the head render, Datadog config contains agent_host and dogstatsd_host, but no agent_port or dogstatsd_port fields are rendered, so the rendered config does not satisfy the advertised contract.
    • Cause
      • The Datadog config rendering passes split host fields through without materializing default port fields when the port values are omitted. Evidence: helm-render-wired-fields-02-after.txt line 35 shows Datadog config with agent_host and dogstatsd_host but without agent_port/dogstatsd_port; extracted JSON also reports datadog_plugin as null because plugins render as a list, but the raw ConfigMap line contains the actual plugin config. The documentation claim is anchored at docs/changelogs/helm-v2.1.24.mdx:12 and README comments at helm-charts/bifrost/values.yaml:569-576.
    • Fix
      • When rendering the Datadog plugin config, if agent_host is set and agent_port is omitted, set agent_port to "8126"; if dogstatsd_host is set and dogstatsd_port is omitted, set dogstatsd_port to "8125". Add a template test for omitted and explicit port cases.

    T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "chore: bump helm version" | Re-trigger Greptile

Comment thread docs/changelogs/helm-v2.1.24.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants