Skip to content

otel bump #4458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 4 commits into from
Jun 16, 2026
+9 −2
Merged

otel bump #4458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
261fc84
chore: cohere test fix
Jun 16, 2026
e0fc249
chore: cohere test fix (#4453)
akshaydeo Jun 16, 2026
f0668a3
fix: adds no op PreRequestHook in otel plugin (#4456)
Pratham-Mishra04 Jun 16, 2026
f56f8f0
plugin bump (#4457)
akshaydeo Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions plugins/otel/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,11 @@ func (p *OtelPlugin) HTTPTransportStreamChunkHook(ctx *schemas.BifrostContext, r
return chunk, nil
}

// PreRequestHook implements schemas.LLMPlugin (no-op — required for plugin indexing).
func (p *OtelPlugin) PreRequestHook(_ *schemas.BifrostContext, _ *schemas.BifrostRequest) error {
return nil
}

// PreLLMHook is a no-op - tracing is handled via the Inject method.
// The OTEL plugin receives completed traces from TracingMiddleware.
func (p *OtelPlugin) PreLLMHook(_ *schemas.BifrostContext, req *schemas.BifrostRequest) (*schemas.BifrostRequest, *schemas.LLMPluginShortCircuit, error) {
Expand Down
2 changes: 1 addition & 1 deletion plugins/otel/version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.2.20
1.2.21
4 changes: 3 additions & 1 deletion transports/bifrost-http/integrations/cohere_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ func TestCohereRerankRouteRequestConverter(t *testing.T) {
require.NotNil(t, bifrostReq)
require.NotNil(t, bifrostReq.RerankRequest)

assert.Equal(t, schemas.Cohere, bifrostReq.RerankRequest.Provider)
// Provider resolution is deferred to the modelcatalogresolver plugin layer,
// so the converter leaves it empty for an unprefixed model string.
assert.Equal(t, schemas.ModelProvider(""), bifrostReq.RerankRequest.Provider)
Comment on lines +67 to +69

@greptile-apps greptile-apps Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Keep Cohere fallback This expectation locks in an empty provider for the Cohere-specific rerank route. Core only fills that in if the model catalog resolver is registered and finds rerank-v3.5; otherwise validateRequestAfterPreRequestHooks returns could not auto resolve a provider... before the request reaches Cohere. A /cohere/v2/rerank request with a normal unprefixed Cohere model can therefore fail in deployments without a populated model catalog, whereas the converter previously pinned schemas.Cohere and routed correctly.

assert.Equal(t, "rerank-v3.5", bifrostReq.RerankRequest.Model)
assert.Equal(t, "what is bifrost?", bifrostReq.RerankRequest.Query)
require.Len(t, bifrostReq.RerankRequest.Documents, 2)
Expand Down
Loading