feat: add server.readBufferSize field to Bifrost Helm chart config - #4339
Conversation
|
Warning Review limit reached
More reviews will be available in 2 minutes and 33 seconds. Learn how PR review limits work. To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
server.readBufferSize field to Bifrost Helm chart config
aa43c2e to
8c35268
Compare
66d1bb7 to
92f7167
Compare
Confidence Score: 4/5Safe to merge; the change adds a new Helm knob with a sensible default and doesn't touch any Go runtime paths. The rendered config change is additive and the default value is consistent with the existing schema. The truthiness guard for
Important Files Changed
Reviews (1): Last reviewed commit: "feat: add server.readBufferSize in helm ..." | Re-trigger Greptile |
Merge activity
|

Summary
Adds support for configuring the HTTP server's
readBufferSizevia the Bifrost Helm chart. This allows operators to tune the read buffer used for parsing HTTP headers, which is useful when dealing with large headers or high-throughput workloads.Changes
bifrost.server.readBufferSizetovalues.yamlwith a default of65536(64 KiB)serverblock tovalues.schema.jsonwith type validation and description forreadBufferSize_helpers.tplto mapbifrost.server.readBufferSize→server.read_buffer_sizein the rendered configvalidate-helm-config-fields.sh(section 1b) to assert the field renders correctlyvalidate-helm-templates.shfor the newserver.readBufferSizefield (Gap 9)Type of change
Affected areas
How to test
Expected:
read_buffer_size: 131072appears in the rendered config output.New config field:
bifrost.server.readBufferSizeserver.read_buffer_size65536Screenshots/Recordings
N/A
Breaking changes
Related issues
Security considerations
No security implications. This is a performance tuning parameter for HTTP header buffer sizing.
Checklist
docs/contributing/README.mdand followed the guidelines