docs: add semantic cache latency warning, comparison table row, and routing harness ledger docs - #4255
Conversation
|
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds .gitignore entries for local test artifacts, documents the routing harness ledger format and append-only rule, and adds a "Latency overhead" warning plus an "Added latency" row to the direct vs semantic comparison table in semantic-caching docs. ChangesTest Infrastructure and Caching Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Confidence Score: 5/5Safe to merge — no code changes, only documentation updates and a gitignore entry. All three changes are documentation or chore. The latency descriptions in the semantic caching warning were cross-checked against the actual plugin implementation and are accurate. The gitignore pattern and README ledger section are self-consistent. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "docs: semantic cache doc updates" | Re-trigger Greptile |
b27dbd7 to
5218731
Compare
30f91f2 to
410adba
Compare
Merge activity
|
5218731 to
66ed6f1
Compare
…outing harness ledger docs (#4255) ## Summary This PR documents the latency trade-offs of semantic caching, introduces a local routing harness ledger convention for e2e test journaling, and adds the corresponding gitignore entry to keep those ledger files out of version control. ## Changes - Added a `<Warning>` block to the semantic caching docs explaining the latency overhead for direct lookups, semantic lookups, and cache writes — including the nuance that a semantic cache hit still costs an embedding round-trip, and a semantic miss pays that cost on top of the full LLM call. - Added a row to the direct vs. semantic comparison table covering added latency per mode. - Added a `Routing Harness Ledger` section to the e2e API README describing the daily journaling convention (`routing/ledger-YYYY-MM-DD.md`), its structure, and the rule against rewriting past days. - Added `tests/e2e/api/routing/ledger-*` to `.gitignore` so local run journals are never committed. ## Type of change - [ ] Bug fix - [ ] Feature - [ ] Refactor - [x] Documentation - [x] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [x] Docs ## How to test Verify the docs render correctly and that the gitignore pattern excludes ledger files as expected: ```sh # Confirm ledger files are ignored touch tests/e2e/api/routing/ledger-2025-01-01.md git status # should not appear as an untracked file ``` Review the updated semantic caching docs to confirm the warning block and table row render as intended. ## Breaking changes - [x] No ## Related issues N/A ## Security considerations None. No code changes; no secrets, auth, or PII involved. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [x] I updated documentation where needed - [x] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added a Latency overhead warning to semantic caching docs describing added costs for cache reads and asynchronous writes * Clarified direct vs. semantic caching comparison with an explicit “Added latency” row * New routing harness ledger guidance describing daily ledger entries and append-only practices * **Chores** * Updated ignore rules to exclude local test artifacts and routing ledger journal files <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…outing harness ledger docs (maximhq#4255) ## Summary This PR documents the latency trade-offs of semantic caching, introduces a local routing harness ledger convention for e2e test journaling, and adds the corresponding gitignore entry to keep those ledger files out of version control. ## Changes - Added a `<Warning>` block to the semantic caching docs explaining the latency overhead for direct lookups, semantic lookups, and cache writes — including the nuance that a semantic cache hit still costs an embedding round-trip, and a semantic miss pays that cost on top of the full LLM call. - Added a row to the direct vs. semantic comparison table covering added latency per mode. - Added a `Routing Harness Ledger` section to the e2e API README describing the daily journaling convention (`routing/ledger-YYYY-MM-DD.md`), its structure, and the rule against rewriting past days. - Added `tests/e2e/api/routing/ledger-*` to `.gitignore` so local run journals are never committed. ## Type of change - [ ] Bug fix - [ ] Feature - [ ] Refactor - [x] Documentation - [x] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [x] Docs ## How to test Verify the docs render correctly and that the gitignore pattern excludes ledger files as expected: ```sh # Confirm ledger files are ignored touch tests/e2e/api/routing/ledger-2025-01-01.md git status # should not appear as an untracked file ``` Review the updated semantic caching docs to confirm the warning block and table row render as intended. ## Breaking changes - [x] No ## Related issues N/A ## Security considerations None. No code changes; no secrets, auth, or PII involved. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [x] I updated documentation where needed - [x] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added a Latency overhead warning to semantic caching docs describing added costs for cache reads and asynchronous writes * Clarified direct vs. semantic caching comparison with an explicit “Added latency” row * New routing harness ledger guidance describing daily ledger entries and append-only practices * **Chores** * Updated ignore rules to exclude local test artifacts and routing ledger journal files <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…outing harness ledger docs (maximhq#4255) ## Summary This PR documents the latency trade-offs of semantic caching, introduces a local routing harness ledger convention for e2e test journaling, and adds the corresponding gitignore entry to keep those ledger files out of version control. ## Changes - Added a `<Warning>` block to the semantic caching docs explaining the latency overhead for direct lookups, semantic lookups, and cache writes — including the nuance that a semantic cache hit still costs an embedding round-trip, and a semantic miss pays that cost on top of the full LLM call. - Added a row to the direct vs. semantic comparison table covering added latency per mode. - Added a `Routing Harness Ledger` section to the e2e API README describing the daily journaling convention (`routing/ledger-YYYY-MM-DD.md`), its structure, and the rule against rewriting past days. - Added `tests/e2e/api/routing/ledger-*` to `.gitignore` so local run journals are never committed. ## Type of change - [ ] Bug fix - [ ] Feature - [ ] Refactor - [x] Documentation - [x] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [x] Docs ## How to test Verify the docs render correctly and that the gitignore pattern excludes ledger files as expected: ```sh # Confirm ledger files are ignored touch tests/e2e/api/routing/ledger-2025-01-01.md git status # should not appear as an untracked file ``` Review the updated semantic caching docs to confirm the warning block and table row render as intended. ## Breaking changes - [x] No ## Related issues N/A ## Security considerations None. No code changes; no secrets, auth, or PII involved. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [x] I updated documentation where needed - [x] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added a Latency overhead warning to semantic caching docs describing added costs for cache reads and asynchronous writes * Clarified direct vs. semantic caching comparison with an explicit “Added latency” row * New routing harness ledger guidance describing daily ledger entries and append-only practices * **Chores** * Updated ignore rules to exclude local test artifacts and routing ledger journal files <!-- end of auto-generated comment: release notes by coderabbit.ai -->

Summary
This PR documents the latency trade-offs of semantic caching, introduces a local routing harness ledger convention for e2e test journaling, and adds the corresponding gitignore entry to keep those ledger files out of version control.
Changes
<Warning>block to the semantic caching docs explaining the latency overhead for direct lookups, semantic lookups, and cache writes — including the nuance that a semantic cache hit still costs an embedding round-trip, and a semantic miss pays that cost on top of the full LLM call.Routing Harness Ledgersection to the e2e API README describing the daily journaling convention (routing/ledger-YYYY-MM-DD.md), its structure, and the rule against rewriting past days.tests/e2e/api/routing/ledger-*to.gitignoreso local run journals are never committed.Type of change
Affected areas
How to test
Verify the docs render correctly and that the gitignore pattern excludes ledger files as expected:
Review the updated semantic caching docs to confirm the warning block and table row render as intended.
Breaking changes
Related issues
N/A
Security considerations
None. No code changes; no secrets, auth, or PII involved.
Checklist
docs/contributing/README.mdand followed the guidelinesSummary by CodeRabbit
Documentation
Chores