Skip to content

fix: build fix for missing import - #4244

Merged
akshaydeo merged 1 commit into
devfrom
06-10-fix_build_fix_for_missing_import
Jun 10, 2026
Merged

akshaydeo merged 1 commit into
devfrom
06-10-fix_build_fix_for_missing_import

Conversation

@roroghost17

@roroghost17 roroghost17 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes a minor whitespace/formatting inconsistency in the Bedrock embedding response struct definition.

Changes

  • Aligned the inline comment on the Uint8 field to match the formatting style of the surrounding Ubinary field comment, removing an extra trailing space.

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

go test ./...

Screenshots/Recordings

N/A

Breaking changes

  • Yes
  • No

Related issues

N/A

Security considerations

None.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

Summary by CodeRabbit

  • Bug Fixes
    • Resolved a compilation error in the embedding service to ensure proper functionality.

@CLAassistant

CLAassistant commented Jun 10, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d1187c2d-0aae-44b9-897b-336310e30f39

📥 Commits

Reviewing files that changed from the base of the PR and between 6eae6ba and 9af8597.

📒 Files selected for processing (1)
  • core/providers/bedrock/embedding.go

📝 Walkthrough

Walkthrough

This PR adds the missing strings import to the Bedrock embedding provider and adjusts comment spacing. The import enables compilation with existing header parsing helpers that use strings.EqualFold and strings.TrimSpace. A whitespace adjustment in a Cohere response struct comment has no functional impact.

Changes

Bedrock Embedding Provider Fixes

Layer / File(s) Summary
Import and comment adjustment
core/providers/bedrock/embedding.go
strings import added to support header parsing helpers; whitespace adjusted in a Cohere typed-response struct comment with no behavioral change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • danpiths
  • akshaydeo

Poem

🐰 A hop and a skip through imports so neat,
The strings now compile, the code's complete,
A comment spaced just right, no fuss,
Small fixes make big magic for us! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers most template sections but has a critical mismatch: it describes only whitespace/formatting changes, while the title and AI summary indicate an import fix was also made. Update the description to accurately document the missing import addition and explain why it was needed, ensuring consistency with the title and AI-generated summary.
Title check ❓ Inconclusive The title mentions a 'missing import' but the PR description and AI-generated summary indicate the primary change is whitespace/comment alignment, with the import addition being secondary. Clarify whether the main intent is the missing import fix or the whitespace adjustment. If the import is the primary issue, update the description; otherwise, revise the title to reflect the actual main change.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 06-10-fix_build_fix_for_missing_import

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@roroghost17
roroghost17 marked this pull request as ready for review June 10, 2026 07:20
@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — adds the missing standard-library import needed for the file to compile and makes a trivial comment alignment fix.

The change is minimal: one import addition that unblocks compilation and one cosmetic comment edit. Both are confined to a single file with no logic changes.

No files require special attention.

Important Files Changed

Filename Overview
core/providers/bedrock/embedding.go Adds missing "strings" import required by strings.EqualFold and strings.TrimSpace in inputTokensFromHeaders; also removes a trailing space from the Uint8 field comment.

Reviews (1): Last reviewed commit: "fix: build fix for missing import" | Re-trigger Greptile

akshaydeo commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Merge activity

  • Jun 10, 7:28 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 10, 7:28 AM UTC: @akshaydeo merged this pull request with Graphite.

@akshaydeo
akshaydeo merged commit 2b81969 into dev Jun 10, 2026
15 of 16 checks passed
@akshaydeo
akshaydeo deleted the 06-10-fix_build_fix_for_missing_import branch June 10, 2026 07:28
akshaydeo pushed a commit that referenced this pull request Jun 12, 2026
## Summary

Fixes a minor whitespace/formatting inconsistency in the Bedrock embedding response struct definition.

## Changes

- Aligned the inline comment on the `Uint8` field to match the formatting style of the surrounding `Ubinary` field comment, removing an extra trailing space.

## Type of change

- [ ] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [x] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [x] Providers/Integrations
- [ ] Plugins
- [ ] UI (React)
- [ ] Docs

## How to test

```sh
go test ./...
```

## Screenshots/Recordings

N/A

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

N/A

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Bug Fixes**
  * Resolved a compilation error in the embedding service to ensure proper functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
akhsaul pushed a commit to akhsaul/bifrost that referenced this pull request Aug 27, 2026
## Summary

Fixes a minor whitespace/formatting inconsistency in the Bedrock embedding response struct definition.

## Changes

- Aligned the inline comment on the `Uint8` field to match the formatting style of the surrounding `Ubinary` field comment, removing an extra trailing space.

## Type of change

- [ ] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [x] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [x] Providers/Integrations
- [ ] Plugins
- [ ] UI (React)
- [ ] Docs

## How to test

```sh
go test ./...
```

## Screenshots/Recordings

N/A

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

N/A

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Bug Fixes**
  * Resolved a compilation error in the embedding service to ensure proper functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
occcat pushed a commit to occcat/bifrost that referenced this pull request Sep 2, 2026
## Summary

Fixes a minor whitespace/formatting inconsistency in the Bedrock embedding response struct definition.

## Changes

- Aligned the inline comment on the `Uint8` field to match the formatting style of the surrounding `Ubinary` field comment, removing an extra trailing space.

## Type of change

- [ ] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [x] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [x] Providers/Integrations
- [ ] Plugins
- [ ] UI (React)
- [ ] Docs

## How to test

```sh
go test ./...
```

## Screenshots/Recordings

N/A

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

N/A

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Bug Fixes**
  * Resolved a compilation error in the embedding service to ensure proper functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants