feat: scope ListModels to single key when KeyID is set, add filterKeysByID helper

[Pratham-Mishra04]

Summary

Adds a KeyID field to BifrostListModelsRequest that scopes a ListModels call to a single key matched by Key.ID. This allows callers such as the catalog composer to cache list-models output per-key for fine-grained invalidation without requiring an extra round-trip or having the provider aggregate results across every configured key.

Changes

• Added KeyID *string to BifrostListModelsRequest (tagged json:"-" so it is never forwarded to providers). When set, the request worker filters the already-validated key set down to the single matching key before dispatching. If no key matches, a BifrostError is returned immediately.
• Added filterKeysByID helper that returns a new slice containing only keys whose ID equals the target, leaving the input slice unmodified.
• Added TestFilterKeysByID covering: a successful match, a missing key, an empty target string, and input-slice immutability.

Note: the lookup runs against the already-filtered set of supported keys (disabled or invalid keys are excluded before the match), so a KeyID pointing to a disabled key produces the same "no key found" error as a non-existent KeyID. Callers that need to distinguish these cases must inspect the raw account configuration directly.

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

go version
go test ./...

The new TestFilterKeysByID test directly exercises the helper and the key-scoping logic. To validate end-to-end, issue a ListModels request with KeyID set to a valid key ID and confirm only that key's models are returned. Issue one with an unknown KeyID and confirm a "no key found" error is returned.

Screenshots/Recordings

N/A

Breaking changes

• Yes
• No

Related issues

Security considerations

KeyID is tagged json:"-" and is never serialised or forwarded to any external provider. No secrets or PII are introduced.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

Warning

Review limit reached

@Pratham-Mishra04, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 36 minutes and 41 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2c7eda1a-276e-4258-acca-ba07c3c06eb1

📥 Commits

Reviewing files that changed from the base of the PR and between d923cda and 499ef15.

📒 Files selected for processing (3)

• core/bifrost.go
• core/bifrost_test.go
• core/schemas/models.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat_adds_key_param_in_list_models

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Pratham-Mishra04]

• test: add model catalog wiring e2e collection and generator script #4197
• feat: add adaptive routing settings sub-route with sidebar nav and enterprise fallback #4196
• feat: add core routing engine audit trail for retry and fallback transitions #4195
• refactor: replace aggregated model discovery shims with per-key live cache fanout via OnKeyAdded/Updated/Deleted #4194
• feat: scope ListModels to single key when KeyID is set, add filterKeysByID helper #4193 👈 (View in Graphite)
• feat: adds datasheet store to modelcatalog #4191 : 1 other dependent PR (#4192 )
• feat: add live model catalog cache store with filtered/unfiltered entry support #4190
• feat: add keyconfig.Store for per-key config aggregation with allow/block/alias views #4189
• docs: expand alias object schema, routing_info response shape, and pricing lookup precedence #4188
• refactor: replace resolvePricing flat args with RoutingInfo and add backward-compat fallback for legacy ExtraFields #4187
• feat: add RoutingInfo to response/error extra fields with fallback and alias resolution context #4186
• feat: replace flat aliases table with rich DeploymentsTable supporting per-deployment model family, canonical name, and provider overrides #4185
• feat: add per-alias ReplicateAliasCfg.UseDeploymentsEndpoint override with provider-scoped alias sub-config validation #4184
• feat: add per-alias Vertex project/region overrides and context-aware model family resolution #4183
• feat: add alias-level region/ARN overrides and context-aware model family resolution for Bedrock #4182
• feat: add per-alias Azure endpoint, API version, and Anthropic version overrides with context-aware ResolveFamily #4181
• refactor: promote KeyAliases value type from string to AliasConfig with legacy wire-shape compatibility #4180
• feat: add routing allowlist enforcement via BifrostContextKeyRoutingAllowedProviders #4179
• docs: add PreRequestHook routing phase to plugin lifecycle and sequencing docs #4178
• refactor: extract provider resolution into modelcatalogresolver PreRequestHook plugin #4177
• refactor: migrate governance routing from HTTPTransportPreHook to PreRequestHook with BifrostRequest-native mutations #4176
• feat: add PreRequestHook to LLMPlugin interface for once-per-request provider/model routing #4175
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Confidence Score: 5/5

Safe to merge; the change is narrow, pool-safe, and the key filtering logic is straightforward.

The feature is a clean, well-tested addition. The only concern is that the "no key found" error leaves fallback behavior open, which could silently route to a different provider when fallbacks are configured — a minor edge case unlikely to occur in practice for ListModels requests.

core/bifrost.go — specifically the AllowFallbacks omission in the new error path at the KeyID filter block.

Important Files Changed

Filename	Overview
core/schemas/models.go	Adds KeyID *string field to BifrostListModelsRequest with json:"-" tag; clean addition consistent with the existing Unfiltered field pattern.
core/bifrost.go	Adds key-scoping logic after getAllSupportedKeys and a filterKeysByID helper; the "no key found" error leaves AllowFallbacks unset (nil = allow fallbacks), which is consistent with surrounding error patterns but may be surprising for an explicitly-scoped request.
core/bifrost_test.go	Adds TestFilterKeysByID covering match, miss, empty target, and input-slice immutability; table-driven subtests with clear failure messages.

_{Reviews (4): Last reviewed commit: "feat: adds key param in list models" | Re-trigger Greptile}

[Pratham-Mishra04]

Merge activity

• Jun 9, 10:11 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jun 9, 10:55 AM UTC: Graphite rebased this pull request as part of a merge.
• Jun 9, 10:56 AM UTC: @Pratham-Mishra04 merged this pull request with Graphite.