fix: private network toggle in custom provider form - #4160
Conversation
|
tejas ghatte seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new ChangesPrivate Network Field Addition
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Confidence Score: 4/5Safe to merge — the toggle defaults to off, the RBAC guard is applied, and all form wiring is correct. The change is small and well-scoped. The only issue is a minor type-safety gap in the Switch checked prop that mirrors the existing is_key_less field and is practically neutralized by the explicit false default value. No files require special attention beyond the single changed component. Important Files Changed
Reviews (1): Last reviewed commit: "fix: private network toggle in custom pr..." | Re-trigger Greptile |
Merge activity
|

Summary
Adds an "Allow Private Network" toggle to the custom provider creation form, enabling users to configure whether a custom provider can connect to private network IP ranges (e.g.,
192.168.x.x,10.x.x.x). Link-local addresses remain blocked regardless of this setting.Changes
allow_private_networkas an optional boolean field to the custom provider form schema, defaulting tofalsenetwork_config.allow_private_networkwhen saving the providerType of change
Affected areas
How to test
allow_private_network: trueis included in the savednetwork_config.allow_private_network: falseis sent.Screenshots/Recordings
Add before/after screenshots of the custom provider form showing the new toggle.
Breaking changes
Related issues
Link related issues and discussions. Example: Closes #123
Security considerations
This toggle explicitly opts a custom provider into connecting to private network ranges. It defaults to
false(blocked), preserving the existing secure-by-default behavior. Link-local addresses remain blocked unconditionally to prevent SSRF via metadata endpoints.Checklist
docs/contributing/README.mdand followed the guidelinesSummary by CodeRabbit