Skip to content

changelog fixes - #4149

Merged
akshaydeo merged 1 commit into
devfrom
06-08-changelog_fixes
Jun 8, 2026
Merged

changelog fixes#4149
akshaydeo merged 1 commit into
devfrom
06-08-changelog_fixes

Conversation

@akshaydeo

@akshaydeo akshaydeo commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Briefly explain the purpose of this PR and the problem it solves.

Changes

  • What was changed and why
  • Any notable design decisions or trade-offs

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Describe the steps to validate this change. Include commands and expected outcomes.

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

If adding new configs or environment variables, document them here.

Screenshots/Recordings

If UI changes, add before/after screenshots or short clips.

Breaking changes

  • Yes
  • No

If yes, describe impact and migration instructions.

Related issues

Link related issues and discussions. Example: Closes #123

Security considerations

Note any security implications (auth, secrets, PII, sandboxing, etc.).

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

Summary by CodeRabbit

  • Documentation

    • Updated changelog documentation with clarifications on upgrade procedures and compatibility considerations
    • Added notification of a known quota issue in v1.4.7 (resolved in v1.4.8)
  • Bug Fixes

    • Fixed quota and reload APIs to properly return accurate governance data and budget information

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 33ba126f-c03f-4c22-ab50-b83326451544

📥 Commits

Reviewing files that changed from the base of the PR and between 1e1d75b and baa4da7.

📒 Files selected for processing (3)
  • docs/changelogs/ent-v1.4.7.mdx
  • docs/changelogs/v1.5.11.mdx
  • transports/changelog.md

📝 Walkthrough

Walkthrough

This PR updates changelog documentation across three files to reflect VK budget quota and reload API governance data hydration improvements. The ent-v1.4.7 changelog adds a warning about a known /virtua-key/quota issue, v1.5.11 refactors rollback instructions with accordion UI and migration guidance, and transports/changelog.md documents the bug fix details.

Changes

VK Budget Governance Changelog Documentation

Layer / File(s) Summary
Enterprise changelog warnings and UI updates
docs/changelogs/ent-v1.4.7.mdx, docs/changelogs/v1.5.11.mdx
ent-v1.4.7 adds a warning callout noting the known /virtua-key/quota issue is fixed in v1.4.8. v1.5.11 updates rollback instructions with accordion components and adds a <Warning> message instructing users to run rollback SQL before migrating to preserve v1.5.8 compatibility.
Transports package changelog fix entry
transports/changelog.md
Documents the bug fix where VK budget quota and reload (rotate) APIs now hydrate governance data (model configs and budgets) before returning, with added error handling for model config hydration failures.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • maximhq/bifrost#4144: Documents the same VK Budget Quota & Reload governance hydration fix in transports/changelog.md.
  • maximhq/bifrost#4135: Modifies the ent-v1.4.7 changelog with related /virtua-key/quota issue documentation.
  • maximhq/bifrost#3769: Touches VK quota/budget governance behavior documentation in transports/changelog.md.

Suggested reviewers

  • danpiths
  • Pratham-Mishra04

Poem

🐰 Changelogs updated with care,
Warnings and rollback steps declared,
VK budgets now hydrated true,
Accordion folds the guidance through.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 06-08-changelog_fixes

Comment @coderabbitai help to get the list of available commands and usage tips.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@akshaydeo
akshaydeo marked this pull request as ready for review June 8, 2026 11:00

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akshaydeo
akshaydeo merged commit c9bb67e into dev Jun 8, 2026
12 of 15 checks passed
@akshaydeo
akshaydeo deleted the 06-08-changelog_fixes branch June 8, 2026 11:00
akshaydeo added a commit that referenced this pull request Jun 8, 2026
@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

Safe to merge after correcting the malformed Warning tag and endpoint path typo in the enterprise changelog.

The <Warning>> double-chevron in ent-v1.4.7.mdx will break MDX component rendering so the warning block won't display, and the endpoint path /virtua-key/quota is a typo that misinforms readers. Both issues are confined to documentation and have no runtime impact, but they defeat the purpose of the warning note itself.

docs/changelogs/ent-v1.4.7.mdx needs the Warning tag syntax and endpoint path typo fixed before this renders correctly.

Important Files Changed

Filename Overview
docs/changelogs/ent-v1.4.7.mdx Adds a new Warning block about a known /virtual-key/quota issue in v1.4.7, but the tag has a double > character (<Warning>>) that will break MDX rendering, and the endpoint path has a typo (/virtua-key/quota instead of /virtual-key/quota).
docs/changelogs/v1.5.11.mdx Adds a pre-migration rollback Warning, fixes a heading space (⏲️ Rolling back), and wraps the single-node and multi-node rollback SQL blocks in AccordionGroup/Accordion for better readability. No issues found.
transports/changelog.md New file containing the v1.5.11 VK Budget Quota fix entry; missing a trailing newline at end of file.

Reviews (1): Last reviewed commit: "changelog fixes" | Re-trigger Greptile

Comment on lines +14 to +16
<Warning>>
v1.4.7 has a known `/virtua-key/quota` issue which is fixed in v1.4.8.
</Warning>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The <Warning> tag has a stray extra > character, which will likely break MDX/Mintlify rendering and prevent the warning block from displaying correctly. Additionally, the endpoint path /virtua-key/quota appears to be missing the letter l — it should be /virtual-key/quota.

Suggested change
<Warning>>
v1.4.7 has a known `/virtua-key/quota` issue which is fixed in v1.4.8.
</Warning>
<Warning>
v1.4.7 has a known `/virtual-key/quota` issue which is fixed in v1.4.8.
</Warning>

Comment thread transports/changelog.md
@@ -0,0 +1,3 @@
## 🐞 Fixed

- **VK Budget Quota & Reload APIs** — The virtual key quota and reload (rotate) APIs now hydrate governance data (model configs and budgets) before returning, so budget information is accurate instead of missing or stale. Also added proper error handling when fetching model config during hydration. No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The file is missing a trailing newline. Most editors and tooling expect text files to end with a newline character.

Suggested change
- **VK Budget Quota & Reload APIs** — The virtual key quota and reload (rotate) APIs now hydrate governance data (model configs and budgets) before returning, so budget information is accurate instead of missing or stale. Also added proper error handling when fetching model config during hydration.
- **VK Budget Quota & Reload APIs** — The virtual key quota and reload (rotate) APIs now hydrate governance data (model configs and budgets) before returning, so budget information is accurate instead of missing or stale. Also added proper error handling when fetching model config during hydration.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files API Support

2 participants