changelog fixes - #4149
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR updates changelog documentation across three files to reflect VK budget quota and reload API governance data hydration improvements. The ent-v1.4.7 changelog adds a warning about a known ChangesVK Budget Governance Changelog Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
|
Confidence Score: 4/5Safe to merge after correcting the malformed Warning tag and endpoint path typo in the enterprise changelog. The docs/changelogs/ent-v1.4.7.mdx needs the Warning tag syntax and endpoint path typo fixed before this renders correctly. Important Files Changed
Reviews (1): Last reviewed commit: "changelog fixes" | Re-trigger Greptile |
| <Warning>> | ||
| v1.4.7 has a known `/virtua-key/quota` issue which is fixed in v1.4.8. | ||
| </Warning> |
There was a problem hiding this comment.
The
<Warning> tag has a stray extra > character, which will likely break MDX/Mintlify rendering and prevent the warning block from displaying correctly. Additionally, the endpoint path /virtua-key/quota appears to be missing the letter l — it should be /virtual-key/quota.
| <Warning>> | |
| v1.4.7 has a known `/virtua-key/quota` issue which is fixed in v1.4.8. | |
| </Warning> | |
| <Warning> | |
| v1.4.7 has a known `/virtual-key/quota` issue which is fixed in v1.4.8. | |
| </Warning> |
| @@ -0,0 +1,3 @@ | |||
| ## 🐞 Fixed | |||
|
|
|||
| - **VK Budget Quota & Reload APIs** — The virtual key quota and reload (rotate) APIs now hydrate governance data (model configs and budgets) before returning, so budget information is accurate instead of missing or stale. Also added proper error handling when fetching model config during hydration. No newline at end of file | |||
There was a problem hiding this comment.
The file is missing a trailing newline. Most editors and tooling expect text files to end with a newline character.
| - **VK Budget Quota & Reload APIs** — The virtual key quota and reload (rotate) APIs now hydrate governance data (model configs and budgets) before returning, so budget information is accurate instead of missing or stale. Also added proper error handling when fetching model config during hydration. | |
| - **VK Budget Quota & Reload APIs** — The virtual key quota and reload (rotate) APIs now hydrate governance data (model configs and budgets) before returning, so budget information is accurate instead of missing or stale. Also added proper error handling when fetching model config during hydration. |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Summary
Briefly explain the purpose of this PR and the problem it solves.
Changes
Type of change
Affected areas
How to test
Describe the steps to validate this change. Include commands and expected outcomes.
If adding new configs or environment variables, document them here.
Screenshots/Recordings
If UI changes, add before/after screenshots or short clips.
Breaking changes
If yes, describe impact and migration instructions.
Related issues
Link related issues and discussions. Example: Closes #123
Security considerations
Note any security implications (auth, secrets, PII, sandboxing, etc.).
Checklist
docs/contributing/README.mdand followed the guidelinesSummary by CodeRabbit
Documentation
Bug Fixes