Skip to content

fix: use JS-based theme detection for loading shell instead of prefers-color-scheme media query #4102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 1 commit into from
Jun 6, 2026
Merged

fix: use JS-based theme detection for loading shell instead of prefers-color-scheme media query #4102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 1 addition & 41 deletions ui/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,47 +10,7 @@
</head>

<body class="font-sans antialiased">
<div id="root">
<!-- Inline loading shell — shown until React mounts and replaces #root's innerHTML. -->
<style>
*{box-sizing:border-box;margin:0;padding:0;border:0 solid}
#bifrost-shell{display:flex;height:100vh;background:#f4f4f5;color:#71717a;font-family:ui-sans-serif,system-ui,-apple-system,sans-serif}
@media(prefers-color-scheme:dark){#bifrost-shell{background:#1a1a1e;color:#a1a1aa}}
#bifrost-shell .sidebar{width:240px;border-right:1px solid rgba(0,0,0,.08);padding:16px;display:flex;flex-direction:column;gap:24px}
@media(prefers-color-scheme:dark){#bifrost-shell .sidebar{border-color:rgba(255,255,255,.1)}}
#bifrost-shell .logo{height:24px;width:auto;opacity:.8}
#bifrost-shell .nav-item{height:12px;border-radius:6px;background:currentColor;opacity:.08}
#bifrost-shell .main{flex:1;padding:32px;display:flex;flex-direction:column;gap:20px}
#bifrost-shell .bar{border-radius:6px;background:currentColor;opacity:.06}
@keyframes shell-fade{from{opacity:0}to{opacity:1}}
#bifrost-shell{animation:shell-fade .2s ease-out}
</style>
<div id="bifrost-shell" aria-hidden="true">
<div class="sidebar">
<picture>
<source srcset="/bifrost-logo-dark.webp" media="(prefers-color-scheme:dark)">
<img src="/bifrost-logo.webp" class="logo" alt="" width="120" height="24">
</picture>
<div style="display:flex;flex-direction:column;gap:10px">
<div class="nav-item" style="width:70%"></div>
<div class="nav-item" style="width:55%"></div>
<div class="nav-item" style="width:80%"></div>
<div class="nav-item" style="width:45%"></div>
<div class="nav-item" style="width:65%"></div>
</div>
</div>
<div class="main">
<div class="bar" style="height:32px;width:240px"></div>
<div class="bar" style="height:1px;width:100%"></div>
<div style="display:flex;gap:16px">
<div class="bar" style="height:80px;flex:1"></div>
<div class="bar" style="height:80px;flex:1"></div>
<div class="bar" style="height:80px;flex:1"></div>
</div>
<div class="bar" style="height:200px;width:100%"></div>
</div>
</div>
</div>
<div id=root><script>!function(){try{var e=localStorage.getItem("theme"),e="dark"===e||"light"!==e&&matchMedia("(prefers-color-scheme:dark)").matches;document.getElementById("root").classList.toggle("shell-dark",e)}catch(t){try{document.getElementById("root").classList.toggle("shell-dark",matchMedia("(prefers-color-scheme:dark)").matches)}catch(t){}}}()</script><style>*{box-sizing:border-box;margin:0;padding:0;border:0 solid}#bifrost-shell{display:flex;height:100vh;background:#f4f4f5;color:#71717a;font-family:ui-sans-serif,system-ui,-apple-system,sans-serif}.shell-dark #bifrost-shell{background:#1a1a1e;color:#a1a1aa}#bifrost-shell .sidebar{width:240px;border-right:1px solid rgba(0,0,0,.08);padding:16px;display:flex;flex-direction:column;gap:24px}.shell-dark #bifrost-shell .sidebar{border-color:rgba(255,255,255,.1)}#bifrost-shell .logo{height:24px;opacity:.8;width:max-content}#bifrost-shell .logo-dark{display:none}.shell-dark #bifrost-shell .logo-light{display:none}.shell-dark #bifrost-shell .logo-dark{display:inline}#bifrost-shell .nav-item{height:12px;border-radius:6px;background:currentColor;opacity:.08}#bifrost-shell .main{flex:1;padding:32px;display:flex;flex-direction:column;gap:20px}#bifrost-shell .bar{border-radius:6px;background:currentColor;opacity:.06}@keyframes shell-fade{from{opacity:0}to{opacity:1}}#bifrost-shell{animation:shell-fade .2s ease-out}</style><div id=bifrost-shell aria-hidden=true><div class=sidebar><img alt=""class="logo logo-light"src=/bifrost-logo.webp> <img alt=""class="logo logo-dark"src=/bifrost-logo-dark.webp><div style=display:flex;flex-direction:column;gap:10px><div class=nav-item style=width:70%></div><div class=nav-item style=width:55%></div><div class=nav-item style=width:80%></div><div class=nav-item style=width:45%></div><div class=nav-item style=width:65%></div></div></div><div class=main><div class=bar style=height:32px;width:240px></div><div class=bar style=height:1px;width:100%></div><div style=display:flex;gap:16px><div class=bar style=height:80px;flex:1></div><div class=bar style=height:80px;flex:1></div><div class=bar style=height:80px;flex:1></div></div><div class=bar style=height:200px;width:100%></div></div></div></div>
<script type="module" src="/app/main.tsx"></script>
</body>
</html>
Loading