docs: document rich alias object form, routing_info response block, and pricing lookup precedence - #4022
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates documentation for rich alias objects, ChangesAlias Schema and Pricing Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
|
Confidence Score: 5/5Documentation-only change; all described fields, types, and resolution logic match the current Go implementation. The new content is accurate: RoutingInfo, ResolvedKeyAlias, the deprecated-field backfill, the three-step pricing lookup, and the provider-mismatch validation rule all exist exactly as documented. Two minor example inconsistencies exist but neither introduces misinformation that would cause integration bugs. No files require special attention; the small example inconsistencies in docs/providers/aliasing-models.mdx are cosmetic. Important Files Changed
Reviews (11): Last reviewed commit: "docs: alias and pricing doc updates" | Re-trigger Greptile |
993c4ad to
afd8acd
Compare
81de7ad to
51aec53
Compare
live model cache store and port keyconfig regression tests for alias/model isolation
#4034
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/providers/aliasing-models.mdx`:
- Line 100: The docs list for the model_family enum is out of sync with the
config schema: update the enum values in the aliasing-models.mdx documentation
to exactly match the model_family enum in the config.schema.json (or, if the
additional families are intended, add them to the model_family enum in the
schema instead); specifically reconcile/remove the entries `gemma`, `llama`,
`imagen`, `veo` from the docs or add those identifiers to the schema so
model_family is authoritative and both sources match.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2c60af91-dbce-4fbd-88f1-4125e5216769
📒 Files selected for processing (3)
docs/deployment-guides/config-json/providers.mdxdocs/providers/aliasing-models.mdxdocs/providers/custom-pricing.mdx
51aec53 to
a3fcec4
Compare
afd8acd to
86ffbe6
Compare
d1da99b to
afb17b5
Compare
53745d2 to
61f1e36
Compare
afb17b5 to
88bcc64
Compare
1d1469c to
5f44a42
Compare
88bcc64 to
586b04f
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
docs/providers/aliasing-models.mdx (1)
100-100:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
model_familyenum still out of sync with config schemaThis is the same issue flagged in the previous review. Line 100 documents
gemma,llama,imagen,veowhich are not present in themodel_familyenum intransports/config.schema.json. Remove these values or add them to the schema if they are intended to be supported.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/providers/aliasing-models.mdx` at line 100, The docs list extra model_family enum values (gemma, llama, imagen, veo) that are not present in the config schema; either add those values to the model_family enum in the config schema (transports/config.schema.json) if they are intended to be supported, or remove them from the documented enum list in docs/providers/aliasing-models.mdx so the docs match the model_family enum; update whichever side you choose so the model_family enum values are consistent across the schema and the docs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@docs/providers/aliasing-models.mdx`:
- Line 100: The docs list extra model_family enum values (gemma, llama, imagen,
veo) that are not present in the config schema; either add those values to the
model_family enum in the config schema (transports/config.schema.json) if they
are intended to be supported, or remove them from the documented enum list in
docs/providers/aliasing-models.mdx so the docs match the model_family enum;
update whichever side you choose so the model_family enum values are consistent
across the schema and the docs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7c047396-2fc8-4f49-869d-4ace6c857318
📒 Files selected for processing (3)
docs/deployment-guides/config-json/providers.mdxdocs/providers/aliasing-models.mdxdocs/providers/custom-pricing.mdx
5f44a42 to
ff3bf4c
Compare
9c205fc to
7a1db52
Compare
69e5dd3 to
cf9c97e
Compare
7a1db52 to
8b0687e
Compare
cf9c97e to
b90517b
Compare
8b0687e to
66de756
Compare
b90517b to
8011af6
Compare
66de756 to
0f279de
Compare
Merge activity
|

Summary
Documents the rich object form for alias entries, the new
routing_inforesponse block, and the pricing lookup precedence that uses canonicalmodel_nameto resolve opaque wire identifiers against the catalog.Changes
model_id,model_name,model_family,description,region, and provider-specific overrides for Azure, Vertex, Bedrock, and Replicate), including a field reference table and validation rules for provider mismatchextra_fieldsresponse fields (original_model_requested,resolved_model_used,provider) with the structuredrouting_infoblock; deprecated fields are noted as still populated for backward compatibilitymodel_namebefore the wiremodel_idand the caller-sent modelType of change
Affected areas
How to test
Review the rendered docs pages for:
docs/deployment-guides/config-json/providers.mdx— confirm the new<Note>appears after the Azure credential exampledocs/providers/aliasing-models.mdx— confirm the alias object schema table, provider-specific overrides table, updatedrouting_inforesponse example, and deprecation note all render correctlydocs/providers/custom-pricing.mdx— confirm the new "Lookup precedence" section appears between the wildcard patterns section and the request type filtering sectionBreaking changes
The deprecated
extra_fieldstop-level fields (original_model_requested,resolved_model_used,provider) remain populated, so existing consumers are unaffected.Related issues
Security considerations
None.
Checklist
docs/contributing/README.mdand followed the guidelinesSummary by CodeRabbit