-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add per-alias Replicate use deployments override and provider-scoped alias sub-config validation #4018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1438,3 +1438,4 @@ func TestReplicateToBifrostResponsesResponse(t *testing.T) { | |
| }) | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| package replicate | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| "github.com/maximhq/bifrost/core/schemas" | ||
| ) | ||
|
|
||
| // TestUseDeploymentsEndpoint_AliasOverride verifies the per-alias | ||
| // ReplicateAliasCfg.UseDeploymentsEndpoint override resolves correctly: | ||
| // alias value wins when set, else falls through to key-level config. | ||
| func TestUseDeploymentsEndpoint_AliasOverride(t *testing.T) { | ||
| keyDeployments := schemas.Key{ | ||
| ReplicateKeyConfig: &schemas.ReplicateKeyConfig{UseDeploymentsEndpoint: true}, | ||
| } | ||
| keyPredictions := schemas.Key{ | ||
| ReplicateKeyConfig: &schemas.ReplicateKeyConfig{UseDeploymentsEndpoint: false}, | ||
| } | ||
|
|
||
| // No alias in ctx — falls back to key-level setting. | ||
| if got := useDeploymentsEndpoint(nil, keyDeployments); !got { | ||
| t.Errorf("nil ctx + key=deployments: want true, got false") | ||
| } | ||
| if got := useDeploymentsEndpoint(nil, keyPredictions); got { | ||
| t.Errorf("nil ctx + key=predictions: want false, got true") | ||
| } | ||
| if got := useDeploymentsEndpoint(nil, schemas.Key{}); got { | ||
| t.Errorf("nil ctx + nil ReplicateKeyConfig: want false, got true") | ||
| } | ||
|
|
||
| // Alias override true wins over key=false. | ||
| ctxOverrideTrue := schemas.NewBifrostContext(context.Background(), schemas.NoDeadline) | ||
| defer ctxOverrideTrue.Cancel() | ||
| trueVal := true | ||
| ctxOverrideTrue.SetValue(schemas.BifrostContextKeyResolvedAlias, &schemas.ResolvedAlias{ | ||
| Key: "prod-llm", | ||
| Config: &schemas.AliasConfig{ | ||
| ModelID: "owner/name:version", | ||
| ReplicateAliasCfg: &schemas.ReplicateAliasCfg{ | ||
| UseDeploymentsEndpoint: &trueVal, | ||
| }, | ||
| }, | ||
| }) | ||
| if got := useDeploymentsEndpoint(ctxOverrideTrue, keyPredictions); !got { | ||
| t.Errorf("alias=true should override key=false: got false") | ||
| } | ||
|
|
||
| // Alias override false wins over key=true. | ||
| ctxOverrideFalse := schemas.NewBifrostContext(context.Background(), schemas.NoDeadline) | ||
| defer ctxOverrideFalse.Cancel() | ||
| falseVal := false | ||
| ctxOverrideFalse.SetValue(schemas.BifrostContextKeyResolvedAlias, &schemas.ResolvedAlias{ | ||
| Key: "experimental-llm", | ||
| Config: &schemas.AliasConfig{ | ||
| ModelID: "owner/name:version", | ||
| ReplicateAliasCfg: &schemas.ReplicateAliasCfg{ | ||
| UseDeploymentsEndpoint: &falseVal, | ||
| }, | ||
| }, | ||
| }) | ||
| if got := useDeploymentsEndpoint(ctxOverrideFalse, keyDeployments); got { | ||
| t.Errorf("alias=false should override key=true: got true") | ||
| } | ||
|
|
||
| // Alias present but ReplicateAliasCfg unset — falls through to key. | ||
| ctxNoCfg := schemas.NewBifrostContext(context.Background(), schemas.NoDeadline) | ||
| defer ctxNoCfg.Cancel() | ||
| ctxNoCfg.SetValue(schemas.BifrostContextKeyResolvedAlias, &schemas.ResolvedAlias{ | ||
| Key: "x", | ||
| Config: &schemas.AliasConfig{ModelID: "x"}, | ||
| }) | ||
| if got := useDeploymentsEndpoint(ctxNoCfg, keyDeployments); !got { | ||
| t.Errorf("no alias cfg + key=deployments: want true, got false") | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.