fix: use fixed table layout and constrain column widths in HeadersTable - #3952
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR updates ChangesTable layout and column spacing
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Confidence Score: 5/5Safe to merge — the change is isolated to visual layout classes with no logic, data flow, or test attribute modifications. Only Tailwind utility classes are touched: table-fixed, a percentage width on one column header, and padding resets on the Actions column. No data-testid attributes are removed or altered, no component logic changes, and no new dependencies are introduced. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix: layout shift in headers table durin..." | Re-trigger Greptile |
9bc64df to
b336353
Compare
4318c76 to
2eb2615
Compare
Merge activity
|
…le (#3952) ## Summary Fixes layout issues in the `HeadersTable` component where columns were not properly constrained, causing inconsistent sizing of the Name, Value, and Actions columns. ## Changes - Applied `table-fixed` layout to the table to enforce column width constraints - Set the Name column to a fixed width of 40% to ensure consistent proportions between Name and Value columns - Reduced the Actions column width from `w-12` to `w-10` and removed excess padding (`p-0`) to tighten the delete button column - Removed padding from the Actions cell to better align the delete button within its column ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test Navigate to any view that renders the `HeadersTable` component (e.g., a request headers configuration panel) and verify: 1. The Name and Value columns maintain consistent proportions as rows are added or removed. 2. The Actions (delete) column remains compact and does not expand unexpectedly. 3. Long header names or values do not cause the table layout to shift. ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` ## Screenshots/Recordings Add before/after screenshots showing the corrected column widths in the headers table. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * Implemented fixed table layout to ensure consistent column widths and improved visual stability. * Refined header and action column sizing for better alignment and visual consistency. * Optimized spacing in the actions column for improved usability of row control buttons. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…le (#3952) ## Summary Fixes layout issues in the `HeadersTable` component where columns were not properly constrained, causing inconsistent sizing of the Name, Value, and Actions columns. ## Changes - Applied `table-fixed` layout to the table to enforce column width constraints - Set the Name column to a fixed width of 40% to ensure consistent proportions between Name and Value columns - Reduced the Actions column width from `w-12` to `w-10` and removed excess padding (`p-0`) to tighten the delete button column - Removed padding from the Actions cell to better align the delete button within its column ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test Navigate to any view that renders the `HeadersTable` component (e.g., a request headers configuration panel) and verify: 1. The Name and Value columns maintain consistent proportions as rows are added or removed. 2. The Actions (delete) column remains compact and does not expand unexpectedly. 3. Long header names or values do not cause the table layout to shift. ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` ## Screenshots/Recordings Add before/after screenshots showing the corrected column widths in the headers table. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * Implemented fixed table layout to ensure consistent column widths and improved visual stability. * Refined header and action column sizing for better alignment and visual consistency. * Optimized spacing in the actions column for improved usability of row control buttons. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…le (#3952) ## Summary Fixes layout issues in the `HeadersTable` component where columns were not properly constrained, causing inconsistent sizing of the Name, Value, and Actions columns. ## Changes - Applied `table-fixed` layout to the table to enforce column width constraints - Set the Name column to a fixed width of 40% to ensure consistent proportions between Name and Value columns - Reduced the Actions column width from `w-12` to `w-10` and removed excess padding (`p-0`) to tighten the delete button column - Removed padding from the Actions cell to better align the delete button within its column ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test Navigate to any view that renders the `HeadersTable` component (e.g., a request headers configuration panel) and verify: 1. The Name and Value columns maintain consistent proportions as rows are added or removed. 2. The Actions (delete) column remains compact and does not expand unexpectedly. 3. Long header names or values do not cause the table layout to shift. ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` ## Screenshots/Recordings Add before/after screenshots showing the corrected column widths in the headers table. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * Implemented fixed table layout to ensure consistent column widths and improved visual stability. * Refined header and action column sizing for better alignment and visual consistency. * Optimized spacing in the actions column for improved usability of row control buttons. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…le (maximhq#3952) ## Summary Fixes layout issues in the `HeadersTable` component where columns were not properly constrained, causing inconsistent sizing of the Name, Value, and Actions columns. ## Changes - Applied `table-fixed` layout to the table to enforce column width constraints - Set the Name column to a fixed width of 40% to ensure consistent proportions between Name and Value columns - Reduced the Actions column width from `w-12` to `w-10` and removed excess padding (`p-0`) to tighten the delete button column - Removed padding from the Actions cell to better align the delete button within its column ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test Navigate to any view that renders the `HeadersTable` component (e.g., a request headers configuration panel) and verify: 1. The Name and Value columns maintain consistent proportions as rows are added or removed. 2. The Actions (delete) column remains compact and does not expand unexpectedly. 3. Long header names or values do not cause the table layout to shift. ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` ## Screenshots/Recordings Add before/after screenshots showing the corrected column widths in the headers table. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * Implemented fixed table layout to ensure consistent column widths and improved visual stability. * Refined header and action column sizing for better alignment and visual consistency. * Optimized spacing in the actions column for improved usability of row control buttons. <!-- end of auto-generated comment: release notes by coderabbit.ai -->

Summary
Fixes layout issues in the
HeadersTablecomponent where columns were not properly constrained, causing inconsistent sizing of the Name, Value, and Actions columns.Changes
table-fixedlayout to the table to enforce column width constraintsw-12tow-10and removed excess padding (p-0) to tighten the delete button columnType of change
Affected areas
How to test
Navigate to any view that renders the
HeadersTablecomponent (e.g., a request headers configuration panel) and verify:Screenshots/Recordings
Add before/after screenshots showing the corrected column widths in the headers table.
Breaking changes
Related issues
Security considerations
None.
Checklist
docs/contributing/README.mdand followed the guidelinesSummary by CodeRabbit