Skip to content

changelogs - #3923

Merged
akshaydeo merged 1 commit into
devfrom
05-31-changelogs
May 31, 2026
Merged

changelogs#3923
akshaydeo merged 1 commit into
devfrom
05-31-changelogs

Conversation

@akshaydeo

@akshaydeo akshaydeo commented May 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the redundant changelog header and version label from cli/changelog.md and fixes a missing newline at the end of the file.

Changes

  • Removed the # Bifrost CLI Changelog heading and ## v0.10.5 version label from the top of the changelog
  • Added a trailing newline to the final line of the file to resolve the "no newline at end of file" issue

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Verify the changelog renders correctly and that no trailing newline warning appears in diff tooling.

cat -A cli/changelog.md | tail -5

The last line should end with $ (indicating a proper newline terminator).

Screenshots/Recordings

N/A

Breaking changes

  • Yes
  • No

Related issues

N/A

Security considerations

None.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

Summary by CodeRabbit

Release Notes

  • Documentation
    • Updated changelog to document CLI command overlay improvements enabling arrow key navigation in tab popups.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 70b62df2-f02c-4fd1-9c5f-8b85a927593f

📥 Commits

Reviewing files that changed from the base of the PR and between 2f5c041 and 5ddb287.

📒 Files selected for processing (1)
  • cli/changelog.md

📝 Walkthrough

Walkthrough

The changelog file is updated with a single fix entry documenting that arrow-key escape sequences are now mapped to the existing h/j/k/l keyboard navigation in the CLI command overlay, enabling cursor keys to navigate the tab popup. The entry replaces prior incorrect placement.

Changes

Changelog documentation

Layer / File(s) Summary
Arrow-key navigation fix entry
cli/changelog.md
Fix entry added to changelog documenting arrow-key escape sequence mapping to hjkl navigation for CLI command overlay tab popup navigation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • danpiths

Poem

🐰 A changelog hops with glee,
Arrow keys now dance with hjkl harmony,
The command overlay knows the way,
Navigation blessed and here to stay! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The linked issue #123 concerns Files API Support for providers, which is completely unrelated to the changelog formatting changes in this PR. Either link this PR to relevant issues about changelog maintenance, or clarify why issue #123 about Files API is associated with this changelog-only PR.
Title check ❓ Inconclusive The title 'changelogs' is vague and generic, using a non-descriptive term that doesn't convey meaningful information about the specific changelog changes made. Use a more specific title such as 'Fix CLI changelog formatting and trailing newline' to clearly describe the actual changes made.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description is well-structured and follows the template with all major sections completed including Summary, Changes, Type of change, Affected areas, How to test, Breaking changes, and Checklist.
Out of Scope Changes check ✅ Passed The PR changes are strictly limited to changelog file updates (removing headers, fixing trailing newlines), which aligns with the stated objectives of updating documentation formatting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 05-31-changelogs

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akshaydeo
akshaydeo marked this pull request as ready for review May 31, 2026 08:31

akshaydeo commented May 31, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 31, 8:32 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 31, 8:32 AM UTC: @akshaydeo merged this pull request with Graphite.

@greptile-apps

greptile-apps Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Documentation-only change; no code is modified and there is no runtime impact.

The only change is removing the changelog header and version marker from a markdown file, plus a missing trailing newline. No code, tests, or configuration are affected.

cli/changelog.md — confirm the missing version header is intentional and restore the trailing newline.

Important Files Changed

Filename Overview
cli/changelog.md Removes the top-level # Bifrost CLI Changelog header and ## v0.10.5 version section marker, leaving bare bullet entries with no version attribution. Also drops the trailing newline from the last line.

Reviews (1): Last reviewed commit: "changelogs" | Re-trigger Greptile

Comment thread cli/changelog.md
- improvement: hides the Bifrost logo when re-entering the harness/model/worktree phases from the summary, giving editing flows more vertical space
- fix: tab command-mode key handling now correctly distinguishes `Enter` (activate the selected row) from `Esc`/prefix (resume the active tab), and recognises both `Ctrl+B` and `Ctrl+G` as the dismiss key
- fix: arrow-key escape sequences are now mapped to the existing `h`/`j`/`k`/`l` navigation in the command overlay, so users can navigate the tab popup with cursor keys
- fix: arrow-key escape sequences are now mapped to the existing `h`/`j`/`k`/`l` navigation in the command overlay, so users can navigate the tab popup with cursor keys No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The file is missing a trailing newline. POSIX convention requires text files to end with a newline, and many tools (cat, diff, wc -l) behave unexpectedly without one. The diff itself flags this with \ No newline at end of file.

Suggested change
- fix: arrow-key escape sequences are now mapped to the existing `h`/`j`/`k`/`l` navigation in the command overlay, so users can navigate the tab popup with cursor keys
- fix: arrow-key escape sequences are now mapped to the existing `h`/`j`/`k`/`l` navigation in the command overlay, so users can navigate the tab popup with cursor keys

@akshaydeo
akshaydeo merged commit d4c96b8 into dev May 31, 2026
13 of 15 checks passed
@akshaydeo
akshaydeo deleted the 05-31-changelogs branch May 31, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants