-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: default Anthropic tool_use input to {} when arguments are absent
#3880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
akshaydeo
merged 2 commits into
dev
from
05-29-fix_placeholder_for_tool_arguments_in_anthropic_responses
May 29, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,155 @@ | ||
| package anthropic | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| "github.com/maximhq/bifrost/core/schemas" | ||
| ) | ||
|
|
||
| // TestConvertBifrostFunctionCallToAnthropicToolUse_Input verifies that the | ||
| // tool_use block always carries an "input" object, defaulting to "{}" when the | ||
| // function call has nil or empty arguments (tools that take no arguments). | ||
| func TestConvertBifrostFunctionCallToAnthropicToolUse_Input(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| ctx, cancel := schemas.NewBifrostContextWithCancel(context.Background()) | ||
| defer cancel() | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| arguments *string | ||
| wantInput string | ||
| }{ | ||
| {name: "nil arguments", arguments: nil, wantInput: "{}"}, | ||
| {name: "empty arguments", arguments: schemas.Ptr(""), wantInput: "{}"}, | ||
| {name: "populated arguments", arguments: schemas.Ptr(`{"foo":"bar"}`), wantInput: `{"foo":"bar"}`}, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| msg := &schemas.ResponsesMessage{ | ||
| Type: schemas.Ptr(schemas.ResponsesMessageTypeFunctionCall), | ||
| ResponsesToolMessage: &schemas.ResponsesToolMessage{ | ||
| CallID: schemas.Ptr("toolu_fn_test"), | ||
| Name: schemas.Ptr("get_workspace_id"), | ||
| Arguments: tt.arguments, | ||
| }, | ||
| } | ||
|
|
||
| block := convertBifrostFunctionCallToAnthropicToolUse(ctx, msg) | ||
| if block == nil { | ||
| t.Fatal("expected non-nil tool_use block") | ||
| } | ||
| if block.Type != AnthropicContentBlockTypeToolUse { | ||
| t.Errorf("block.Type = %v, want %v", block.Type, AnthropicContentBlockTypeToolUse) | ||
| } | ||
| if block.Input == nil { | ||
| t.Fatal("expected non-nil Input") | ||
| } | ||
| if string(block.Input) != tt.wantInput { | ||
| t.Errorf("Input = %s, want %s", block.Input, tt.wantInput) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| // TestConvertBifrostMCPCallToAnthropicToolUse_Input verifies that the | ||
| // mcp_tool_use block always carries an "input" object, defaulting to "{}" when | ||
| // the MCP call has nil or empty arguments. | ||
| func TestConvertBifrostMCPCallToAnthropicToolUse_Input(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| arguments *string | ||
| wantInput string | ||
| }{ | ||
| {name: "nil arguments", arguments: nil, wantInput: "{}"}, | ||
| {name: "empty arguments", arguments: schemas.Ptr(""), wantInput: "{}"}, | ||
| {name: "populated arguments", arguments: schemas.Ptr(`{"foo":"bar"}`), wantInput: `{"foo":"bar"}`}, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| msg := &schemas.ResponsesMessage{ | ||
| ID: schemas.Ptr("mcp_call_test"), | ||
| Type: schemas.Ptr(schemas.ResponsesMessageTypeMCPCall), | ||
| ResponsesToolMessage: &schemas.ResponsesToolMessage{ | ||
| Name: schemas.Ptr("maximsse-get-maxim-workspace-id"), | ||
| Arguments: tt.arguments, | ||
| ResponsesMCPToolCall: &schemas.ResponsesMCPToolCall{ | ||
| ServerLabel: "maximsse", | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| block := convertBifrostMCPCallToAnthropicToolUse(msg) | ||
| if block == nil { | ||
| t.Fatal("expected non-nil mcp_tool_use block") | ||
| } | ||
| if block.Type != AnthropicContentBlockTypeMCPToolUse { | ||
| t.Errorf("block.Type = %v, want %v", block.Type, AnthropicContentBlockTypeMCPToolUse) | ||
| } | ||
| if block.Input == nil { | ||
| t.Fatal("expected non-nil Input") | ||
| } | ||
| if string(block.Input) != tt.wantInput { | ||
| t.Errorf("Input = %s, want %s", block.Input, tt.wantInput) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| // TestConvertBifrostMCPApprovalToAnthropicToolUse_Input verifies that the | ||
| // mcp_tool_use block produced for an MCP approval request always carries an | ||
| // "input" object, defaulting to "{}" when arguments are nil or empty. | ||
| func TestConvertBifrostMCPApprovalToAnthropicToolUse_Input(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| arguments *string | ||
| wantInput string | ||
| }{ | ||
| {name: "nil arguments", arguments: nil, wantInput: "{}"}, | ||
| {name: "empty arguments", arguments: schemas.Ptr(""), wantInput: "{}"}, | ||
| {name: "populated arguments", arguments: schemas.Ptr(`{"foo":"bar"}`), wantInput: `{"foo":"bar"}`}, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| msg := &schemas.ResponsesMessage{ | ||
| ID: schemas.Ptr("mcp_approval_test"), | ||
| Type: schemas.Ptr(schemas.ResponsesMessageTypeMCPApprovalRequest), | ||
| ResponsesToolMessage: &schemas.ResponsesToolMessage{ | ||
| Name: schemas.Ptr("maximsse-get-maxim-workspace-id"), | ||
| Arguments: tt.arguments, | ||
| ResponsesMCPToolCall: &schemas.ResponsesMCPToolCall{ | ||
| ServerLabel: "maximsse", | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| block := convertBifrostMCPApprovalToAnthropicToolUse(msg) | ||
| if block == nil { | ||
| t.Fatal("expected non-nil mcp_tool_use block") | ||
| } | ||
| if block.Type != AnthropicContentBlockTypeMCPToolUse { | ||
| t.Errorf("block.Type = %v, want %v", block.Type, AnthropicContentBlockTypeMCPToolUse) | ||
| } | ||
| if block.Input == nil { | ||
| t.Fatal("expected non-nil Input") | ||
| } | ||
| if string(block.Input) != tt.wantInput { | ||
| t.Errorf("Input = %s, want %s", block.Input, tt.wantInput) | ||
| } | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.