fix: remove max-width constraint, add className prop to FullPageLoader, and fix tool call border placement - #3866
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree UI tweaks: FullPageLoader accepts an optional ChangesUI Refinements and Component Property Enhancements
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
b433f97 to
4dfb3c7
Compare
Confidence Score: 5/5Safe to merge — all changes are isolated styling adjustments with no logic, data flow, or API surface modifications. The three changed files touch only Tailwind class strings and a single optional prop addition. No business logic, state management, or component contracts are altered, and existing data-testid attributes on interactive elements remain untouched. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix: ui nitpicks" | Re-trigger Greptile |
4dfb3c7 to
3488e40
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Merge activity
|
…r, and fix tool call border placement (#3866) ## Summary Minor UI polish fixes addressing layout constraints, component flexibility, and visual border placement in the tool call view. ## Changes - Removed `max-w-7xl` constraint from the Governance Virtual Keys page container, allowing it to expand to full width - Made `FullPageLoader` accept an optional `className` prop for external style overrides - Removed the bottom border from the tool call header and moved the border to the top of the arguments section, so the divider only appears when arguments are present - Reordered imports in two files to follow consistent ordering conventions ## Type of change - [x] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` 1. Navigate to the Governance → Virtual Keys page and verify the table expands to full page width without a max-width cap. 2. Open a prompt with tool calls that have no arguments and confirm no stray border appears in the tool call card header. 3. Open a prompt with tool calls that do have arguments and confirm the divider border appears above the arguments section. ## Screenshots/Recordings Before/after screenshots of the Virtual Keys page width and tool call card borders recommended. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * Refined layout styling on the virtual keys governance page to change content max-width behavior for improved responsive flow. * Adjusted visual dividers in tool-call cards to improve separation between header and arguments sections. * **Other Changes** * Full-page loader now supports optional custom class names to allow easier styling customization. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/maximhq/bifrost/pull/3866?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…r, and fix tool call border placement (maximhq#3866) ## Summary Minor UI polish fixes addressing layout constraints, component flexibility, and visual border placement in the tool call view. ## Changes - Removed `max-w-7xl` constraint from the Governance Virtual Keys page container, allowing it to expand to full width - Made `FullPageLoader` accept an optional `className` prop for external style overrides - Removed the bottom border from the tool call header and moved the border to the top of the arguments section, so the divider only appears when arguments are present - Reordered imports in two files to follow consistent ordering conventions ## Type of change - [x] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` 1. Navigate to the Governance → Virtual Keys page and verify the table expands to full page width without a max-width cap. 2. Open a prompt with tool calls that have no arguments and confirm no stray border appears in the tool call card header. 3. Open a prompt with tool calls that do have arguments and confirm the divider border appears above the arguments section. ## Screenshots/Recordings Before/after screenshots of the Virtual Keys page width and tool call card borders recommended. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * Refined layout styling on the virtual keys governance page to change content max-width behavior for improved responsive flow. * Adjusted visual dividers in tool-call cards to improve separation between header and arguments sections. * **Other Changes** * Full-page loader now supports optional custom class names to allow easier styling customization. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/maximhq/bifrost/pull/3866?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…r, and fix tool call border placement (maximhq#3866) ## Summary Minor UI polish fixes addressing layout constraints, component flexibility, and visual border placement in the tool call view. ## Changes - Removed `max-w-7xl` constraint from the Governance Virtual Keys page container, allowing it to expand to full width - Made `FullPageLoader` accept an optional `className` prop for external style overrides - Removed the bottom border from the tool call header and moved the border to the top of the arguments section, so the divider only appears when arguments are present - Reordered imports in two files to follow consistent ordering conventions ## Type of change - [x] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` 1. Navigate to the Governance → Virtual Keys page and verify the table expands to full page width without a max-width cap. 2. Open a prompt with tool calls that have no arguments and confirm no stray border appears in the tool call card header. 3. Open a prompt with tool calls that do have arguments and confirm the divider border appears above the arguments section. ## Screenshots/Recordings Before/after screenshots of the Virtual Keys page width and tool call card borders recommended. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * Refined layout styling on the virtual keys governance page to change content max-width behavior for improved responsive flow. * Adjusted visual dividers in tool-call cards to improve separation between header and arguments sections. * **Other Changes** * Full-page loader now supports optional custom class names to allow easier styling customization. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/maximhq/bifrost/pull/3866?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->

Summary
Minor UI polish fixes addressing layout constraints, component flexibility, and visual border placement in the tool call view.
Changes
max-w-7xlconstraint from the Governance Virtual Keys page container, allowing it to expand to full widthFullPageLoaderaccept an optionalclassNameprop for external style overridesType of change
Affected areas
How to test
Screenshots/Recordings
Before/after screenshots of the Virtual Keys page width and tool call card borders recommended.
Breaking changes
Related issues
Security considerations
None.
Checklist
docs/contributing/README.mdand followed the guidelinesSummary by CodeRabbit
Style
Other Changes