Skip to content

fix: remove max-width constraint, add className prop to FullPageLoader, and fix tool call border placement - #3866

Merged
akshaydeo merged 1 commit into
devfrom
05-29-fix_ui_nitpicks
May 29, 2026
Merged

akshaydeo merged 1 commit into
devfrom
05-29-fix_ui_nitpicks

Conversation

@impoiler

@impoiler impoiler commented May 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Minor UI polish fixes addressing layout constraints, component flexibility, and visual border placement in the tool call view.

Changes

  • Removed max-w-7xl constraint from the Governance Virtual Keys page container, allowing it to expand to full width
  • Made FullPageLoader accept an optional className prop for external style overrides
  • Removed the bottom border from the tool call header and moved the border to the top of the arguments section, so the divider only appears when arguments are present
  • Reordered imports in two files to follow consistent ordering conventions

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

cd ui
pnpm i || npm i
pnpm build || npm run build
  1. Navigate to the Governance → Virtual Keys page and verify the table expands to full page width without a max-width cap.
  2. Open a prompt with tool calls that have no arguments and confirm no stray border appears in the tool call card header.
  3. Open a prompt with tool calls that do have arguments and confirm the divider border appears above the arguments section.

Screenshots/Recordings

Before/after screenshots of the Virtual Keys page width and tool call card borders recommended.

Breaking changes

  • Yes
  • No

Related issues

Security considerations

None.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

Summary by CodeRabbit

  • Style

    • Refined layout styling on the virtual keys governance page to change content max-width behavior for improved responsive flow.
    • Adjusted visual dividers in tool-call cards to improve separation between header and arguments sections.
  • Other Changes

    • Full-page loader now supports optional custom class names to allow easier styling customization.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a15fce5a-9973-4579-ad53-21831c412f3b

📥 Commits

Reviewing files that changed from the base of the PR and between 4dfb3c7 and 3488e40.

📒 Files selected for processing (3)
  • ui/app/workspace/governance/virtual-keys/page.tsx
  • ui/components/fullPageLoader.tsx
  • ui/components/prompts/components/messagesView/toolCallView.tsx

📝 Walkthrough

Walkthrough

Three UI tweaks: FullPageLoader accepts an optional className merged via cn, the virtual-keys page container had max-w-7xl removed (keeping min-h-0 w-full), and the tool-call view had import reordering plus header/arguments border adjustments.

Changes

UI Refinements and Component Property Enhancements

Layer / File(s) Summary
FullPageLoader className prop
ui/components/fullPageLoader.tsx
FullPageLoader now accepts an optional { className?: string } prop; cn is imported and used to merge the provided className with the component's default wrapper classes.
Virtual keys page container layout
ui/app/workspace/governance/virtual-keys/page.tsx
Import order adjusted to place parseAsSafeString before store/RBAC imports; outer page container Tailwind classes removed max-w-7xl, leaving min-h-0 w-full and existing flex/overflow/padding classes.
Tool call view border styling
ui/components/prompts/components/messagesView/toolCallView.tsx
Import block reordered to group MCPAuthRequiredError earlier; the tool-call card header's border-b class was removed and the "Arguments" section gained a border-t class to reposition the visual divider.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • maximhq/bifrost#3665: Modifies the same ui/app/workspace/governance/virtual-keys/page.tsx outer container Tailwind layout/width behavior.

Suggested reviewers

  • akshaydeo
  • danpiths
  • Pratham-Mishra04

Poem

🐰 I stitched a class and trimmed a bound,
A loader wears new styles profound,
Borders moved a gentle beat—
Small hops, tidy UI feet.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the three main changes in the changeset: removing max-width constraint, adding className prop to FullPageLoader, and fixing tool call border placement.
Description check ✅ Passed The description includes a clear summary, detailed changes, correct type selection, affected areas, testing steps, and answers all template sections adequately.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 05-29-fix_ui_nitpicks

Comment @coderabbitai help to get the list of available commands and usage tips.

@impoiler
impoiler force-pushed the 05-29-fix_ui_nitpicks branch 2 times, most recently from b433f97 to 4dfb3c7 Compare May 29, 2026 06:39
@impoiler impoiler changed the title fix: ui nitpicks fix: remove max-width constraint, add className prop to FullPageLoader, and fix tool call border placement May 29, 2026
@impoiler impoiler self-assigned this May 29, 2026
@impoiler
impoiler marked this pull request as ready for review May 29, 2026 07:06
@greptile-apps

greptile-apps Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — all changes are isolated styling adjustments with no logic, data flow, or API surface modifications.

The three changed files touch only Tailwind class strings and a single optional prop addition. No business logic, state management, or component contracts are altered, and existing data-testid attributes on interactive elements remain untouched.

No files require special attention.

Important Files Changed

Filename Overview
ui/app/workspace/governance/virtual-keys/page.tsx Removes max-w-7xl width cap from the page container and reorders one import; straightforward layout fix with no logic changes.
ui/components/fullPageLoader.tsx Adds an optional className prop merged via cn(); clean, backward-compatible enhancement with no regressions.
ui/components/prompts/components/messagesView/toolCallView.tsx Moves the divider border from the tool call header (border-b) to the top of the arguments section (border-t), so no stray border appears when there are no arguments; no data-testid attributes affected.

Reviews (2): Last reviewed commit: "fix: ui nitpicks" | Re-trigger Greptile

@impoiler
impoiler force-pushed the 05-29-fix_ui_nitpicks branch from 4dfb3c7 to 3488e40 Compare May 29, 2026 09:55

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

akshaydeo commented May 29, 2026

Copy link
Copy Markdown
Contributor

Merge activity

  • May 29, 10:17 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 29, 10:17 AM UTC: @akshaydeo merged this pull request with Graphite.

@akshaydeo
akshaydeo merged commit cbac0bb into dev May 29, 2026
14 checks passed
@akshaydeo
akshaydeo deleted the 05-29-fix_ui_nitpicks branch May 29, 2026 10:17
akshaydeo pushed a commit that referenced this pull request May 29, 2026
…r, and fix tool call border placement (#3866)

## Summary

Minor UI polish fixes addressing layout constraints, component flexibility, and visual border placement in the tool call view.

## Changes

- Removed `max-w-7xl` constraint from the Governance Virtual Keys page container, allowing it to expand to full width
- Made `FullPageLoader` accept an optional `className` prop for external style overrides
- Removed the bottom border from the tool call header and moved the border to the top of the arguments section, so the divider only appears when arguments are present
- Reordered imports in two files to follow consistent ordering conventions

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

```sh
cd ui
pnpm i || npm i
pnpm build || npm run build
```

1. Navigate to the Governance → Virtual Keys page and verify the table expands to full page width without a max-width cap.
2. Open a prompt with tool calls that have no arguments and confirm no stray border appears in the tool call card header.
3. Open a prompt with tool calls that do have arguments and confirm the divider border appears above the arguments section.

## Screenshots/Recordings

Before/after screenshots of the Virtual Keys page width and tool call card borders recommended.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **Style**
  * Refined layout styling on the virtual keys governance page to change content max-width behavior for improved responsive flow.
  * Adjusted visual dividers in tool-call cards to improve separation between header and arguments sections.

* **Other Changes**
  * Full-page loader now supports optional custom class names to allow easier styling customization.

<!-- review_stack_entry_start -->

[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/maximhq/bifrost/pull/3866?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)

<!-- review_stack_entry_end -->
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
akhsaul pushed a commit to akhsaul/bifrost that referenced this pull request Aug 27, 2026
…r, and fix tool call border placement (maximhq#3866)

## Summary

Minor UI polish fixes addressing layout constraints, component flexibility, and visual border placement in the tool call view.

## Changes

- Removed `max-w-7xl` constraint from the Governance Virtual Keys page container, allowing it to expand to full width
- Made `FullPageLoader` accept an optional `className` prop for external style overrides
- Removed the bottom border from the tool call header and moved the border to the top of the arguments section, so the divider only appears when arguments are present
- Reordered imports in two files to follow consistent ordering conventions

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

```sh
cd ui
pnpm i || npm i
pnpm build || npm run build
```

1. Navigate to the Governance → Virtual Keys page and verify the table expands to full page width without a max-width cap.
2. Open a prompt with tool calls that have no arguments and confirm no stray border appears in the tool call card header.
3. Open a prompt with tool calls that do have arguments and confirm the divider border appears above the arguments section.

## Screenshots/Recordings

Before/after screenshots of the Virtual Keys page width and tool call card borders recommended.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **Style**
  * Refined layout styling on the virtual keys governance page to change content max-width behavior for improved responsive flow.
  * Adjusted visual dividers in tool-call cards to improve separation between header and arguments sections.

* **Other Changes**
  * Full-page loader now supports optional custom class names to allow easier styling customization.

<!-- review_stack_entry_start -->

[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/maximhq/bifrost/pull/3866?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)

<!-- review_stack_entry_end -->
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
occcat pushed a commit to occcat/bifrost that referenced this pull request Sep 2, 2026
…r, and fix tool call border placement (maximhq#3866)

## Summary

Minor UI polish fixes addressing layout constraints, component flexibility, and visual border placement in the tool call view.

## Changes

- Removed `max-w-7xl` constraint from the Governance Virtual Keys page container, allowing it to expand to full width
- Made `FullPageLoader` accept an optional `className` prop for external style overrides
- Removed the bottom border from the tool call header and moved the border to the top of the arguments section, so the divider only appears when arguments are present
- Reordered imports in two files to follow consistent ordering conventions

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

```sh
cd ui
pnpm i || npm i
pnpm build || npm run build
```

1. Navigate to the Governance → Virtual Keys page and verify the table expands to full page width without a max-width cap.
2. Open a prompt with tool calls that have no arguments and confirm no stray border appears in the tool call card header.
3. Open a prompt with tool calls that do have arguments and confirm the divider border appears above the arguments section.

## Screenshots/Recordings

Before/after screenshots of the Virtual Keys page width and tool call card borders recommended.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **Style**
  * Refined layout styling on the virtual keys governance page to change content max-width behavior for improved responsive flow.
  * Adjusted visual dividers in tool-call cards to improve separation between header and arguments sections.

* **Other Changes**
  * Full-page loader now supports optional custom class names to allow easier styling customization.

<!-- review_stack_entry_start -->

[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/maximhq/bifrost/pull/3866?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)

<!-- review_stack_entry_end -->
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants