chore: bump Bifrost Helm chart to 2.1.20 with authServerType and attribute mapping schema fixes - #3857
Merged
Conversation
Contributor
|
Warning Review limit reached
More reviews will be available in 9 minutes and 8 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughBifrost Helm chart 2.1.20: chart/version updated, README and index entry added; Helm values.schema and runtime transports config schema add Okta ChangesBifrost 2.1.20 Release and Okta Schema
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
BearTS
marked this pull request as ready for review
May 28, 2026 16:41
BearTS
changed the title
authServerType and attribute mapping schema fixes
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Confidence Score: 5/5Safe to merge — changes are limited to JSON schema files and documentation with no runtime logic modifications. All changes are additive schema fixes that unblock already-documented Okta fields. Both schemas are consistent with each other and with the Helm pass-through template, and no Go runtime code is touched. No files require special attention, though adding test cases for the new authServerType enum and mapping arrays in config_schema_test.go would guard against future regressions. Important Files Changed
Reviews (3): Last reviewed commit: "chore: add support for okta authServerTy..." | Re-trigger Greptile |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@helm-charts/bifrost/README.md`:
- Around line 11-19: Update the MCP parameter table entry for tlsConfig (under
bifrost.mcp.clientConfigs[]) to remove the stale "[Upcoming]" status and reflect
that tlsConfig is now shipped in 2.1.20; locate the table row referencing
tlsConfig / tls_config and either delete the "[Upcoming]" tag or change it to
the shipped/available notation and ensure the description matches the changelog
(mentioning insecureSkipVerify and caCertPem mapping to
tls_config.insecure_skip_verify and tls_config.ca_cert_pem).
In `@helm-charts/index.yaml`:
- Around line 4-27: The root "generated" timestamp in helm-charts/index.yaml is
stale relative to the new release entry (name: bifrost, version: 2.1.20,
created: 2026-05-28...), so regenerate the index so the top-level "generated"
field is updated to reflect the new entry; re-run the index generation used for
this repo (e.g., the helm/chart index generator or CI job that produces
index.yaml) so the "generated" timestamp is >= the bifrost 2.1.20 created time
and the file metadata is consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 6bf839b4-b376-4a0f-bb46-b37a6bf1d344
📒 Files selected for processing (6)
helm-charts/bifrost/Chart.yamlhelm-charts/bifrost/README.mdhelm-charts/bifrost/values.schema.jsonhelm-charts/bifrost/values.yamlhelm-charts/index.yamltransports/config.schema.json
BearTS
force-pushed
the
05-28-chore_add_support_for_okta_authservertype
branch
from
May 28, 2026 16:54
2e401c8 to
161cc7e
Compare
Contributor
|
Actionable comments posted: 0 |
BearTS
force-pushed
the
05-28-chore_add_support_for_okta_authservertype
branch
from
May 28, 2026 17:07
161cc7e to
a043a1a
Compare
akshaydeo
approved these changes
May 28, 2026
Contributor
Merge activity
|
akshaydeo
pushed a commit
that referenced
this pull request
May 29, 2026
…tribute mapping schema fixes (#3857) ## Summary Bumps the Bifrost Helm chart to version `2.1.20`, fixing schema gaps in the Okta SCIM/SSO configuration that caused valid fields to be rejected at validation time, and aligning the transport runtime schema with the Helm chart schema. ## Changes - Added `authServerType` (`"org"` | `"custom"`, default `"org"`) to the Okta SCIM config in both `values.schema.json` and `config.schema.json`. The field was previously documented but blocked by `additionalProperties: false` in both schemas. - Added `attributeRoleMappings`, `attributeTeamMappings`, and `attributeBusinessUnitMappings` to the Okta provider branch in `config.schema.json`, bringing the transport runtime schema into parity with the Helm chart schema which already included these fields. - Exposed `authServerType` as a commented example in `values.yaml` for discoverability. - Updated `helm-charts/index.yaml` with the new `2.1.20` chart entry. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [x] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test Deploy the Helm chart with an Okta SCIM configuration that includes `authServerType: "custom"` and verify that Helm schema validation passes without `additionalProperties` errors: ```sh helm lint helm-charts/bifrost -f helm-charts/bifrost/values.yaml \ --set bifrost.scim.config.issuerUrl="https://your-domain.okta.com/oauth2/default" \ --set bifrost.scim.config.authServerType="custom" \ --set bifrost.scim.config.clientId="test" \ --set bifrost.scim.config.clientSecret="test" \ --set bifrost.scim.config.apiToken="test" ``` Validate the transport config schema against a config file that includes `authServerType`, `attributeRoleMappings`, `attributeTeamMappings`, and `attributeBusinessUnitMappings` under the Okta provider block and confirm no schema validation errors are returned. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations `authServerType` controls whether Bifrost uses the Okta Org Authorization Server or a Custom Authorization Server for token validation. The `insecureSkipVerify` TLS option (introduced in `2.1.19`) should never be used in production. No new secrets or PII handling is introduced by this change. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [x] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Support to select Okta authorization server type (org or custom). * New Okta attribute mapping options to map claim attributes to roles, teams, and business units. * **Documentation** * Helm chart and changelog updated for release 2.1.20, documenting the new Okta fields and mappings. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/maximhq/bifrost/pull/3857?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
](https://app.coderabbit.ai/change-stack/maximhq/bifrost/pull/3857?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack){kind=link}
This was referenced Jun 2, 2026
This was referenced Jun 9, 2026
akhsaul
pushed a commit
to akhsaul/bifrost
that referenced
this pull request
Aug 27, 2026
…tribute mapping schema fixes (maximhq#3857) ## Summary Bumps the Bifrost Helm chart to version `2.1.20`, fixing schema gaps in the Okta SCIM/SSO configuration that caused valid fields to be rejected at validation time, and aligning the transport runtime schema with the Helm chart schema. ## Changes - Added `authServerType` (`"org"` | `"custom"`, default `"org"`) to the Okta SCIM config in both `values.schema.json` and `config.schema.json`. The field was previously documented but blocked by `additionalProperties: false` in both schemas. - Added `attributeRoleMappings`, `attributeTeamMappings`, and `attributeBusinessUnitMappings` to the Okta provider branch in `config.schema.json`, bringing the transport runtime schema into parity with the Helm chart schema which already included these fields. - Exposed `authServerType` as a commented example in `values.yaml` for discoverability. - Updated `helm-charts/index.yaml` with the new `2.1.20` chart entry. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [x] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test Deploy the Helm chart with an Okta SCIM configuration that includes `authServerType: "custom"` and verify that Helm schema validation passes without `additionalProperties` errors: ```sh helm lint helm-charts/bifrost -f helm-charts/bifrost/values.yaml \ --set bifrost.scim.config.issuerUrl="https://your-domain.okta.com/oauth2/default" \ --set bifrost.scim.config.authServerType="custom" \ --set bifrost.scim.config.clientId="test" \ --set bifrost.scim.config.clientSecret="test" \ --set bifrost.scim.config.apiToken="test" ``` Validate the transport config schema against a config file that includes `authServerType`, `attributeRoleMappings`, `attributeTeamMappings`, and `attributeBusinessUnitMappings` under the Okta provider block and confirm no schema validation errors are returned. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations `authServerType` controls whether Bifrost uses the Okta Org Authorization Server or a Custom Authorization Server for token validation. The `insecureSkipVerify` TLS option (introduced in `2.1.19`) should never be used in production. No new secrets or PII handling is introduced by this change. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [x] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Support to select Okta authorization server type (org or custom). * New Okta attribute mapping options to map claim attributes to roles, teams, and business units. * **Documentation** * Helm chart and changelog updated for release 2.1.20, documenting the new Okta fields and mappings. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/maximhq/bifrost/pull/3857?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
occcat
pushed a commit
to occcat/bifrost
that referenced
this pull request
Sep 2, 2026
…tribute mapping schema fixes (maximhq#3857) ## Summary Bumps the Bifrost Helm chart to version `2.1.20`, fixing schema gaps in the Okta SCIM/SSO configuration that caused valid fields to be rejected at validation time, and aligning the transport runtime schema with the Helm chart schema. ## Changes - Added `authServerType` (`"org"` | `"custom"`, default `"org"`) to the Okta SCIM config in both `values.schema.json` and `config.schema.json`. The field was previously documented but blocked by `additionalProperties: false` in both schemas. - Added `attributeRoleMappings`, `attributeTeamMappings`, and `attributeBusinessUnitMappings` to the Okta provider branch in `config.schema.json`, bringing the transport runtime schema into parity with the Helm chart schema which already included these fields. - Exposed `authServerType` as a commented example in `values.yaml` for discoverability. - Updated `helm-charts/index.yaml` with the new `2.1.20` chart entry. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [x] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test Deploy the Helm chart with an Okta SCIM configuration that includes `authServerType: "custom"` and verify that Helm schema validation passes without `additionalProperties` errors: ```sh helm lint helm-charts/bifrost -f helm-charts/bifrost/values.yaml \ --set bifrost.scim.config.issuerUrl="https://your-domain.okta.com/oauth2/default" \ --set bifrost.scim.config.authServerType="custom" \ --set bifrost.scim.config.clientId="test" \ --set bifrost.scim.config.clientSecret="test" \ --set bifrost.scim.config.apiToken="test" ``` Validate the transport config schema against a config file that includes `authServerType`, `attributeRoleMappings`, `attributeTeamMappings`, and `attributeBusinessUnitMappings` under the Okta provider block and confirm no schema validation errors are returned. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations `authServerType` controls whether Bifrost uses the Okta Org Authorization Server or a Custom Authorization Server for token validation. The `insecureSkipVerify` TLS option (introduced in `2.1.19`) should never be used in production. No new secrets or PII handling is introduced by this change. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [x] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Support to select Okta authorization server type (org or custom). * New Okta attribute mapping options to map claim attributes to roles, teams, and business units. * **Documentation** * Helm chart and changelog updated for release 2.1.20, documenting the new Okta fields and mappings. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/maximhq/bifrost/pull/3857?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the Bifrost Helm chart to version
2.1.20, fixing schema gaps in the Okta SCIM/SSO configuration that caused valid fields to be rejected at validation time, and aligning the transport runtime schema with the Helm chart schema.Changes
authServerType("org"|"custom", default"org") to the Okta SCIM config in bothvalues.schema.jsonandconfig.schema.json. The field was previously documented but blocked byadditionalProperties: falsein both schemas.attributeRoleMappings,attributeTeamMappings, andattributeBusinessUnitMappingsto the Okta provider branch inconfig.schema.json, bringing the transport runtime schema into parity with the Helm chart schema which already included these fields.authServerTypeas a commented example invalues.yamlfor discoverability.helm-charts/index.yamlwith the new2.1.20chart entry.Type of change
Affected areas
How to test
Deploy the Helm chart with an Okta SCIM configuration that includes
authServerType: "custom"and verify that Helm schema validation passes withoutadditionalPropertieserrors:Validate the transport config schema against a config file that includes
authServerType,attributeRoleMappings,attributeTeamMappings, andattributeBusinessUnitMappingsunder the Okta provider block and confirm no schema validation errors are returned.Breaking changes
Related issues
Security considerations
authServerTypecontrols whether Bifrost uses the Okta Org Authorization Server or a Custom Authorization Server for token validation. TheinsecureSkipVerifyTLS option (introduced in2.1.19) should never be used in production. No new secrets or PII handling is introduced by this change.Checklist
docs/contributing/README.mdand followed the guidelinesSummary by CodeRabbit
New Features
Documentation