Skip to content

fix: handle partial tool call execution failures and return successful results - #3849

Merged
Pratham-Mishra04 merged 1 commit into
devfrom
05-28-fix_remove_crypto.uuid_to_prevent_error_on_http_contexts
May 28, 2026
Merged

fix: handle partial tool call execution failures and return successful results#3849
Pratham-Mishra04 merged 1 commit into
devfrom
05-28-fix_remove_crypto.uuid_to_prevent_error_on_http_contexts

Conversation

@impoiler

Copy link
Copy Markdown
Contributor

Summary

When executing multiple tool calls in parallel, if some succeed and others fail, the successful results were previously discarded entirely. This PR improves partial failure handling so that successful tool call results are preserved and surfaced back to the UI, allowing users to manually fill in only the failed ones.

Changes

  • handleExecuteAllToolCalls now uses Promise.allSettled instead of Promise.all, so individual failures no longer abort the entire batch.
  • On partial failure, successful results are returned to the caller instead of being immediately submitted, allowing the UI to pre-populate those responses while leaving failed ones editable.
  • The error toast now reports how many of the total tool calls failed and hints that successful results were kept when it's a partial failure.
  • onExecuteAllToolCalls return type updated from Promise<void> to Promise<{ toolCallId: string; content: string }[] | undefined> to carry partial results back to ToolCallMessageView.
  • ToolCallMessageView now handles the returned partial results by updating its local responses and resolvedIds state, so successfully executed tools appear filled in immediately.
  • Replaced crypto.randomUUID() with uuidv4() from the uuid package for consistency.

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

  1. Configure a prompt with multiple tool calls that can be executed directly.
  2. Intentionally cause one tool call to fail (e.g., misconfigure one tool's endpoint or parameters).
  3. Click "Execute All" on the tool call message.
  4. Verify that the successfully executed tools show their results pre-filled in the UI.
  5. Verify that the failed tool call(s) remain editable and a toast appears indicating how many failed.
  6. Verify that when all tool calls succeed, behavior is unchanged — results are submitted automatically.
cd ui
pnpm i || npm i
pnpm build || npm run build

Breaking changes

  • Yes
  • No

Related issues

Security considerations

None.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • ui/components/prompts/components/messagesView/toolCallView.tsx is excluded by none and included by none
  • ui/components/prompts/context.tsx is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 50de49b5-0125-4226-8014-75a478d58eca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 05-28-fix_remove_crypto.uuid_to_prevent_error_on_http_contexts

Comment @coderabbitai help to get the list of available commands and usage tips.

@impoiler impoiler self-assigned this May 28, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@impoiler
impoiler marked this pull request as ready for review May 28, 2026 14:05
@impoiler impoiler changed the title fix: handle partial tool call execution failures with Promise.allSettled fix: handle partial tool call execution failures and return successful results May 28, 2026
@greptile-apps

greptile-apps Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The change is safe to merge — it narrows the blast radius of parallel tool execution failures without altering the all-success path's observable behavior.

The logic is straightforward: Promise.allSettled guarantees no individual rejection aborts the batch, the all-success fast path is unchanged, and partial results flow cleanly through the updated return type into local component state. The two crypto.randomUUID replacements are mechanical. No data-testid attributes were removed, no cross-module contracts were broken, and error handling that was previously missing on the submit step is now wrapped in its own try/catch.

No files require special attention.

Important Files Changed

Filename Overview
ui/components/prompts/context.tsx handleExecuteAllToolCalls switched from Promise.all to Promise.allSettled; partial successes are returned to the caller; failures are reported via toast with aggregated error messages; crypto.randomUUID() replaced with uuidv4()
ui/components/prompts/components/messagesView/toolCallView.tsx handleExecuteAll now processes the returned partial result array, pre-populating responses and resolvedIds for successfully executed tools while leaving failed ones editable; return type updated accordingly

Reviews (2): Last reviewed commit: "fix: remove crypto.uuid() to prevent err..." | Re-trigger Greptile

Comment thread ui/components/prompts/context.tsx
Comment thread ui/components/prompts/context.tsx Outdated
@impoiler
impoiler force-pushed the 05-28-fix_remove_crypto.uuid_to_prevent_error_on_http_contexts branch from 4c74ff3 to 9b1712c Compare May 28, 2026 14:13

Pratham-Mishra04 commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Merge activity

  • May 28, 2:17 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 28, 2:18 PM UTC: @Pratham-Mishra04 merged this pull request with Graphite.

@Pratham-Mishra04
Pratham-Mishra04 merged commit c4d827b into dev May 28, 2026
15 checks passed
@Pratham-Mishra04
Pratham-Mishra04 deleted the 05-28-fix_remove_crypto.uuid_to_prevent_error_on_http_contexts branch May 28, 2026 14:18
akshaydeo pushed a commit that referenced this pull request May 29, 2026
…l results (#3849)

## Summary

When executing multiple tool calls in parallel, if some succeed and others fail, the successful results were previously discarded entirely. This PR improves partial failure handling so that successful tool call results are preserved and surfaced back to the UI, allowing users to manually fill in only the failed ones.

## Changes

- `handleExecuteAllToolCalls` now uses `Promise.allSettled` instead of `Promise.all`, so individual failures no longer abort the entire batch.
- On partial failure, successful results are returned to the caller instead of being immediately submitted, allowing the UI to pre-populate those responses while leaving failed ones editable.
- The error toast now reports how many of the total tool calls failed and hints that successful results were kept when it's a partial failure.
- `onExecuteAllToolCalls` return type updated from `Promise<void>` to `Promise<{ toolCallId: string; content: string }[] | undefined>` to carry partial results back to `ToolCallMessageView`.
- `ToolCallMessageView` now handles the returned partial results by updating its local `responses` and `resolvedIds` state, so successfully executed tools appear filled in immediately.
- Replaced `crypto.randomUUID()` with `uuidv4()` from the `uuid` package for consistency.

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

1. Configure a prompt with multiple tool calls that can be executed directly.
2. Intentionally cause one tool call to fail (e.g., misconfigure one tool's endpoint or parameters).
3. Click "Execute All" on the tool call message.
4. Verify that the successfully executed tools show their results pre-filled in the UI.
5. Verify that the failed tool call(s) remain editable and a toast appears indicating how many failed.
6. Verify that when all tool calls succeed, behavior is unchanged — results are submitted automatically.

```sh
cd ui
pnpm i || npm i
pnpm build || npm run build
```

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
@akshaydeo akshaydeo mentioned this pull request May 29, 2026
18 tasks
akshaydeo added a commit that referenced this pull request May 29, 2026
## Summary

This PR releases **core v1.5.14**, **framework v1.3.14**, **transports v1.5.6**, and bumps all dependent plugins to their respective `.14` patch versions. It delivers a broad set of new capabilities across MCP authentication, key rotation, OTel metrics, Bedrock/Anthropic compatibility, and UI improvements, alongside a number of targeted bug fixes and refactors.

## Changes

- **Direct API Key Header** — Providers can now receive an API key passed directly via a request header (#3817)
- **MCP Per-User Auth** — Introduced `MCPCredentialStore` abstraction, per-user MCP credential reconciliation, and a new per-user header auth type with lazy-auth submission flow (#3656, #3702, #3703, #3704, #3705)
- **MCP TLS Configuration** — Added configurable TLS (`insecureSkipVerify`, `caCertPem`) for HTTP/SSE MCP client connections (#3779, #3783)
- **MCP Sessions Management** — Filter, search, and pagination on the MCP sessions list API and table, plus a `can_reauth` identity gate (#3823, #3824, #3825)
- **Key Rotation** — Keys now rotate on 401/402/403 responses; returns `502 upstream_credentials_exhausted` when all keys are permanently exhausted. Added `triggered_rotation` to `KeyAttemptRecord` and tightened `bifrost_key_rotation_events_total` semantics (#3430, #3491)
- **OTel Metrics** — Added OTel spec-compatible metrics (backward compatible) with provider cache and semantic cache attributes in metrics export (#3865, #3816)
- **Opus 4.8 Support** — System message handling and general compatibility for Opus 4.8 (#3868, #3878)
- **Dimension Rankings** — New `GetDimensionRankings` API and dashboard tabs for team, customer, BU, and user rankings (#3766)
- **Model Pricing Attributes** — `additional_attributes` field on model pricing rows with management API and UI editor (#3829)
- **Prompt Cache Retention** — Added prompt cache retention parameter on responses requests (#3810)
- **Tool Call Execution UI** — Inline tool-call execution, stop streaming, bulk execute/submit, and a redesigned tool-call UI (#3837, #3843)
- **Sheet Navigation** — Prev/next keyboard navigation and URL state across virtual key, MCP client, and routing rule sheets (#3739, #3740, #3744, #3745)
- **Bedrock Tool Name Truncation** — Truncate Bedrock function/tool names to the provider length limit
- **Bedrock Guardrails** — Set guardrail config in Bedrock requests built from responses (#3862)
- **Anthropic Tool Use** — Default `tool_use` input to `{}` when arguments are absent (#3880)
- **Responses Streaming** — Fixed responses stream events (#3838)
- **Compat Flow** — Fixed missing parameter parsing on the compat flow (#3881)
- **Passthrough API Version** — Set a default API version in passthrough requests as a fallback (#3853)
- **Virtual Key Updates** — Avoid overriding optional fields during virtual key update (#3855)
- **User-Mode Flows** — Gate user-mode flows on caller `user_id`, skip temp token mint, and unify flow/credential kind filtering for pending flows (#3841, #3859)
- **Partial Tool Calls** — Handle partial tool call execution failures and return successful results (#3849)
- **URL Query Escaping** — Support escaped characters in URL query parameters (#3826)
- **MCP Auth Errors** — Inline banner and retry support for MCP auth-required errors (#3856)
- **Renamed Resolvers** — `staticHeadersResolver`/`serverOAuthResolver` renamed to `sharedHeadersResolver`/`sharedOAuthResolver` (#3840)
- **Starlark Nested Tool Calls** — Exposed `RunWithPluginPipeline` on `ClientManager` and routed Starlark nested tool calls through the canonical plugin gate (#3794)
- **Deferred-Fill OAuth Removed** — Removed deferred-fill user-mode OAuth flow support (#3839)
- **Go 1.26.3** — Upgraded toolchain to Go 1.26.3 (#3782)

## Type of change

- [x] Bug fix
- [x] Feature
- [x] Refactor
- [ ] Documentation
- [x] Chore/CI

## Affected areas

- [x] Core (Go)
- [x] Transports (HTTP)
- [x] Providers/Integrations
- [x] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

```sh
# Core/Transports
go version  # should report go1.26.3
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build
```

- Validate MCP per-user auth by configuring a per-user header auth type and confirming credentials are stored and reconciled on virtual key and MCP client changes.
- Validate key rotation by triggering a 401/402/403 from an upstream provider and confirming rotation occurs; exhaust all keys and confirm a `502 upstream_credentials_exhausted` is returned.
- Validate OTel metrics output includes `provider_cache` and `semantic_cache` attributes.
- Validate Bedrock requests with tool names exceeding the provider limit are truncated correctly.
- Validate Opus 4.8 system message handling by sending a request with a system message to an Opus 4.8 endpoint.

## Breaking changes

- [x] Yes
- [ ] No

The deferred-fill user-mode OAuth flow has been removed (#3839). Any integrations relying on that flow must migrate to the new per-user credential store approach. The `staticHeadersResolver` and `serverOAuthResolver` identifiers have been renamed to `sharedHeadersResolver` and `sharedOAuthResolver` respectively (#3840); any direct references must be updated.

## Related issues

#3817, #3656, #3702, #3703, #3704, #3705, #3779, #3783, #3823, #3824, #3825, #3430, #3491, #3865, #3816, #3868, #3878, #3766, #3829, #3810, #3837, #3843, #3739, #3740, #3744, #3745, #3862, #3880, #3838, #3881, #3853, #3855, #3841, #3859, #3849, #3826, #3856, #3840, #3794, #3839, #3782, #3724, #3814, #3836, #3869, #3886

## Security considerations

- MCP per-user credentials are stored via the new `MCPCredentialStore` abstraction; ensure the backing store is appropriately access-controlled and that credential values are encrypted at rest.
- The direct API key header feature passes provider secrets via HTTP headers; ensure TLS is enforced on all ingress paths and that headers are not logged in plaintext.
- User-mode flows are now gated on `caller user_id` and temp token minting is skipped where appropriate, reducing the surface for privilege escalation.
- TLS configuration for MCP HTTP/SSE connections supports `insecureSkipVerify`; this should only be enabled in controlled environments.

## Checklist

- [x] I read `docs/contributing/README.md` and followed the guidelines
- [x] I added/updated tests where appropriate
- [x] I updated documentation where needed
- [x] I verified builds succeed (Go and UI)
- [x] I verified the CI pipeline passes locally if applicable
@akshaydeo akshaydeo mentioned this pull request May 29, 2026
akshaydeo added a commit that referenced this pull request May 29, 2026
## ✨ Features

- **Direct API Key Header** - Pass a provider API key directly via
request header (#3817)
- **MCP Per-User Authentication** - New per-user header auth type with
credential storage
  and lazy-auth submission flow (#3703, #3704, #3705)
- **MCP TLS Configuration** - Configurable TLS (insecureSkipVerify,
caCertPem) for HTTP/SSE
  MCP client connections (#3779, #3783)
- **MCP Sessions Management** - Filter, search, and pagination on the
MCP sessions list API
  and table, plus a can_reauth identity gate (#3823, #3824, #3825)
- **Tool Call Execution UI** - Inline tool-call execution, stop
streaming, bulk
  execute/submit, and a redesigned tool-call UI (#3837, #3843)
- **Dimension Rankings Dashboard** - New dashboard tabs for team,
customer, BU, and user
  rankings, backed by a GetDimensionRankings API (#3766)
- **Model Pricing Attributes** - additional_attributes on model pricing
rows with management
  API and UI editor (#3829)
- **Prompt Cache Retention** - Prompt cache retention parameter on
responses requests
  (#3810)
- **Opus 4.8 Support** - System message handling and compatibility for
Opus 4.8 (#3878,
  #3868)
  - **Key Rotation** - Rotate keys on 401/402/403 and return 502
upstream_credentials_exhausted when all keys are permanently dead
(#3491)
- **OTel Metrics** - OTel spec compatible metrics plus provider and
semantic cache
  attributes in metrics export (#3865, #3816)
- **Sheet Navigation** - Prev/next keyboard navigation and URL state
across virtual key, MCP
  client, and routing rule sheets (#3739, #3740, #3744, #3745)
  - **Go 1.26.3** - Upgraded toolchain to Go 1.26.3 (#3782)

  ## 🐞 Fixed

- **Bedrock Tool Names** - Truncate Bedrock function/tool names to the
provider length limit
- **Bedrock Guardrails** - Set guardrail config in Bedrock request built
from responses
  (#3862)
- **Anthropic Tool Use** - Default Anthropic tool_use input to {} when
arguments are absent
  (#3880)
  - **Responses Streaming** - Fixed responses stream events (#3838)
- **Compat Flow** - Fixed missing parameter parsing on the compat flow
(#3881)
- **Passthrough API Version** - Set a default API version in passthrough
requests as a
  fallback (#3853)
- **Virtual Key Updates** - Avoid overriding optional fields during
virtual key update
  (#3855)
- **User-Mode Flows** - Gate user-mode flows on caller user_id, skip
temp token mint, and
  unify flow/credential kind filtering for pending flows (#3841, #3859)
- **Partial Tool Calls** - Handle partial tool call execution failures
and return successful
  results (#3849)
- **URL Query Escaping** - Support escaped characters in URL query
parameters (#3826)
- **MCP Auth Errors** - Inline banner and retry support for MCP
auth-required errors (#3856)
- **JSON Editor Height** - Cap JSON editor max height at 400px in
message views (#3842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants