fix: exclude sonner toast elements from sheet outside-click detection

[impoiler]

Summary

Fixes an issue where clicking on Sonner toast notifications while a Sheet component is open would incorrectly trigger the sheet's outside-click detection, causing unintended sheet dismissal.

Changes

• Added [data-sonner-toast] and [data-sonner-toaster] to the list of portaled elements that the SheetContent outside-click handler ignores, preventing toasts from being treated as clicks outside the sheet.

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

1. Open a Sheet component in the UI.
2. Trigger a Sonner toast notification while the sheet is open.
3. Click on the toast notification.
4. Verify the sheet remains open and is not dismissed by the toast click.

cd ui
pnpm i || npm i
pnpm build || npm run build

Screenshots/Recordings

N/A

Breaking changes

• Yes
• No

Related issues

N/A

Security considerations

None.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

Warning

Review limit reached

@impoiler, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 4 minutes and 18 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d9e4bef8-510f-4865-be5f-44c73fb67907

📥 Commits

Reviewing files that changed from the base of the PR and between 61c6161 and 7652ab8.

📒 Files selected for processing (1)

• ui/components/ui/sheet.tsx

📝 Walkthrough

Walkthrough

The Sheet component's outside-interaction suppression logic is expanded to recognize additional portal-like elements (Radix Popper content and Sonner toast elements) as portaled targets, preventing outside handlers from executing when interactions occur within these elements.

Changes

Sheet portal element detection

Layer / File(s)	Summary
Portal element detection expansion ui/components/ui/sheet.tsx	isPortaledElement helper now includes additional target.closest() checks for Radix Popper content wrapper and Sonner toast elements, expanding which outside interactions are suppressed in handlePointerDownOutside and handleInteractOutside.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• maximhq/bifrost#3674: Addresses Sonner toast interaction during overlay usage by ensuring toasts remain clickable via CSS while this PR prevents Sheet outside-interaction handlers from firing on toast elements.
• maximhq/bifrost#3598: Changes to the Sonner Toaster positioning and close button interact with this PR's expansion of Sonner toast element detection in Sheet's outside-interaction logic.

Suggested reviewers

• akshaydeo

Poem

🐰 A Sheet learned to see through the Sonner toast,
And past Radix poppers that hover the most,
No handlers shall fire when portals appear,
The cleanest of clicks, both far and near!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: excluding Sonner toast elements from the sheet's outside-click detection logic.
Description check	✅ Passed	The description includes all critical sections: a clear summary of the problem, specific changes made, type of change, affected areas, testing steps, and confirmation of no breaking changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 05-27-fix_prevent_sheets_closing_on_toast_dismiss

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[impoiler]

• feat: replace enabled badge with toggle switch and add edit action in MCP clients table #3809
• fix: exclude sonner toast elements from sheet outside-click detection #3805 👈 (View in Graphite)
• refactor: reuse SheetNavigationButtons component and useSheetNavigation hook #3804
• refactor: extract dashboard tab data-fetching into dedicated TabView components #3797
• feat: add GetDimensionRankings API and dashboard tabs for team, customer, BU, and user rankings #3766
• refactor: replace TeamDialog with TeamSheet and improve teams table layout #3757
• feat: add SearchSelect component with sync and async support #3752
• fix: persist customers pagination/search in URL state and improve table layout #3751
• feat: add prev/next navigation to RoutingRuleInfoSheet #3745
• feat: add prev/next navigation to MCPClientSheet #3744
• feat: add keyboard navigation and URL state for virtual key detail sheet #3740
• feat: add useSheetNavigation hook and SheetNavigationButtons component #3739
• refactor: replace CustomerDialog with CustomerSheet for customer create/edit #3726
• feat: log database type when connecting in NewConfigStore #3724
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Confidence Score: 5/5

Safe to merge — the change is a two-line selector addition inside an existing exclusion list with no impact on other code paths.

The change is narrowly scoped to adding two well-understood CSS attribute selectors that match Sonner's documented DOM attributes. It follows the same pattern already used for react-select and Radix poppers, and does not touch any logic outside the isPortaledElement helper.

No files require special attention.

Important Files Changed

Filename	Overview
ui/components/ui/sheet.tsx	Adds [data-sonner-toast] and [data-sonner-toaster] to the portaled-element exclusion list in isPortaledElement, preventing Sonner toast clicks from dismissing open sheets.

_{Reviews (5): Last reviewed commit: "fix: prevent sheets closing on toast dis..." | Re-trigger Greptile}

[akshaydeo]

Merge activity

• May 27, 1:44 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 27, 2:03 PM UTC: @akshaydeo merged this pull request with Graphite.

The base branch was changed.